From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#27284: [PATCH 1/8] build: Factorize module compilation in (guix
	build compile).
Date: Sun, 22 Oct 2017 18:50:57 -0700
Message-ID: <87a80iws1q.fsf@gnu.org>
References: <87poamv2i7.fsf@gnu.org> <20171020160557.27096-1-ludo@gnu.org>
	<20171020160557.27096-2-ludo@gnu.org> <87efpu5142.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56974)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e6RuP-0006Yv-T6
	for bug-guix@gnu.org; Sun, 22 Oct 2017 21:52:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e6RuM-0007Xd-8K
	for bug-guix@gnu.org; Sun, 22 Oct 2017 21:52:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:47742)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1e6RuM-0007X5-3u
	for bug-guix@gnu.org; Sun, 22 Oct 2017 21:52:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.27284.B27284.150872346521945@debbugs.gnu.org>
In-Reply-To: <87efpu5142.fsf@gmail.com> (Maxim Cournoyer's message of "Sun, 22
	Oct 2017 17:22:37 -0400")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 27284@debbugs.gnu.org, Eric Bavier <bavier@member.fsf.org>

Hi Maxim,

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> * guix/build/compile.scm: New file.
>> * Makefile.am (MODULES): Add it.
>> * build-aux/compile-all.scm: Use it.
>> (warnings, file->module, load-module-file)
>> (%default-optimizations, %lightweight-optimizations)
>> (optimization-options, compile-file*): Remove.
>> <top level>: Use 'compile-files'.
>> * guix/build/pull.scm (%default-optimizations)
>> (%lightweight-optimizations, optimization-options): Remove.
>> (build-guix): Rewrite as a call to 'compile-files'.
>> * guix/discovery.scm (file-name->module-name): Export.
>> ---
>>  Makefile.am               |   1 +
>>  build-aux/compile-all.scm |  92 ++++----------------------
>>  guix/build/compile.scm    | 165 +++++++++++++++++++++++++++++++++++++++=
+++++++
>>  guix/build/pull.scm       | 105 ++++++++---------------------
>>  guix/discovery.scm        |   4 +-
>>  5 files changed, 209 insertions(+), 158 deletions(-)
>>  create mode 100644 guix/build/compile.scm
>
> [...]
>
> This and the other patches in this series look fine to me.

Awesome, thanks for looking.

> Maybe the change log items could be a bit more precise about what got
> moved rather than removed, but given the amount of refactoring this
> might be too verbose to be worth it?

Well, yes to both.  :-)

Speaking of the =E2=80=9Cmake -j=E2=80=9D patch, on IRC Eric Bavier suggest=
ed that it
didn=E2=80=99t work as advertised because $MAKEFLAGS didn=E2=80=99t contain=
 the =E2=80=9C-j=E2=80=9D
flag; I just checked and it does contain it here (with GNU=C2=A0make 4.2.1).
So no problem after all?

Thanks,
Ludo=E2=80=99.