From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: bug#29363: Single test failure building Guix Date: Tue, 21 Nov 2017 01:31:04 +0100 Message-ID: <87a7zgtquv.fsf@fastmail.com> References: <89edb4cc307bfae5db7812abe3b4a37a@mykolab.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGwTt-0005s2-UR for bug-guix@gnu.org; Mon, 20 Nov 2017 19:32:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGwTq-0005kU-OM for bug-guix@gnu.org; Mon, 20 Nov 2017 19:32:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:40999) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eGwTq-0005kF-GU for bug-guix@gnu.org; Mon, 20 Nov 2017 19:32:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eGwTq-000143-4Q for bug-guix@gnu.org; Mon, 20 Nov 2017 19:32:02 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <89edb4cc307bfae5db7812abe3b4a37a@mykolab.com> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Rutger Helling , 29363@debbugs.gnu.org --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Rutger, Rutger Helling writes: > when building Guix with 'guix build guix' I keep running into a single=20 > test failure. I've attached the test-suite.log. Is this a Btrfs system by any chance, possibly on an SSD? > test-name: dead path can be explicitly collected > location: /tmp/guix-build-guix-0.13.0-10.0b4c385.drv-0/source/tests/store= .scm:178 > source: > + (test-assert > + "dead path can be explicitly collected" > + (let ((p (add-text-to-store > + %store > + "random-text" > + (random-text) > + '()))) > + (let-values > + (((paths freed) (delete-paths %store (list p)))) > + (and (equal? paths (list p)) > + (> freed 0) > + (not (file-exists? p)))))) > actual-value: #f > result: FAIL I can reproduce this error on two different systems that have Btrfs+LUKS+SSD, and the problem is that freed =3D=3D 0. I suspect it's related to Btrfs' "lazy" reporting of disk space, but haven't dug very far. Until we figure out what's going on, I suggest applying the patch below. Can you confirm that it works on your system? --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-guix-Disable-test-that-fails-on-Btrfs.patch Content-Transfer-Encoding: quoted-printable From=20bdc7b5310111e21801529ea57e290f6eb72ac6ed Mon Sep 17 00:00:00 2001 From: Marius Bakke Date: Tue, 21 Nov 2017 00:27:08 +0100 Subject: [PATCH] gnu: guix: Disable test that fails on Btrfs. Works around . Reported by Rutger Helling . * gnu/packages/package-management.scm (guix)[arguments]: Rename 'disable-container-tests' phase to 'disable-failing-tests' and add substitu= tion to disable "dead path can be explicitly collected" test. =2D-- gnu/packages/package-management.scm | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-man= agement.scm index 4f1f7f577..3321ab1eb 100644 =2D-- a/gnu/packages/package-management.scm +++ b/gnu/packages/package-management.scm @@ -169,8 +169,7 @@ (copy "armhf") (copy "aarch64") #t)) =2D (add-after =2D 'unpack 'disable-container-tests + (add-after 'unpack 'disable-failing-tests ;; XXX FIXME: These tests fail within the build cont= ainer. (lambda _ (substitute* "tests/syscalls.scm" @@ -183,6 +182,11 @@ (substitute* "tests/guix-environment-container.s= h" (("guix environment --version") "exit 77\n"))) + ;; XXX: This test may fail on some file systems. + ;; See . + (substitute* "tests/store.scm" + (("^(.*dead path can be explicitly collected\")"= all) + (string-append "(test-skip 1)\n" all))) #t)) (add-before 'check 'set-SHELL (lambda _ =2D-=20 2.15.0 --=-=-= Content-Type: text/plain Ludo, WDYT? --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAloTc8gACgkQoqBt8qM6 VPp3VggAyASN/948LEV659qQUmlVVDOVJWibXdyBPu92Vo0VLGMoDxgOt+qBgRM7 iFx8aeEIvIHE+Rq6V7/WRDfZvoXgNiTI9khHHbgVVMsLWbmnwLjBqH5Nv2Lxx0Je yAQ94T2/r1PJCGwP4T3kDIKT6x6uCcvPkuVksfsIpZ9VBfhPljp9nVP+VqxBOL42 1tEwlXbB+12p+CklVHtomvBkE2SiPNW3IsamZT7LKiQg6UJmFUSzHSAuwWwVQ2Ax 6SSyXMshuFJc9G0Bgc2PS0iGL3YdECMNJfibGAY+dXnWGUDBegKQ3xHU2eZewnRE V1c01x+iW6Vdh5ugh2gaRmfIlBCL/Q== =05cl -----END PGP SIGNATURE----- --==-=-=--