From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQSQg-0006Cg-EO for guix-patches@gnu.org; Sun, 17 Dec 2017 01:28:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eQSQd-0001Dl-5J for guix-patches@gnu.org; Sun, 17 Dec 2017 01:28:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:57521) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eQSQc-0001D9-Vg for guix-patches@gnu.org; Sun, 17 Dec 2017 01:28:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eQSQc-0007Hn-IT for guix-patches@gnu.org; Sun, 17 Dec 2017 01:28:02 -0500 Subject: [bug#29745] [PATCH 0/3] Disallow phase returning . Resent-Message-ID: References: <20171216231242.12032-1-arunisaac@systemreboot.net> From: Ricardo Wurmus In-reply-to: <20171216231242.12032-1-arunisaac@systemreboot.net> Date: Sun, 17 Dec 2017 07:27:04 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-ID: <87a7yhoonb.fsf@elephly.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac Cc: 29745@debbugs.gnu.org Hi, > Patch 1 modifies gnu-build-system to explicitly check the return value of= each > phase for an unspecified value, and if found consider that phase to have > failed. > > Patch 2 fixes several phases in gnu-build-system by making them return #t > instead of an unspecified value. > > Patch 3 fixes the phases in several packages to return #t instead of an > unspecified value. I was testing patch 1, by trying to build bash. In doi= ng > so, I found that the custom phases of many packages were not properly > returning #t, and fixed all those packages. No doubt, there are many more > packages that need fixing. this is a step in the right direction. Thank you for these patches. In my opinion, this can go straight to core-updates, but as it is a change with wide-ranging consequences, I=E2=80=99d prefer for Ludovic to confirm t= hat it=E2=80=99s okay. -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net