all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 29745@debbugs.gnu.org
Subject: [bug#29745] [PATCH 0/3] Disallow phase returning <unspecified>.
Date: Sun, 17 Dec 2017 07:27:04 +0100	[thread overview]
Message-ID: <87a7yhoonb.fsf@elephly.net> (raw)
In-Reply-To: <20171216231242.12032-1-arunisaac@systemreboot.net>


Hi,

> Patch 1 modifies gnu-build-system to explicitly check the return value of each
> phase for an unspecified value, and if found consider that phase to have
> failed.
>
> Patch 2 fixes several phases in gnu-build-system by making them return #t
> instead of an unspecified value.
>
> Patch 3 fixes the phases in several packages to return #t instead of an
> unspecified value. I was testing patch 1, by trying to build bash. In doing
> so, I found that the custom phases of many packages were not properly
> returning #t, and fixed all those packages. No doubt, there are many more
> packages that need fixing.

this is a step in the right direction.  Thank you for these patches.  In
my opinion, this can go straight to core-updates, but as it is a change
with wide-ranging consequences, I’d prefer for Ludovic to confirm that
it’s okay.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

  parent reply	other threads:[~2017-12-17  6:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-16 23:12 [bug#29745] [PATCH 0/3] Disallow phase returning <unspecified> Arun Isaac
2017-12-16 23:16 ` [bug#29745] [PATCH 1/3] build: gnu-build-system: " Arun Isaac
2017-12-16 23:16   ` [bug#29745] [PATCH 2/3] build: gnu-build-system: Return #t from phases Arun Isaac
2017-12-16 23:16   ` [bug#29745] [PATCH 3/3] gnu: " Arun Isaac
2017-12-17  6:27 ` Ricardo Wurmus [this message]
2017-12-17 16:55 ` [bug#29745] [PATCH 0/3] Disallow phase returning <unspecified> Ludovic Courtès
2017-12-17 17:47   ` Arun Isaac
2017-12-18  8:01     ` Ludovic Courtès
2017-12-18  8:44       ` Ricardo Wurmus
2017-12-28 11:43         ` bug#29745: " Arun Isaac
2017-12-18  9:06       ` [bug#29745] " Arun Isaac
2017-12-19  8:38         ` Ludovic Courtès
2017-12-19 21:58           ` Mark H Weaver
2017-12-18  9:26       ` Andreas Enge
2017-12-17 18:14   ` Marius Bakke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7yhoonb.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=29745@debbugs.gnu.org \
    --cc=arunisaac@systemreboot.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.