From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecPJW-0001Xr-4s for guix-patches@gnu.org; Fri, 19 Jan 2018 00:34:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecPJS-0001If-Um for guix-patches@gnu.org; Fri, 19 Jan 2018 00:34:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:54287) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ecPJS-0001IQ-Ou for guix-patches@gnu.org; Fri, 19 Jan 2018 00:34:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ecPJS-0001Pf-Fv for guix-patches@gnu.org; Fri, 19 Jan 2018 00:34:02 -0500 Subject: [bug#30096] [PATCH 2/6] gnu: Add ocaml-integers. Resent-Message-ID: References: <87lgh2uigo.fsf@gmail.com> <87inc6ui1c.fsf@gmail.com> <20180113140845.12d7b50e@lepiller.eu> From: Peter Kreye In-reply-to: <20180113140845.12d7b50e@lepiller.eu> Date: Thu, 18 Jan 2018 23:32:48 -0600 Message-ID: <87a7xaifb3.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Julien Lepiller Cc: 30096@debbugs.gnu.org --=-=-= Content-Type: text/plain Julien, Thank you for all of the feedback, it is much appreciated. Julien Lepiller writes: > Actually, I forgot to ask, why disable tests? > > That's the same question for the rest of your patches too. This package doesn't have any tests, which seems to be causing the 'check phase to fail. Would it be better to use "#:tests? #f" or to delete the 'check phase? > You don't need to replace the 'build phase. ocaml-build-system can find > pkg/pkg.ml. You just need to use #:build-flags (list "build") to add > arguments. > > That applies also to the rest of your patches. Thank you for this info. I'll make sure to do this from now on. > It's probably better to use "#:findlib ,ocaml-findlib-1.7.3" in the > arguments list. Same. -- --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-Add-ocaml-integers.patch >From 3e3d3cf9775fb95d22ecf1422a81e7ae582176ce Mon Sep 17 00:00:00 2001 From: Peter Kreye Date: Thu, 18 Jan 2018 22:38:07 -0600 Subject: [PATCH] gnu: Add ocaml-integers. To: 30096@debbugs.gnu.org * gnu/packages/ocaml.scm (ocaml-integers): New variable. --- gnu/packages/ocaml.scm | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm index e70316cd7..ca731001f 100644 --- a/gnu/packages/ocaml.scm +++ b/gnu/packages/ocaml.scm @@ -3739,6 +3739,37 @@ terminal or in Emacs. It supports line editing, history, real-time and context sensitive completion, colors, and more.") (license license:bsd-3))) +(define-public ocaml-integers + (package + (name "ocaml-integers") + (version "0.2.2") + (home-page "https://github.com/ocamllabs/ocaml-integers") + (source (origin + (method url-fetch) + (uri (string-append home-page + "/releases/download/v0.2.2/integers-" + version ".tbz")) + (file-name (string-append name "-" version ".tbz")) + (sha256 + (base32 + "08b1ljw88ny3l0mdq6xmffjk8anfc77igryva5jz1p6f4f746ywk")))) + (build-system ocaml-build-system) + (arguments + `(#:findlib ,ocaml-findlib-1.7.3 + #:build-flags (list "build") + #:phases + (modify-phases %standard-phases + (delete 'configure) + (delete 'check)))) + (inputs + `(("topkg" ,ocaml-topkg) + ("opam", opam))) + (synopsis "Various signed and unsigned integer types for OCaml") + (description "The ocaml-integers library provides a number of 8-, 16-, 32- +and 64-bit signed and unsigned integer types, together with aliases such as +long and size_t whose sizes depend on the host platform.") + (license license:expat))) + (define-public coq-flocq (package (name "coq-flocq") -- 2.14.2 --=-=-=--