From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejO59-00087a-R7 for guix-patches@gnu.org; Wed, 07 Feb 2018 06:40:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ejO55-0003rq-Tz for guix-patches@gnu.org; Wed, 07 Feb 2018 06:40:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:53017) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ejO55-0003rd-Pu for guix-patches@gnu.org; Wed, 07 Feb 2018 06:40:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ejO55-00034z-JM for guix-patches@gnu.org; Wed, 07 Feb 2018 06:40:03 -0500 Subject: [bug#30379] [PATCH] gnu: bash: Don't specify default configuration filenames. Resent-Message-ID: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44469) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejO4R-0007cs-9C for guix-patches@gnu.org; Wed, 07 Feb 2018 06:39:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ejO4N-0003Xp-7v for guix-patches@gnu.org; Wed, 07 Feb 2018 06:39:23 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33902) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejO4N-0003Xh-31 for guix-patches@gnu.org; Wed, 07 Feb 2018 06:39:19 -0500 Received: from ip-80-113-14-101.ip.prioritytelecom.net ([80.113.14.101]:7728 helo=yellowstone) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ejO4L-0005Zk-ET for guix-patches@gnu.org; Wed, 07 Feb 2018 06:39:18 -0500 From: Roel Janssen Message-ID: <87a7wlkp3a.fsf@gnu.org> Date: Wed, 07 Feb 2018 12:39:09 +0100 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 30379@debbugs.gnu.org --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-bash-Don-t-specify-default-configuration-filenam.patch >From 6111b46f82a00560fa50f8860a4e9fd6b19fd0f1 Mon Sep 17 00:00:00 2001 From: Roel Janssen Date: Wed, 7 Feb 2018 12:29:22 +0100 Subject: [PATCH] gnu: bash: Don't specify default configuration filenames. * gnu/packages/bash.scm (bash): Remove SYS_BASHRC and SYS_BASH_LOGOUT. --- gnu/packages/bash.scm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/gnu/packages/bash.scm b/gnu/packages/bash.scm index b8b0ae58f..59c3f6f10 100644 --- a/gnu/packages/bash.scm +++ b/gnu/packages/bash.scm @@ -92,9 +92,7 @@ number/base32-hash tuples, directly usable in the 'patch-series' form." 1)) (define-public bash - (let* ((cppflags (string-join '("-DSYS_BASHRC='\"/etc/bashrc\"'" - "-DSYS_BASH_LOGOUT='\"/etc/bash_logout\"'" - "-DDEFAULT_PATH_VALUE='\"/no-such-path\"'" + (let* ((cppflags (string-join '("-DDEFAULT_PATH_VALUE='\"/no-such-path\"'" "-DSTANDARD_UTILS_PATH='\"/no-such-path\"'" "-DNON_INTERACTIVE_LOGIN_SHELLS" "-DSSH_SOURCE_BASHRC") -- 2.16.1 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Dear guix, In bug #29337 I reported a “problem” with our Bash package: It reads /etc/bashrc even when it shouldn't, according to its own documentation. I also compared the behavior of Bash on CentOS to that of Bash on Guix with the following test: > On CentOS 7, the following happens (yes, I added the echo-statement to > /etc/bashrc on CentOS as well): > $ env - bash --init-file <(echo "echo \"Goodbye, world\"") -i > Goodbye, world > > On GuixSD: > $ env - bash --init-file <(echo "echo \"Goodbye, world\"") -i > Hello, world > Goodbye, world I attached the proposed patch (removing -DSYS_BASHRC). May I push this to core-updates now, or should I wait for the next core-updates cycle? Thanks! Kind regards, Roel Janssen --=-=-=--