From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32821)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1exGUv-0001eA-8f
	for guix-patches@gnu.org; Sat, 17 Mar 2018 14:24:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1exGUs-0007sp-3J
	for guix-patches@gnu.org; Sat, 17 Mar 2018 14:24:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:58986)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1exGUr-0007rx-VW
	for guix-patches@gnu.org; Sat, 17 Mar 2018 14:24:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1exGUr-0005mR-PZ
	for guix-patches@gnu.org; Sat, 17 Mar 2018 14:24:01 -0400
Subject: [bug#30572] [PATCH 2/7] tests: Add tests for "guix pack".
Resent-Message-ID: <handler.30572.B30572.152131101522184@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180222102933.4978-1-cmmarusich@gmail.com>
	<20180315040915.5556-1-cmmarusich@gmail.com>
	<20180315040915.5556-3-cmmarusich@gmail.com>
	<20180316220732.19c2375a@scratchpost.org>
Date: Sat, 17 Mar 2018 19:23:29 +0100
In-Reply-To: <20180316220732.19c2375a@scratchpost.org> (Danny Milosavljevic's
	message of "Fri, 16 Mar 2018 22:07:32 +0100")
Message-ID: <87a7v6pnmm.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: bug#30572 <30572@debbugs.gnu.org>, Chris Marusich <cmmarusich@gmail.com>

Danny Milosavljevic <dannym@scratchpost.org> skribis:

>> +is_available () {
>> +    # Use the "type" shell builtin to see if the program is on PATH.
>> +    type "$1"
>
> Maybe >/dev/null ?  Then it would only complain if it needed to.
>
>> +else
>> +    echo "skipping pack verification because chroot or unshare is unavailable"
>
> echo "warning: Skipping pack verification because chroot or unshare is unavailable" >&2
>
> Otherwise LGTM!

+1!

Ludo'.