From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45795)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fLxq8-0006wl-4X
	for guix-patches@gnu.org; Thu, 24 May 2018 17:32:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fLxq7-0000db-7l
	for guix-patches@gnu.org; Thu, 24 May 2018 17:32:04 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:39054)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fLxq7-0000dV-5J
	for guix-patches@gnu.org; Thu, 24 May 2018 17:32:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fLxq6-0004JK-W6
	for guix-patches@gnu.org; Thu, 24 May 2018 17:32:03 -0400
Subject: [bug#31430] [PATCH 2/3] gnu: Add xtl.
Resent-Message-ID: <handler.31430.B31430.152719747516490@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <BLUPR16MB05004A2B1B8291FA97CD7597929E0@BLUPR16MB0500.namprd16.prod.outlook.com>
	<BLUPR16MB0500083469A5124487D7687F929E0@BLUPR16MB0500.namprd16.prod.outlook.com>
Date: Thu, 24 May 2018 23:31:04 +0200
In-Reply-To: <BLUPR16MB0500083469A5124487D7687F929E0@BLUPR16MB0500.namprd16.prod.outlook.com>
	(Fis Trivial's message of "Sat, 12 May 2018 14:24:52 +0000")
Message-ID: <87a7sou4fb.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Fis Trivial <ybbs.daans@hotmail.com>
Cc: "31430@debbugs.gnu.org" <31430@debbugs.gnu.org>

Fis Trivial <ybbs.daans@hotmail.com> skribis:

> * gnu/packages/cpp.scm (xtl): New variable.

[...]

> +         (replace 'check
> +           (lambda* _
> +             (invoke "make" "test_xtl")
> +             (chdir "test")
> +             (invoke "./test_xtl")
> +             (chdir ".."))))))

Instead of chdir, rather do:

  (with-directory-excursion "test"
    (invoke "./test_xtl")
    #t)

> +    (home-page "https://github.com/QuantStack/xtl")
> +    (build-system cmake-build-system)
> +    (synopsis "C++ template library providing some basic tools")
> +    (description "xtl is a C++ header-only template library providing ba=
sic
> +tools (containers, algorithms) used by other quantstack packages")

I know it=E2=80=99s from upstream, but please s/quantstack/QuantStack/ and =
add a
period at the end.

Could you send an updated patch?

Ludo=E2=80=99.