all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Fis Trivial <ybbs.daans@hotmail.com>
Cc: "31430@debbugs.gnu.org" <31430@debbugs.gnu.org>
Subject: [bug#31430] [PATCH 2/3] gnu: Add xtl.
Date: Thu, 24 May 2018 23:31:04 +0200	[thread overview]
Message-ID: <87a7sou4fb.fsf@gnu.org> (raw)
In-Reply-To: <BLUPR16MB0500083469A5124487D7687F929E0@BLUPR16MB0500.namprd16.prod.outlook.com> (Fis Trivial's message of "Sat, 12 May 2018 14:24:52 +0000")

Fis Trivial <ybbs.daans@hotmail.com> skribis:

> * gnu/packages/cpp.scm (xtl): New variable.

[...]

> +         (replace 'check
> +           (lambda* _
> +             (invoke "make" "test_xtl")
> +             (chdir "test")
> +             (invoke "./test_xtl")
> +             (chdir ".."))))))

Instead of chdir, rather do:

  (with-directory-excursion "test"
    (invoke "./test_xtl")
    #t)

> +    (home-page "https://github.com/QuantStack/xtl")
> +    (build-system cmake-build-system)
> +    (synopsis "C++ template library providing some basic tools")
> +    (description "xtl is a C++ header-only template library providing basic
> +tools (containers, algorithms) used by other quantstack packages")

I know it’s from upstream, but please s/quantstack/QuantStack/ and add a
period at the end.

Could you send an updated patch?

Ludo’.

  reply	other threads:[~2018-05-24 21:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-12 14:21 [bug#31430] [PATCH 0/3] gnu: Add xtensor and its dependencies Fis Trivial
2018-05-12 14:23 ` [bug#31430] [PATCH 1/3] gnu: Add json-modern-cxx Fis Trivial
2018-05-12 14:24 ` [bug#31430] [PATCH 2/3] gnu: Add xtl Fis Trivial
2018-05-24 21:31   ` Ludovic Courtès [this message]
2018-05-25  8:46     ` Fis Trivial
2018-05-12 14:25 ` [bug#31430] [PATCH 3/3] gnu: Add xtensor Fis Trivial
2018-05-24 21:34   ` Ludovic Courtès
2018-05-23 12:09 ` [bug#31430] [PATCH 0/3] gnu: Add xtensor and its dependencies Ludovic Courtès
2018-05-28  7:57 ` [bug#31430] [PATCH 0/6] Add xtensor and its dependencies (new patches) Fis Trivial
2018-05-28  8:08   ` [bug#31430] [PATCH 1/6] gnu: Add catch-framework2 Fis Trivial
2018-05-28  8:09   ` [bug#31430] [PATCH 2/6] gnu: Add amalgamate Fis Trivial
2018-05-28 11:44     ` Ludovic Courtès
2018-05-28  8:10   ` [bug#31430] [PATCH 3/6] gnu: Add fifo-map Fis Trivial
2018-05-28 11:48     ` Ludovic Courtès
2018-05-28  8:11   ` [bug#31430] [PATCH 4/6] gnu: Add json-modern-cxx Fis Trivial
2018-05-28 12:18     ` Ludovic Courtès
2018-05-28  8:12   ` [bug#31430] [PATCH 5/6] gnu: Add xtl Fis Trivial
2018-05-28  8:12   ` [bug#31430] [PATCH 6/6] gnu: Add xtensor Fis Trivial
2018-05-28 12:24     ` bug#31430: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7sou4fb.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=31430@debbugs.gnu.org \
    --cc=ybbs.daans@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.