From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ful7B-0003Xj-Rq for guix-patches@gnu.org; Tue, 28 Aug 2018 17:01:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fukuA-0001xh-TS for guix-patches@gnu.org; Tue, 28 Aug 2018 16:48:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:59246) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fukuA-0001x4-IP for guix-patches@gnu.org; Tue, 28 Aug 2018 16:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fukuA-00020p-9k for guix-patches@gnu.org; Tue, 28 Aug 2018 16:48:02 -0400 Subject: [bug#32370] [PATCH 1/4] gnu: Add ruby-yajl-ruby. Resent-Message-ID: References: <871sbczxm8.fsf@cbaines.net> <20180805144322.4705-1-mail@cbaines.net> <20180807002840.5df9b494@alma-ubu> From: Christopher Baines In-reply-to: <20180807002840.5df9b494@alma-ubu> Date: Tue, 28 Aug 2018 21:47:46 +0100 Message-ID: <87a7p6b4lp.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Cc: 32370@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Bj=C3=B6rn H=C3=B6fling writes: > On Sun, 5 Aug 2018 15:43:19 +0100 > Christopher Baines wrote: > >> From: Ben Woodcroft >> >> * gnu/packages/ruby.scm (ruby-yajl-ruby): New variable. >> >> Signed-off-by: Christopher Baines >> --- >> gnu/packages/ruby.scm | 33 +++++++++++++++++++++++++++++++++ >> 1 file changed, 33 insertions(+) >> >> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm >> index 908dfd575..a06be3e26 100644 >> --- a/gnu/packages/ruby.scm >> +++ b/gnu/packages/ruby.scm >> @@ -3626,6 +3626,39 @@ features such as filtering and fine grained >> logging.") (home-page >> "https://github.com/pjotrp/bioruby-logger-plugin") (license >> license:expat))) >> +(define-public ruby-yajl-ruby >> + (package >> + (name "ruby-yajl-ruby") >> + (version "1.4.0") > > 1.4.1 is availabe. Do we have a specific reason for 1.4.0? Either > update or explain in a comment (Well, that would be at least my comment > for a 'normal' package. I'm unsure how to handle this one right: It's > part of the Rails-branch and I noticed there are some outdated > packages. They could be outdated just because Ben started in 2016 with > that (and still, there is no Rails in Guix) or there could be a > specific reason for that (i.e Rails or a sub-dependency needs exactly > this version). Or we just say: hey, let's just get these patches in as > they were in 2016 to no longer prolonge this. We can update later). I've updated the version for this package, but yes, in general, I've not been looking too closely at versions, and just been trying to improve the packages in other ways. > License: > > ./ext/yajl/yajl_encode.h: BSD (3 clause) > ./ext/yajl/yajl_ext.c: MIT/X11 (BSD like) > ./ext/yajl/yajl_ext.h: MIT/X11 (BSD like) > ./ext/yajl/yajl_gen.c: BSD (3 clause) > > We already have yajl. Is it possible to use that instead of the "ext" > path? Does that make sense? Should we at least add a TODO-Comment? I've had a look, but there seems to be some differences between the two. So I think for the moment we can't, unless we go to the effort of separating out the differences somehow. I've tried to improve the license information. > When I add --check -K --no-grafts, it says it is not deterministic. But: > > diffoscope /gnu/store/88dhpv16b5l55xf4dh090a6n93sh2akn-ruby-yajl-ruby-1.4= .0 /gnu/store/88dhpv16b5l55xf4dh090a6n93sh2akn-ruby-yajl-ruby-1.4.0-check > | less > > is empty. Is this a general Ruby problem? I do see some differences with diffoscope, but I'm unsure what the source is. I think it could be related to these packages having native extensions. Thanks again for taking a look Bj=C3=B6rn :) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAluFtPJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XcDSxAApZm4z8jMhJZ0gYF38EceLG5HU8HmIi47TkLfxgF0DB4Hy7Zjwe4CnGSe pPeVqQVzXEvUEbA1aLtA3Kt7RITVItEtwkTtlhn89vyZbYTXteuz71Ua4N0Vf0dl c3RhdHyqT5rMwoDuOp0azE3MhJ5blrCpAKPyrfBOs1heJVriTkpjhJlcmuyWuoGR cCYdU+yIraU5oLZK6a6n90rOH/l2ujFgxkJFWvccjkjXn9S5eEDCDxMk6VKUdXDu zOLAvweGLl6hrN454OupZPSK4tK6Dng0RPIy8fP4bTgDrm99jk09ygtxe1r57omG M4eWsF8NNNbjMv1J3IsQd4TgI0YjgeH2aKjdA16lNRHbekftrxV/wtM2IzWit6B5 ENf+SEge4QkXCZsBuz6LNzZKDsxuKt2Nm60PZMlZAKMr7NxzBTYzwSRsSu5ttmIg G1v5jnKJoNiDYIjluwjZiFdJEjOT+drwqNuHOBbSMgKho4CwSzk2rVO/hR6HV4mS N2DZ139mHmeDooOHWvb9x8qN5SVUPuDzaZKektyHMpJ0KdoG+Ny0hLTnmBVxgV/1 MRp8oKO7OL7p4aldqBC3XUzTpC7PQRwatQ7s1q2UzppmR0Qzv/m99127XC3djbtP Kww5Xdxt+Ev2LXDZCJc7amc5pFIAgqJbWQ2uGsj4x9FCYotdKe4= =v5jN -----END PGP SIGNATURE----- --=-=-=--