From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g33J9-0006SN-6R for guix-patches@gnu.org; Thu, 20 Sep 2018 14:04:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g33J4-0001Za-Rt for guix-patches@gnu.org; Thu, 20 Sep 2018 14:04:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:43034) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g33J4-0001ZO-Na for guix-patches@gnu.org; Thu, 20 Sep 2018 14:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g33J4-0004fG-FP for guix-patches@gnu.org; Thu, 20 Sep 2018 14:04:02 -0400 Subject: [bug#32530] [PATCH] gnu: octave: Fix CA certificate use. Resent-Message-ID: From: Kei Kebreau References: <20180826004231.19350-1-kkebreau@posteo.net> <87o9czqhpo.fsf@fastmail.com> <87r2huzk8c.fsf@posteo.net> <87va74krsy.fsf@posteo.net> <875zz4oxil.fsf@fastmail.com> <87k1nhfenz.fsf@gnu.org> <87musdntad.fsf@fastmail.com> <871s9pfdgm.fsf@gnu.org> Date: Thu, 20 Sep 2018 14:03:20 -0400 In-Reply-To: <871s9pfdgm.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 19 Sep 2018 22:18:33 +0200") Message-ID: <87a7oct5av.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 32530@debbugs.gnu.org ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Marius Bakke skribis: > >> ludo@gnu.org (Ludovic Court=C3=A8s) writes: > > [...] > >>>> Adding this native-search-path to the "octave" package should be >>>> sufficient. >>> >>> I think we should avoid doing this though, because conceptually >>> CURLOPT_CAPATH =E2=80=9Cbelongs=E2=80=9D to cURL, not to Octave. >> >> Conceptually maybe, but to my knowledge libcurl itself does not support >> run-time search paths (due to thread safety concerns IIRC). >> >> This search path does seem to be Octave specific. From the ChangeLog: >> >> 2018-04-18 John W. Eaton >> >> allow users to set path to CA certificates for cURL >> >> * url-transfer.cc (curl_transfer::curl_transfer): Check for >> CURLOPT_CAINFO and CURLOPT_CAPATH environment variables. If set= , use >> them to set the corresponding options for the cURL library. >> >> Files: liboctave/util/url-transfer.cc > > Oh, I stand corrected! Then the patch LGTM, maybe with a comment saying > that those variables are actually Octave-specific. :-) > > Thank you! > > Ludo=E2=80=99. Is it really Octave-specific? It's defined in the libcurl API [0], so other software could make use of the variable. [0]: https://curl.haxx.se/libcurl/c/CURLOPT_CAPATH.html