all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Kei Kebreau <kkebreau@posteo.net>
Cc: 32802@debbugs.gnu.org
Subject: [bug#32802] [PATCH] gnu: gnucash: Update to 3.2.
Date: Mon, 24 Sep 2018 14:26:28 +0200	[thread overview]
Message-ID: <87a7o7w07f.fsf@gnu.org> (raw)
In-Reply-To: <20180922052514.25030-1-kkebreau@posteo.net> (Kei Kebreau's message of "Sat, 22 Sep 2018 01:25:14 -0400")

Hello,

Kei Kebreau <kkebreau@posteo.net> skribis:

> * gnu/packages/patches/gnucash-disable-failing-tests.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Register it.
> * gnu/packages/gnucash.scm (gnucash): Update to 3.2.
> [source]: Add patch.
> [arguments]: Add 'glib-or-gtk-compile-schemas' and 'glib-or-gtk-wrap' phases..

[...]

> --- /dev/null
> +++ b/gnu/packages/patches/gnucash-disable-failing-tests.patch
> @@ -0,0 +1,39 @@
> +diff -ur gnucash-3.2.old/libgnucash/backend/xml/test/CMakeLists.txt gnucash-3.2/libgnucash/backend/xml/test/CMakeLists.txt
> +--- gnucash-3.2.old/libgnucash/backend/xml/test/CMakeLists.txt	2018-09-16 22:07:42.445865806 -0400
> ++++ gnucash-3.2/libgnucash/backend/xml/test/CMakeLists.txt	2018-09-16 22:08:29.246608711 -0400

Please add couple of lines at the top explaining what the patch does and
roughly what the problem is with these tests.

> +-gnc_add_test(test-gnc-timezone "${test_gnc_timezone_SOURCES}"
> +-  gtest_engine_INCLUDES gtest_old_engine_LIBS)

Could it be that you need ‘tzdata-for-tests’ as an input, with TZDIR set
accordingly?

Otherwise LGTM, thanks!

Ludo’.

  reply	other threads:[~2018-09-24 12:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-22  5:25 [bug#32802] [PATCH] gnu: gnucash: Update to 3.2 Kei Kebreau
2018-09-24 12:26 ` Ludovic Courtès [this message]
2018-10-05 17:43   ` Kei Kebreau
2018-10-06 16:19     ` bug#32802: " Kei Kebreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7o7w07f.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=32802@debbugs.gnu.org \
    --cc=kkebreau@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.