From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: bug#34207: grantlee fails to build
Date: Sat, 26 Jan 2019 11:47:23 +0100
Message-ID: <87a7jnvgp0.fsf@elephly.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:36344)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gnLjs-0003C4-3R
	for bug-guix@gnu.org; Sat, 26 Jan 2019 06:03:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gnLjr-0001bB-7r
	for bug-guix@gnu.org; Sat, 26 Jan 2019 06:03:04 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:46571)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gnLjr-0001ZV-4q
	for bug-guix@gnu.org; Sat, 26 Jan 2019 06:03:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gnLjp-0000it-Qo
	for bug-guix@gnu.org; Sat, 26 Jan 2019 06:03:01 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.34207.B.15485005782762@debbugs.gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:36278)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1gnLjc-00036N-TW
	for bug-guix@gnu.org; Sat, 26 Jan 2019 06:02:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1gnLjc-0001SA-6F
	for bug-guix@gnu.org; Sat, 26 Jan 2019 06:02:48 -0500
Received: from sender-of-o51.zoho.com ([135.84.80.216]:21108)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <rekado@elephly.net>) id 1gnLjb-0001Qg-BH
	for bug-guix@gnu.org; Sat, 26 Jan 2019 06:02:48 -0500
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: 34207@debbugs.gnu.org

Grantlee has two test failures:

--8<---------------cut here---------------start------------->8---
FAIL!  : TestFilters::testDateBasedFilters(date01) Compared values are not =
the same
   Actual   (result): ""
   Expected (output): "01"
   Loc: [/tmp/guix-build-grantlee-5.1.0.drv-0/grantlee-5.1.0/templates/test=
s/testfilters.cpp(117)]
FAIL!  : TestFilters::testDateBasedFilters(date02) Compared values are not =
the same
   Actual   (result): ""
   Expected (output): "Jan. 1, 2008"
   Loc: [/tmp/guix-build-grantlee-5.1.0.drv-0/grantlee-5.1.0/templates/test=
s/testfilters.cpp(117)]
--8<---------------cut here---------------end--------------->8---

The tests in templates/tests/testfilters.cpp look like this:

 --8<---------------cut here---------------start------------->8---
  Dict dict;
 =E2=80=A6
  QDateTime d(QDate(2008, 1, 1));

  dict.clear();
  dict.insert(QStringLiteral("d"), d);

  QTest::newRow("date01") << "{{ d|date:\"MM\" }}" << dict
                          << QStringLiteral("01") << NoError;
  QTest::newRow("date02") << QStringLiteral("{{ d|date }}") << dict
                          << d.toString(QStringLiteral("MMM. d, yyyy"))
                          << NoError;
--8<---------------cut here---------------end--------------->8---

The following test for =E2=80=9Cdate03=E2=80=9D passes:

--8<---------------cut here---------------start------------->8---
  dict.insert(QStringLiteral("d"), QStringLiteral("fail_string"));
  QTest::newRow("date03") << "{{ d|date:\"MM\" }}" << dict << QString()
                          << NoError;
--8<---------------cut here---------------end--------------->8---

IIUC this means: some non-date is injected and the template resulted in
the empty string.

--
Ricardo