From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:50756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwEJ1-0008Hp-5P for guix-patches@gnu.org; Tue, 19 Feb 2019 17:56:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwEJ0-0006vb-FB for guix-patches@gnu.org; Tue, 19 Feb 2019 17:56:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:56116) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gwEJ0-0006vV-7l for guix-patches@gnu.org; Tue, 19 Feb 2019 17:56:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gwEJ0-0003bR-5a for guix-patches@gnu.org; Tue, 19 Feb 2019 17:56:02 -0500 Subject: [bug#34514] [PATCH 01/34] gnu: Add ruby-hamster. Resent-Message-ID: References: <87sgwm44a9.fsf@cbaines.net> <20190217192314.5666-1-mail@cbaines.net> <877edwwwi2.fsf@elephly.net> From: Christopher Baines In-reply-to: <877edwwwi2.fsf@elephly.net> Date: Tue, 19 Feb 2019 22:55:34 +0000 Message-ID: <87a7irgzh5.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: 34514@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ricardo Wurmus writes: > Christopher Baines writes: > >> * gnu/packages/ruby.scm (ruby-hamster): New variable. > [=E2=80=A6] >> + (add-after 'unpack 'remove-unnecessary-dependencies >> + (lambda _ >> + ;; pry is a debugging tool, and is unnecessary when running = the >> + ;; tests >> + (substitute* "spec/lib/hamster/vector/insert_spec.rb" >> + (("require 'pry'") "")) >> + (substitute* "spec/spec_helper.rb" >> + (("require \"pry\"") "") > > We have a ruby-pry package. Wouldn=E2=80=99t it be nicer to add it inste= ad of > patching the sources? It would make the package definition simpler, but it would lead to redundant rebuilds of this package, and all of it's dependants if the ruby-pry package changed. The ideal situation would be for things like this to be optional, but I think where this isn't the case, it's worth putting some effort in to the package definition to avoid unnecessary dependencies. >> + ;; CodeClimate is an online service, and is unnecessary for >> + ;; running the tests >> + (("require \"codeclimate-test-reporter\"") "") >> + (("CodeClimate.*\n") "")) > > Okay. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlxsiWZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XcH9g/9Ep7t4JPMAYu3ETozUYHF7VWU1hsXh8QqpZNZ2PbnhVHw6ZrVNGG8ch3Q 6pj3UGxSokOCGsVMvAwEEISGHWMVYpUgCHiwh8r4zU3o3Qp6T2robNhD2fr5Mlmm akl+pDfpWILHtHQI/sVVKyw83gxv4QrXYHntrJPy/QLQ/il5yUyaZ3M+FP/3wUDA etyQ0LCs1VmW4ZPOGsb7s7xF2Y26083HtM51BGchO6VTG9jcTWbe/7Bnrxi7H2BK ZcxtlPoJ9H8o9pmEs0+Oye2BWHmzKWq+iF8D1fWsQaUdrTkTmFs8bSPLNhpDjijh 1wxuxQzj6hRjkviNiH0Doitiz6sQ03WZs6omXDLbcsgnqS1Lv+Plqo2ydiWkHd8u 7Xz8n3oWvumBNGj1d3/uEqPLyBOsimJ7Gjx10+SIevrlF/tGV8uaj3Rl3x3q+WdU 6NxXd6BexfTcgmCc+9dDValvdjmQqTU6DvuBX/CLzAyZfMPRXXU/BsSiU4aXrbnY gDsbMTj+dsUOjnrWxjdE3hjnwycX3A+edg8dKyPEVanf/QARzKSJzl/qGxWQsLB1 NkHGH8lSxm5FddLLIUegVLikyPW0+zhGc5k3mCPrtrLlhIrU//KSTutpZDs/QzvB ZpdZbMaBv6joNPGsQOy93x29r4zOXk4ofwJpC4WN7e/q7YDm7aU= =55bZ -----END PGP SIGNATURE----- --=-=-=--