From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:40119)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hXWar-00071L-By
	for guix-patches@gnu.org; Sun, 02 Jun 2019 15:56:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hXWXO-00029S-Bz
	for guix-patches@gnu.org; Sun, 02 Jun 2019 15:53:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:55609)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hXWXO-00029L-8l
	for guix-patches@gnu.org; Sun, 02 Jun 2019 15:53:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hXWXO-0003IQ-4F
	for guix-patches@gnu.org; Sun, 02 Jun 2019 15:53:02 -0400
Subject: [bug#35935] [PATCH] guix: import: simplify recursive import
Resent-Message-ID: <handler.35935.B35935.155950517912662@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190527200731.59990-1-rob@vllmrt.net>
Date: Sun, 02 Jun 2019 21:52:45 +0200
In-Reply-To: <20190527200731.59990-1-rob@vllmrt.net> (Robert Vollmert's
	message of "Mon, 27 May 2019 22:07:31 +0200")
Message-ID: <87a7ez933m.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Robert Vollmert <rob@vllmrt.net>
Cc: 35935@debbugs.gnu.org

Hello Robert,

Robert Vollmert <rob@vllmrt.net> skribis:

> This simplifies the logic of recursive-import, intending no
> major functional changes. The package import function is no
> longer called twice per package. Failed imports now make it
> to the package stream as '() instead of #f.
>
> * guix/import/utils.scm: Simplify recursive-import.
                         ^
Minor issue: please make sure to mention the modified entities here
(procedures, variables, etc.); see
<https://www.gnu.org/prep/standards/html_node/Change-Logs.html>.

I think Oleg worked on this part before; Oleg, could you comment
and/or apply?

=E2=80=98tests/import-utils.scm=E2=80=99 doesn=E2=80=99t seem to be testing=
 this procedure,
perhaps that=E2=80=99s something we should fix eventually.

Thanks,
Ludo=E2=80=99.