From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:34195) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiKcZ-0004co-Rz for guix-patches@gnu.org; Tue, 02 Jul 2019 11:23:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiKcY-000247-G8 for guix-patches@gnu.org; Tue, 02 Jul 2019 11:23:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38858) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hiKcY-00023n-Aj for guix-patches@gnu.org; Tue, 02 Jul 2019 11:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hiKcY-00083Z-5u for guix-patches@gnu.org; Tue, 02 Jul 2019 11:23:02 -0400 Subject: [bug#35890] [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument. Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <8736l3qtjx.fsf@posteo.net> <87zhnbpee0.fsf@posteo.net> <871s0ld3hn.fsf@devup.no> Date: Tue, 02 Jul 2019 17:22:18 +0200 In-Reply-To: <871s0ld3hn.fsf@devup.no> (Marius Bakke's message of "Sun, 26 May 2019 10:28:04 +0200") Message-ID: <87a7dw7979.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Brett Gilio Cc: 35890@debbugs.gnu.org Hello Brett, Marius Bakke skribis: > Brett Gilio writes: > >> From 74c956284d5ff7b20e12ed4315404697320dc809 Mon Sep 17 00:00:00 2001 >> From: Brett Gilio >> Date: Fri, 24 May 2019 19:11:00 -0500 >> Subject: [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument. >> >> * gnu/packages/python-xyz.scm (python-hdf4): Update to . >> --- >> gnu/packages/python-xyz.scm | 15 --------------- >> 1 file changed, 15 deletions(-) >> >> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm >> index 54cc0c2b27..43287d212e 100644 >> --- a/gnu/packages/python-xyz.scm >> +++ b/gnu/packages/python-xyz.scm >> @@ -385,21 +385,6 @@ and verifies that it matches the intended target ho= stname.") >> `(("hdf4" ,hdf4) >> ("libjpeg" ,libjpeg) >> ("zlib" ,zlib))) >> - (arguments >> - `(#:phases >> - (modify-phases %standard-phases >> - (replace 'check >> - (lambda _ >> - ;; The 'runexamples' script sets PYTHONPATH to CWD, then go= es >> - ;; on to import numpy. Somehow this works on their CI syste= m. >> - ;; Let's just manage PYTHONPATH here instead. >> - (substitute* "runexamples.sh" >> - (("export PYTHONPATH=3D.*") "")) >> - (setenv "PYTHONPATH" >> - (string-append (getcwd) ":" >> - (getenv "PYTHONPATH"))) >> - (invoke "./runexamples.sh") >> - (invoke "nosetests" "-v")))))) >> (home-page "https://github.com/fhs/python-hdf4") >> (synopsis "Python interface to the NCSA HDF4 library") >> (description > > While this makes the build succeed, the 'check' phase is now moot. It > appears to simply build the library for a second time, and then prints > 'Ran 0 tests in N seconds...'. > > Can you look into what happened to the tests between version 0.9.0 and > 0.9.2? Any update on this? Ludo=E2=80=99.