From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:39076)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hkXjD-0007Hj-O9
 for guix-patches@gnu.org; Mon, 08 Jul 2019 13:47:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hkXjC-0002yQ-P6
 for guix-patches@gnu.org; Mon, 08 Jul 2019 13:47:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:50651)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hkXjC-0002y4-Kg
 for guix-patches@gnu.org; Mon, 08 Jul 2019 13:47:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hkXjC-0005Gm-G9
 for guix-patches@gnu.org; Mon, 08 Jul 2019 13:47:02 -0400
Subject: [bug#36477] [PATCH 09/31] gnu: http-parser: Fix cross-compilation.
Resent-Message-ID: <handler.36477.B36477.156260799220216@debbugs.gnu.org>
From: Marius Bakke <mbakke@fastmail.com>
In-Reply-To: <20190708095913.3460-10-m.othacehe@gmail.com>
References: <20190708095913.3460-1-m.othacehe@gmail.com>
 <20190708095913.3460-10-m.othacehe@gmail.com>
Date: Mon, 08 Jul 2019 19:46:22 +0200
Message-ID: <87a7dopggh.fsf@devup.no>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>, 36477@debbugs.gnu.org

--=-=-=
Content-Type: text/plain

Mathieu Othacehe <m.othacehe@gmail.com> writes:

> * gnu/packages/web.scm (http-parser)[arguments]: Set CC and AR variables in
> Makefile in order to fix cross-compilation.

[...]

> @@ -5171,10 +5172,18 @@ into your tests.  It automatically starts up a HTTP server in a separate thread
>         #:make-flags
>         (list (string-append "PREFIX="
>                              (assoc-ref %outputs "out"))
> -             "CC=gcc" "library")
> +             "library")
>         #:phases
>         (modify-phases %standard-phases
> -         (delete 'configure))))
> +         (replace 'configure
> +           (lambda* (#:key target #:allow-other-keys)
> +             (when ,(%current-target-system)
> +               (substitute* (find-files "." "Makefile")
> +                 (("CC\\?=.*$")
> +                  (string-append "CC=" target "-gcc\n"))
> +                 (("AR\\?=.*$")
> +                  (string-append "AR=" target "-ar\n"))))
> +             #t)))))

I would prefer to splice in this phase instead of adding a noop phase to
the native build.  LGTM otherwise.

(so I guess CC=gcc was not needed for native builds?)

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl0jgW4ACgkQoqBt8qM6
VPrwcAf7BfEjfKquUef6pzfc1kl9yNM2zBtUDFThNwkRqGIbD/JAF8Iey+lNfBUA
PQtVxE2/jOQtklHX7tqDZserBX5HP7qyNKgjcZL72X0VlJQei5plHFLTUMVVnbPb
rUNRrmx5T/4B3Yhn+hrMj8P+zVEBFMq1caPhVqD/EBoQFFw4lgjQ85Q54ARndMTT
IAJArU6Xyfv32luQmpe4DCJZ09+JStdYZHCqgugFPWS5eLsVuZO3dtWyJHecGxq2
HI7b4AyX9Pc9XQCzUIo2w7ClXi8dGLDPmGN4wtg9QhxLyYR1aIgZSPk1hQmnriB3
aqUB4HazAekIWkTy8C6F+PLhSlo+Kw==
=hMcQ
-----END PGP SIGNATURE-----
--=-=-=--