* [bug#36537] [PATCH] discovery: Handle edge case in scheme-files when looking at symlinks. @ 2019-07-07 11:21 Christopher Baines 2019-07-08 10:59 ` Ludovic Courtès 0 siblings, 1 reply; 3+ messages in thread From: Christopher Baines @ 2019-07-07 11:21 UTC (permalink / raw) To: 36537 Previously, this code would cause crashes in Guix (running guix package -s for example) which could be experienced when Emacs creates temporary files in the gnu/packages/patches directory when a patch file has been edited, but not saved. * guix/discovery.scm (scheme-files): Add else clause to cond used when handling symlinks. --- guix/discovery.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/guix/discovery.scm b/guix/discovery.scm index 5bb494941b..86f20ec344 100644 --- a/guix/discovery.scm +++ b/guix/discovery.scm @@ -78,7 +78,9 @@ DIRECTORY is not accessible." ((= stat:type 'directory) (append (scheme-files absolute) result)) - (_ result))))) + (_ result))) + (else + result))) (else result)))))) '() -- 2.22.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bug#36537] [PATCH] discovery: Handle edge case in scheme-files when looking at symlinks. 2019-07-07 11:21 [bug#36537] [PATCH] discovery: Handle edge case in scheme-files when looking at symlinks Christopher Baines @ 2019-07-08 10:59 ` Ludovic Courtès 2019-07-08 16:56 ` bug#36537: " Christopher Baines 0 siblings, 1 reply; 3+ messages in thread From: Ludovic Courtès @ 2019-07-08 10:59 UTC (permalink / raw) To: Christopher Baines; +Cc: 36537 Hi Chris, Christopher Baines <mail@cbaines.net> skribis: > Previously, this code would cause crashes in Guix (running guix package -s for > example) which could be experienced when Emacs creates temporary files in the > gnu/packages/patches directory when a patch file has been edited, but not > saved. > > * guix/discovery.scm (scheme-files): Add else clause to cond used when > handling symlinks. Good catch, LGTM! Thank you, Ludo’. ^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#36537: [PATCH] discovery: Handle edge case in scheme-files when looking at symlinks. 2019-07-08 10:59 ` Ludovic Courtès @ 2019-07-08 16:56 ` Christopher Baines 0 siblings, 0 replies; 3+ messages in thread From: Christopher Baines @ 2019-07-08 16:56 UTC (permalink / raw) To: Ludovic Courtès; +Cc: 36537-done [-- Attachment #1: Type: text/plain, Size: 528 bytes --] Ludovic Courtès <ludo@gnu.org> writes: > Hi Chris, > > Christopher Baines <mail@cbaines.net> skribis: > >> Previously, this code would cause crashes in Guix (running guix package -s for >> example) which could be experienced when Emacs creates temporary files in the >> gnu/packages/patches directory when a patch file has been edited, but not >> saved. >> >> * guix/discovery.scm (scheme-files): Add else clause to cond used when >> handling symlinks. > > Good catch, LGTM! Great, I've pushed this now :) [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 962 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-08 16:57 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-07-07 11:21 [bug#36537] [PATCH] discovery: Handle edge case in scheme-files when looking at symlinks Christopher Baines 2019-07-08 10:59 ` Ludovic Courtès 2019-07-08 16:56 ` bug#36537: " Christopher Baines
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/guix.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.