all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Timothy Sample <samplet@ngyro.com>
To: Robert Vollmert <rob@vllmrt.net>
Cc: 36084-done@debbugs.gnu.org
Subject: bug#36084: ghc-tasty/ghc-clock circular dependency breaking is broken
Date: Tue, 16 Jul 2019 15:11:00 -0400	[thread overview]
Message-ID: <87a7dddccb.fsf@ngyro.com> (raw)
In-Reply-To: <9C66C61B-16D7-4A01-A35D-85984FF819C4@vllmrt.net> (Robert Vollmert's message of "Tue, 16 Jul 2019 18:17:26 +0200")

Hi,

Robert Vollmert <rob@vllmrt.net> writes:

>> On 16. Jul 2019, at 17:08, Timothy Sample <samplet@ngyro.com> wrote:
>> 
>> Hi Robert,
>> 
>> After looking at this and your patch at <https://bugs.gnu.org/36249>,
>> I’m wondering if it works as long as we make sure the versions match.
>> Can we just inherit the current “ghc-clock”, disable its tests, and call
>> it “ghc-clock-bootstrap”?  Is the Cabal consistency checking too clever
>> for that?
>> 
>> If that doesn’t work, can you explain why the method you proposed above
>> doesn‘t work?  It seems a little simpler than your patch.  In fact,
>> maybe we could live with the main “ghc-tasty” package being built
>> without “ghc-clock” (via the flag you mentioned).
>
> I tried the direct approach again, and this time it worked. Posted an
> updated patch.
>
> I believe this should be fine, since GHCs builds should be deterministic.

It looks like this is a common idiom for us, so I’m pretty confident,
too.  Fixed in 71e5d425c9b9e108ebdd06d13de45b56dddd9ef5.  Thanks!


-- Tim

  reply	other threads:[~2019-07-16 19:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-04  0:26 bug#36084: ghc-tasty/ghc-clock circular dependency breaking is broken Robert Vollmert
2019-07-16 15:08 ` Timothy Sample
2019-07-16 16:17   ` Robert Vollmert
2019-07-16 19:11     ` Timothy Sample [this message]
2019-07-17 14:13 ` bug#36084: not really fixed? Robert Vollmert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7dddccb.fsf@ngyro.com \
    --to=samplet@ngyro.com \
    --cc=36084-done@debbugs.gnu.org \
    --cc=rob@vllmrt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.