From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marius Bakke <mbakke@fastmail.com>
Subject: Re: Error cross-compiling Mesa: failing test
Date: Sat, 07 Sep 2019 16:58:25 +0200
Message-ID: <87a7bggnla.fsf@devup.no>
References: <87ftl9z1e8.fsf@ambrevar.xyz>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:34720)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <mbakke@fastmail.com>) id 1i6cAY-0002tU-0v
 for guix-devel@gnu.org; Sat, 07 Sep 2019 10:58:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <mbakke@fastmail.com>) id 1i6cAW-00005Y-QT
 for guix-devel@gnu.org; Sat, 07 Sep 2019 10:58:29 -0400
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:46191)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <mbakke@fastmail.com>) id 1i6cAW-00005F-Jm
 for guix-devel@gnu.org; Sat, 07 Sep 2019 10:58:28 -0400
In-Reply-To: <87ftl9z1e8.fsf@ambrevar.xyz>
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Pierre Neidhardt <mail@ambrevar.xyz>, guix-devel@gnu.org

--=-=-=
Content-Type: text/plain

Pierre Neidhardt <mail@ambrevar.xyz> writes:

> Hi!
>
> Our current `mesa' package has this bit:
>
> --8<---------------cut here---------------start------------->8---
>          ,@(if (string-prefix? "i686" (%current-system))
>                ;; Disable new test from Mesa 19 that fails on i686.  Upstream
>                ;; report: <https://bugs.freedesktop.org/show_bug.cgi?id=110612>.
>                `((add-after 'unpack 'disable-failing-test
>                    (lambda _
>                      (substitute* "src/gallium/tests/unit/meson.build"
>                        (("'u_format_test',") ""))
>                      #t)))
>                '())
> --8<---------------cut here---------------end--------------->8---
>
> When I attempt to cross-compile the package from x86-64 to x686, the
> faulty test is not disabled and the check phase fails.
>
> If I turn (%current-system) to (%current-target-system) it works.
> Should we update the package to use (%current-target-system) then?

I did not expect anyone to run tests when cross-compiling :-)

I think gnu-build-system disables tests in that case, but perhaps it
should not?

In any case you can change (%current-system) to:

  (or (%current-target-system) (%current-system))

...and it should work.  Feel free to push this change to 'master' :-)

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl1zxZEACgkQoqBt8qM6
VPqRcggAiMiN1LLTnPAo6q5Ja6IyDPHPYnuVy0i65zhjyFugohRYoEW9Jf9wDJ/o
w4WntPEI8rt6z8+2lmPwoW4eGmzigtEBSPDN02uBmSR1kq3MCCTqmOg3eObyOKoJ
sTDLAtMtDwpFRxcND0OrfQ81O1957InCWBNnjmmucVAwlrOBdfyc/oSLKL2Nqmqw
kDu0SPPN0udLi4su88NB2vrE7LgI6Sy2MRhPLRqiIVYO0VoGG1+x+5j6No39cXu7
sVQ7rhBBB/vy0Nk0flIwUN8czpDyvp2gM6iIMy1yBhq7EApLQlFVpCdkoW26Aosl
eAeQjQJGdo+CFCdWsqb3ff61D5/PcA==
=BWbq
-----END PGP SIGNATURE-----
--=-=-=--