Re: Error cross-compiling Mesa: failing test

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1310 bytes --]

Pierre Neidhardt <mail@ambrevar.xyz> writes:

> Hi!
>
> Our current `mesa' package has this bit:
>
> --8<---------------cut here---------------start------------->8---
>          ,@(if (string-prefix? "i686" (%current-system))
>                ;; Disable new test from Mesa 19 that fails on i686.  Upstream
>                ;; report: <https://bugs.freedesktop.org/show_bug.cgi?id=110612>.
>                `((add-after 'unpack 'disable-failing-test
>                    (lambda _
>                      (substitute* "src/gallium/tests/unit/meson.build"
>                        (("'u_format_test',") ""))
>                      #t)))
>                '())
> --8<---------------cut here---------------end--------------->8---
>
> When I attempt to cross-compile the package from x86-64 to x686, the
> faulty test is not disabled and the check phase fails.
>
> If I turn (%current-system) to (%current-target-system) it works.
> Should we update the package to use (%current-target-system) then?

I did not expect anyone to run tests when cross-compiling :-)

I think gnu-build-system disables tests in that case, but perhaps it
should not?

In any case you can change (%current-system) to:

  (or (%current-target-system) (%current-system))

...and it should work.  Feel free to push this change to 'master' :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]