From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Baines Subject: Re: [PATCH] Support publishing build events Date: Mon, 21 Oct 2019 22:47:25 +0100 Message-ID: <87a79trcsy.fsf@cbaines.net> References: <87mudvrhim.fsf@cbaines.net> <20191020074952.17732-1-christopher.baines@digital.cabinet-office.gov.uk> <87a79u78d7.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:47737) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMfWW-0000hg-7Z for guix-devel@gnu.org; Mon, 21 Oct 2019 17:47:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMfWU-0004fi-Ds for guix-devel@gnu.org; Mon, 21 Oct 2019 17:47:32 -0400 Received: from mira.cbaines.net ([2a01:7e00::f03c:91ff:fe69:8da9]:45044) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iMfWU-0004fY-4c for guix-devel@gnu.org; Mon, 21 Oct 2019 17:47:30 -0400 In-reply-to: <87a79u78d7.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Mathieu Othacehe writes: > Hello Christopher, > >> +(define* (main #:optional (args (command-line))) >> + >> + ;; Always have stdout/stderr line-buffered. >> + (setvbuf (current-output-port) 'line) >> + (setvbuf (current-error-port) 'line) > > I must admit I've not been following very closely your work on Guix Data > Service. However, I must admit that being able to have an overview of > the status of all packages of a given branch is something that would > really be nice. > > On this patch more specifically, is this really necessary to create a > separate process? Could the task of pushing events be done in the main > cuirass binary, periodically in a separate thread/fiber? No, I think it would be possible to do this as part of the cuirass process that takes care of builds, and that even might have some advantages as you'd potentially able to avoid some delays associated with polling. However, I don't really understand fibers in Guile yet, so I didn't have a good idea of how to add new functionality in to the mix of the existing process. So I went for a simpler implementation. I'm quite happy to work on changing it, but it would be good to have some input from someone that has a better idea of the Cuirass internals. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl2uJ21fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xfw9A//fR3Bsnh7L2y6/a8CHU7SV/3WUBxz8GZhGqebQHjAM+CZLSj7rgKPKcrB oa2Da1nt/7O9xuKbHNNWylNZCbD0Td4uk5gsHOksfcZbtgGGcj7vLedWbyvdONnV EgyVpbw02BTjURunysASJsATOJSHCvXGeaH/ulQUFpVnp3KNGlsAdArtyHtkRSlX pG8apaqLPdZPE2psTQqX8J7Sx6AypwSidyLP5oExjPqmVZW04nsp9kVhhe9tMvvd TiGUwIW1wBbtZ9mj+Fl6v5RhlB3uaCpPVhvE78d/Qj7jzIDqiqvuK6A9X77gsxXv tW0zamCkRBw8PuYPZLQIzGxnbozN9Q42XO17yxKpvT0So6FDuhErMx8W8Ogst+kH IREtAdrE7Gpvvc9EUe8VfB2kLJGWpdRbSzjZiJYkQKJ4iaiAvmj0UY+93Hpo76v2 LX6q3rw3iZSGukYGAflXmRfiBt70vkDfpsS63V/lKncRFiDqI6jzF7eQ3M6f4CyE J7vT7QfDRBtLYHTRKEdeqlz78QVwJIHpukWpGkImXcqn5X45YKwQZVB5ZAPUNDrm jnJqluuNcCBkWUqm/dIwWYpz6KgHv3tPXEjcszMvyMqkeRivpo2BMbMcBXeet8m3 Tzhob0Woe6YKgpT/YkEAWOHt7jR8RjP9ds/OJh5NMfqz68z4SZs= =NM/f -----END PGP SIGNATURE----- --=-=-=--