From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:48691)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iRkZv-00039z-K9
 for guix-patches@gnu.org; Mon, 04 Nov 2019 17:12:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iRkZu-0004CI-MR
 for guix-patches@gnu.org; Mon, 04 Nov 2019 17:12:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:57070)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iRkZu-0004Ba-8J
 for guix-patches@gnu.org; Mon, 04 Nov 2019 17:12:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iRkZu-0006cK-2E
 for guix-patches@gnu.org; Mon, 04 Nov 2019 17:12:02 -0500
Subject: [bug#37870] [PATCH v2] gnu: make-nsis: Fix cross-compilation.
Resent-Message-ID: <handler.37870.B37870.157290549125379@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <lI5DwU353RX8yByF2S7GQy2TR3ndGe6sca1dTT0Wj0b3qR6vQK1ncG7juxeQjNHaIEbycrt_6lC4kbG2urSWIADaqzPkHbh9KfCWHCCK0x0=@carldong.me>
 <fKmAv1iXglLD_OTXBc8baRszgK0qQ0IcuOCTswisQymd2_89W5R7rNTuB8QB0FHjBmC-ZByc104-Sbua4aQsfo8jqYNwYrkkSsO-C_vzh6Q=@carldong.me>
 <20191029192214.GE20762@E5400>
Date: Mon, 04 Nov 2019 23:11:22 +0100
In-Reply-To: <20191029192214.GE20762@E5400> (Efraim Flashner's message of
 "Tue, 29 Oct 2019 21:22:14 +0200")
Message-ID: <87a79b5m2d.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: "37870@debbugs.gnu.org" <37870@debbugs.gnu.org>, Carl Dong <contact@carldong.me>

Hi,

Efraim Flashner <efraim@flashner.co.il> skribis:

> On Tue, Oct 29, 2019 at 04:02:01PM +0000, Carl Dong wrote:
>> Updated the patch to make it look a little better :-)
>> Will push to master tomorrow if no objections.

[...]

>> +                        (setenv "CROSS_CPLUS_INCLUDE_PATH"
>> +                                (string-join
>> +                                 `(,@(map (cut string-append (assoc-ref=
 %build-inputs "xgcc") <>)
>> +                                          `("/include/c++"
>> +                                            ,(string-append "/include/c=
++/" ,triplet)
>> +                                            "/include/c++/backward"
>> +                                            "/lib/gcc/x86_64-w64-mingw3=
2/7.4.0/include"
>> +                                            "/lib/gcc/x86_64-w64-mingw3=
2/7.4.0/include-fixed"))
> I'm going to suggest not hardcoding 7.4.0 here

Agreed.  I guess you could extract the version number by calling
=E2=80=98package-version=E2=80=99 on the dependency or something like that =
(on the
=E2=80=9Chost side=E2=80=9D).

Thanks,
Ludo=E2=80=99.