From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@gnu.org>
Subject: Re: Wheel group as polkit admins
Date: Tue, 26 Nov 2019 11:17:21 +0100
Message-ID: <87a78j9c26.fsf@gnu.org>
References: <17ea661e09a034c36151b72ca1ab508a3fc52d1c.camel@student.tugraz.at>
 <87mucuo3hh.fsf@gnu.org>
 <329f03fbb1df8c78deaef37c06c5041b3504c15e.camel@student.tugraz.at>
 <87imna4im0.fsf@gnu.org>
 <3b18f59a286f79cbf648f35143bdec9ffd8717fe.camel@student.tugraz.at>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:58075)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <ludo@gnu.org>) id 1iZXuP-0007uv-7L
 for guix-devel@gnu.org; Tue, 26 Nov 2019 05:17:26 -0500
In-Reply-To: <3b18f59a286f79cbf648f35143bdec9ffd8717fe.camel@student.tugraz.at>
 (Leo Prikler's message of "Sat, 23 Nov 2019 20:08:39 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Leo Prikler <leo.prikler@student.tugraz.at>
Cc: guix-devel@gnu.org

Hi Leo,

Leo Prikler <leo.prikler@student.tugraz.at> skribis:

> From 42eedd4d9d64a8432f787e68d64476c59200c1b6 Mon Sep 17 00:00:00 2001
> From: Leo Prikler <leo.prikler@student.tugraz.at>
> Date: Sat, 23 Nov 2019 19:51:15 +0100
> Subject: [PATCH 1/2] services: Add polkit-wheel-service.
>
> * gnu/services/desktop.scm: (polkit-wheel): New variable.
> (polkit-wheel-service): New service.
> ---
>  gnu/services/desktop.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
> index 0152e86e8a..e58a08e068 100644
> --- a/gnu/services/desktop.scm
> +++ b/gnu/services/desktop.scm
> @@ -135,6 +135,8 @@
>              inputattach-configuration?
>              inputattach-service-type
>=20=20
> +            polkit-wheel-service
> +
>              %desktop-services))
>=20=20
>  ;;; Commentary:
> @@ -1064,6 +1066,25 @@ as expected.")))
>     (description "Return a service that runs inputattach on a device and
>  dispatches events from it.")))
>=20=20
> +
> +;;;
> +;;; polkit-wheel-service
> +;;;
> +
> +(define polkit-wheel
> +  (file-union
> +   "polkit-wheel"
> +   `(("share/polkit-1/rules.d/wheel.rules"
> +      ,(plain-file
> +        "wheel.rules"
> +        "polkit.addAdminRule(function(action, subject) {
> +    return [\"unix-group:wheel\"];
> +});
> +")))))
> +
> +(define polkit-wheel-service
> +  (simple-service 'polkit-wheel polkit-service-type (list polkit-wheel)))

Could you (1) add a comment saying what this does, like you did in the
second patch, and (2) document it in guix.texi, presumably right below
=E2=80=98polkit-service=E2=80=99?

> From 1585513cc6d96e2f32a56850c9c26551a29d9f0f Mon Sep 17 00:00:00 2001
> From: Leo Prikler <leo.prikler@student.tugraz.at>
> Date: Sat, 23 Nov 2019 19:58:11 +0100
> Subject: [PATCH 2/2] services: Add polkit-wheel-service to %desktop-servi=
ces.
>
> * gnu/services/desktop.scm: (%desktop-services): Add polkit-wheel-service.

OK!

I=E2=80=99ll wait for your updated patch, thank you!

Ludo=E2=80=99.