From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id JKLiHeE5nV/NTAAA0tVLHw (envelope-from ) for ; Sat, 31 Oct 2020 10:18:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id WKRiGeE5nV/oGAAAbx9fmQ (envelope-from ) for ; Sat, 31 Oct 2020 10:18:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0D1C194051B for ; Sat, 31 Oct 2020 10:18:09 +0000 (UTC) Received: from localhost ([::1]:57098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYnxX-0005ZR-Rv for larch@yhetil.org; Sat, 31 Oct 2020 06:18:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYnxS-0005ZJ-6t for guix-patches@gnu.org; Sat, 31 Oct 2020 06:18:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49032) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYnxR-00023I-Sd for guix-patches@gnu.org; Sat, 31 Oct 2020 06:18:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYnxR-0006Y5-Ny for guix-patches@gnu.org; Sat, 31 Oct 2020 06:18:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44321] [PATCH 1/6] guix build: 'package-with-source' no longer takes a 'store' parameter. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 31 Oct 2020 10:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44321 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas Cc: 44321@debbugs.gnu.org Received: via spool by 44321-submit@debbugs.gnu.org id=B44321.160413946825154 (code B ref 44321); Sat, 31 Oct 2020 10:18:01 +0000 Received: (at 44321) by debbugs.gnu.org; 31 Oct 2020 10:17:48 +0000 Received: from localhost ([127.0.0.1]:60578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYnxD-0006Xd-Pf for submit@debbugs.gnu.org; Sat, 31 Oct 2020 06:17:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYnxC-0006XS-Gc for 44321@debbugs.gnu.org; Sat, 31 Oct 2020 06:17:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36182) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYnx7-0001wV-9r; Sat, 31 Oct 2020 06:17:41 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=56726 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kYnx6-0005xU-UO; Sat, 31 Oct 2020 06:17:41 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20201029230831.14456-1-ludo@gnu.org> <20201029231000.14568-1-ludo@gnu.org> <87eelf47ne.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 10 Brumaire an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 31 Oct 2020 11:17:39 +0100 In-Reply-To: <87eelf47ne.fsf@gmail.com> ("Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas"'s message of "Sat, 31 Oct 2020 00:27:01 +0100") Message-ID: <87a6w2wvgc.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: iHLSTpkisRfw Miguel =C3=81ngel Arruga Vivas skribis: > I've had to re-read some parts of the manual and the code of (guix > store) a bit to completely understand this one, so thank you for the > practical lesson too. :-) Heheh. :-) > To be sure that I understood it: the main difference is that now > package-with-source _stages_ (wink) the source download up to the gexp > compilation, isn't it? If that's the case, this LGTM and my quick > tests. Yes, exactly. Now =E2=80=98package-with-source=E2=80=99 inserts an =E2=80= =9Cinert=E2=80=9D record as the source of the package. The file is actually downloaded when that object is =E2=80=9Clowered= =E2=80=9D, which happens when the package itself is lowered to a derivation. Thanks for the review! Ludo=E2=80=99.