From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id IPEtLxrUz18HcgAA0tVLHw (envelope-from ) for ; Tue, 08 Dec 2020 19:29:30 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 2CIWKxrUz186CQAA1q6Kng (envelope-from ) for ; Tue, 08 Dec 2020 19:29:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 51F8E940480 for ; Tue, 8 Dec 2020 19:29:30 +0000 (UTC) Received: from localhost ([::1]:50352 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmifx-0001UJ-AD for larch@yhetil.org; Tue, 08 Dec 2020 14:29:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44540) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmiUs-0000eR-7u for guix-patches@gnu.org; Tue, 08 Dec 2020 14:18:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48266) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kmiUr-0007zr-W3 for guix-patches@gnu.org; Tue, 08 Dec 2020 14:18:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kmiUr-0004WY-S0 for guix-patches@gnu.org; Tue, 08 Dec 2020 14:18:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45104] pull: Add a "with-substitutes" option. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Dec 2020 19:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45104 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Mathieu Othacehe Cc: 45104@debbugs.gnu.org Received: via spool by 45104-submit@debbugs.gnu.org id=B45104.160745507517378 (code B ref 45104); Tue, 08 Dec 2020 19:18:01 +0000 Received: (at 45104) by debbugs.gnu.org; 8 Dec 2020 19:17:55 +0000 Received: from localhost ([127.0.0.1]:59812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmiUk-0004WE-ND for submit@debbugs.gnu.org; Tue, 08 Dec 2020 14:17:54 -0500 Received: from mira.cbaines.net ([212.71.252.8]:35942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmiUi-0004W6-Na for 45104@debbugs.gnu.org; Tue, 08 Dec 2020 14:17:53 -0500 Received: from localhost (188.29.103.89.threembb.co.uk [188.29.103.89]) by mira.cbaines.net (Postfix) with ESMTPSA id BA08D27BC01; Tue, 8 Dec 2020 19:17:51 +0000 (GMT) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 750974a9; Tue, 8 Dec 2020 19:17:49 +0000 (UTC) References: <87eek1vd4g.fsf@gnu.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines In-reply-to: <87eek1vd4g.fsf@gnu.org> Date: Tue, 08 Dec 2020 19:17:47 +0000 Message-ID: <87a6uohztw.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.91 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 51F8E940480 X-Spam-Score: -1.91 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: JiC8lH0V/R6J --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Mathieu Othacehe writes: > When "guix pull" is run before the CI server is done baking substitutes, > the user may need to build some derivations, which can be long on > low-end hardware. > > This patch adds an option to "guix pull" so that it updates to the > latest commit with available substitutes. > > This work is still in progress, but I'd like to gather some impressions > on that before going further. Hey! I think it's definitely a nice idea, although I think there are some things in the naming. My first thought is that the option doesn't really do what it says it will do. The option is named --with-substitutes, but that actually means something like "with successful build on ci.guix.gnu.org". This could cause confusion if you're not fetching substitutes from ci.guix.gnu.org, and it starts building things, or perhaps if you're fetching substitutes from two servers, one of which is ci.guix.gnu.org which doesn't have a substitute, but the other server does, this option would fetch an older revision than what's truly available. Maybe part of what I've said above is incorrect if a users substitute URLs are used, but there also seems to be an assuption that something which provides substitutes provides a Cuirass compatible API, which isn't always the case. One more thought on this is that it's probably important to convey that this doesn't pick a revision where substitutes will be available. I think this is something some users would be eager to assume, and then be confused when it doesn't work. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKkBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl/P0VtfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XcBQQ/42tYVXO2CBpNOELqx4BGTY5C8wDH64KNZ rlhxUAaovMdBFxZ4Fim8UzMZS85wGKBaW8aoyw1wYHlTBJNgr9z6fjOM8F/AWi8Y eyput0DcMZ36hhyfL1vgJ77+lnKxfWARrtEMxDrRP1j3jtQjnc3nAOm+5j4eFY7r aal527/pJKPzAOooslF4/VABgxonoq23V5qwytjYoCergQFGPva5Ktu2LK9EjG5Z n+maaC+SCCn0bUHZ+zkPirOY7FTM4g6rZiKBknnykygl9Nu9r0EEv4xKGz4wVgxt p4HFmgQnD+bHEzWstQnWr6U5pfX8WHUfBWpTg5UFyDsfcBniL8lbE6/rZpXuldxP 1bZqJqzDd56mJ728Ld7xXqv81JlXCFnyou7fW/waVRNwNKTZVlpw/DDvLmiQP0Ig Y7CT1kUnP3gwUtlZgL3ffNqE7oOEbEf/s4ibK7aV9dQ9axexDZjxcX9QHtM9WaDf Aakn/+hbFt6JTt1TUozFQVDeK9vRmDwD2g2aXXcihjUU5byyxLiyqj5MNjgzVsH1 SNNhKZPJL4w54wFjfkghUqeqe0+wYg+0PBWD8IV6+6MFODoUqIWUJHfhL9V/BaK5 T5XHjVAN9BJp36AZFlAeBlvwyXp9k0r+ZSjbbUKCDi8KB4vR23qNDY//XTmCB6lJ EV723X4YjQ== =3ZFW -----END PGP SIGNATURE----- --=-=-=--