From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id pBShOFxgA2CJUQAA0tVLHw (envelope-from ) for ; Sat, 16 Jan 2021 21:53:32 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id iJTrM1xgA2AmAwAA1q6Kng (envelope-from ) for ; Sat, 16 Jan 2021 21:53:32 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CE298940355 for ; Sat, 16 Jan 2021 21:53:31 +0000 (UTC) Received: from localhost ([::1]:47256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0tVi-00056t-Ln for larch@yhetil.org; Sat, 16 Jan 2021 16:53:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50874) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0tQQ-0005HQ-SH for guix-patches@gnu.org; Sat, 16 Jan 2021 16:48:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60844) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0tQP-0007Eo-Vn for guix-patches@gnu.org; Sat, 16 Jan 2021 16:48:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l0tQP-0000rH-Sz for guix-patches@gnu.org; Sat, 16 Jan 2021 16:48:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45707] [PATCH] gnu: Add obs-v4l2sink. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 16 Jan 2021 21:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45707 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Alexey Abramov Received: via spool by 45707-submit@debbugs.gnu.org id=B45707.16108336603271 (code B ref 45707); Sat, 16 Jan 2021 21:48:01 +0000 Received: (at 45707) by debbugs.gnu.org; 16 Jan 2021 21:47:40 +0000 Received: from localhost ([127.0.0.1]:44157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0tQ4-0000qh-Hv for submit@debbugs.gnu.org; Sat, 16 Jan 2021 16:47:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0tQ3-0000qS-3X for 45707@debbugs.gnu.org; Sat, 16 Jan 2021 16:47:39 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58691) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0tPx-00074H-OW; Sat, 16 Jan 2021 16:47:33 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=37628 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l0tPx-0001ck-Bz; Sat, 16 Jan 2021 16:47:33 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87turt4ogl.fsf@gmail.com> <87turt2m7v.fsf@delta.lan> <87pn28aoqi.fsf_-_@gnu.org> <87k0setadp.fsf@delta.lan> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 27 =?UTF-8?Q?Niv=C3=B4se?= an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 16 Jan 2021 22:47:32 +0100 In-Reply-To: <87k0setadp.fsf@delta.lan> (Alexey Abramov's message of "Fri, 15 Jan 2021 17:47:46 +0100") Message-ID: <87a6t8y2ob.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Evan , 45707@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.86 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: CE298940355 X-Spam-Score: -2.86 X-Migadu-Scanner: scn0.migadu.com X-TUID: RjwDcLylyVfT Hi, Alexey Abramov skribis: > Thanks Ludo. With this patch, obs will check OBS_PLUGINS_PATH environment= variable for a *default* location of modules.=20 OK. > Plugins might also have some data. I am not sure if it is safe to use rel= ative path thought. Would it be better to use OBS_PLUGINS_DATA_PATH var? I don=E2=80=99t know, how does this patch change the situation wrt. finding= a plugin=E2=80=99s data? > From 9ade5607aab510cc88561efb7c0b08567b5e19fe Mon Sep 17 00:00:00 2001 > From: Alexey Abramov > Date: Fri, 15 Jan 2021 17:26:37 +0100 > Subject: [PATCH] gnu: obs: Use an environment variable for plugins locati= on. > > * gnu/local.mk (dist_patch_DATA): Add it. > * gnu/packages/video.scm (obs): Use it. > * gnu/packages/patches/obs-override-default-modules-location.patch: Patch= it. Some minor issues: > +++ b/gnu/packages/patches/obs-override-default-modules-location.patch =E2=80=98guix lint=E2=80=99 might complain about the file name length. :-) Perhaps remove =E2=80=98override-default-=E2=80=99 from the file name. > @@ -0,0 +1,32 @@ > +From 96e3c05043eb6b682b105e9080b45efeee33dcd0 Mon Sep 17 00:00:00 2001 > +From: Alexey Abramov > +Date: Fri, 15 Jan 2021 17:07:17 +0100 > +Subject: [PATCH] Use an environment variable for a default modules locat= ion > + > +--- > + libobs/obs-nix.c | 10 ++++++++-- If it comes from another distro, please indicate it clearly at the top of the file. > ++ char *obs_plugins_path =3D getenv("OBS_PLUGINS_PATH"); > ++ if (obs_plugins_path) { > ++ struct dstr obs_plugins_data_path; > ++ dstr_init_copy(&obs_plugins_data_path, obs_plugins_path); > ++ dstr_cat(&obs_plugins_data_path, "/../../share/obs/obs-plugins/%modul= e%"); Shouldn=E2=80=99t it be lib/obs-plugins, as your =E2=80=98search-path-speci= fication=E2=80=99 indicates? > + (native-search-paths > + (list (search-path-specification > + (variable "OBS_PLUGINS_PATH") > + (separator #f) ;single entry > + (files '("lib/obs-plugins"))))) How about renaming the variable to =E2=80=98OBS_PLUGINS_DIRECTORY=E2=80=99 = given that it designates a single directory rather than a search path? Could you send an updated patch? Thanks! Ludo=E2=80=99.