From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8BxkJZCjCWFM9wAAgWs5BA (envelope-from ) for ; Tue, 03 Aug 2021 22:14:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id IGIHIZCjCWHNFQAAB5/wlQ (envelope-from ) for ; Tue, 03 Aug 2021 20:14:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 608561F5B2 for ; Tue, 3 Aug 2021 22:14:08 +0200 (CEST) Received: from localhost ([::1]:37494 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mB0nf-0002Wi-FL for larch@yhetil.org; Tue, 03 Aug 2021 16:14:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59888) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mB0na-0002Vo-IM for guix-patches@gnu.org; Tue, 03 Aug 2021 16:14:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58314) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mB0na-0005QZ-Bn for guix-patches@gnu.org; Tue, 03 Aug 2021 16:14:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mB0na-0004re-7m for guix-patches@gnu.org; Tue, 03 Aug 2021 16:14:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49494] [PATCH 0/7] Add nncp Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 03 Aug 2021 20:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49494 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sarah Morgensen Cc: 49494@debbugs.gnu.org Received: via spool by 49494-submit@debbugs.gnu.org id=B49494.162802160818651 (code B ref 49494); Tue, 03 Aug 2021 20:14:02 +0000 Received: (at 49494) by debbugs.gnu.org; 3 Aug 2021 20:13:28 +0000 Received: from localhost ([127.0.0.1]:41627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mB0n2-0004ql-2t for submit@debbugs.gnu.org; Tue, 03 Aug 2021 16:13:28 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:46272) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mB0mz-0004qc-1c for 49494@debbugs.gnu.org; Tue, 03 Aug 2021 16:13:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=E12lJ5qCbOddsOUizjCOmKfq/rJj/hqxwUMbDSJ0iVE=; b=dUMMOWUmsktwDaYFXbON9SbKEH IY6NEhkcZQPnjDmMkeGdgpNNdbc97RI/Oach8WaEeKA0W5CxrHvg3Jz78ayGWKnfxjgpvTQcQEZSi 0aspR3gdvyqAe+ENsH0hOE4U7u4OEHZm8h8LQ4PCSCGi4xb3bgq1csZdjNNWgMV6ZPV+RSn5BbfhK wfiE2S9m4vID3SFTbCFrUfzglw/Yweb2dB4ONNHUKHQYvO3gM9qlpASiYgjWGtkl18EilB6ygImT/ YqpNoi+vWlHl4gWodE+Jxheg88PNopdns2lKm+L751OI2HmlkMcaXXETzUgJnb+9A4nHd4HQKejMt c6JT3D7Q==; Received: from [192.168.2.1] (helo=steel) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mB0mv-000BC0-Qj; Wed, 04 Aug 2021 01:43:21 +0530 From: Arun Isaac In-Reply-To: <86y29j4rlz.fsf_-_@mgsn.dev> References: <20210709161940.12759-1-arunisaac@systemreboot.net> <20210709161940.12759-7-arunisaac@systemreboot.net> <86wnphrfhr.fsf_-_@mgsn.dev> <87o8agapkl.fsf@systemreboot.net> <861r7c5r3v.fsf_-_@mgsn.dev> <87im0nai37.fsf@systemreboot.net> <87v94nzogj.fsf@systemreboot.net> <86y29j4rlz.fsf_-_@mgsn.dev> Date: Wed, 04 Aug 2021 01:42:58 +0530 Message-ID: <87a6ly70dx.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 608561F5B2 X-Spam-Score: -4.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: KKpdN0nrNPCi --=-=-= Content-Type: text/plain Hi Sarah, >> I set up a tmpfs file system at /tmp. And, curiously, now the package >> builds successfully. No idea why this is happening, though. > > I actually just figured this out as well. You're on a rotational disk, > aren't you? Yep. > Since nncp makes heavy use of the spool file (which I think > it mocks in /tmp for testing), I think that's why your tests are taking > so long and timing out. Tests complete for me on a SSD in ~40s. (All the > error messages are red herrings; they're expected errors.) If this is > the case, it might be worth it to increase the test timeout for those > who use --no-substitutes. Indeed, that makes sense! I have now disabled the timeout. Without a tmpfs, the tests take ~47 minutes on my rotational disk, but they do complete successfully. >>>>>> Does CFGPATH need to be set? >>>>> >>>>> I have now set CFGPATH TO /etc/nncp.hjson. >>>> >>>> When I run any of the executables, I get: >>>> >>>> main.go:73: Error during initialization: stat /usr/local/etc/nncp.hjson: >>>> no such file or directory I fixed this as well. `go list` wasn't finding the correct module path, and thus the correct cfgpath variable was not being set. I'm sending a v3 of the patch. Let me know if everything looks good, and I'll push. Thanks for the comprehensive review! :-) The package looks much better now. Regards, Arun --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFPBAEBCAA5FiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAmEJo0obHGFydW5pc2Fh Y0BzeXN0ZW1yZWJvb3QubmV0AAoJEC4l7othgCuz+/wIAIKvi4eal6b6jzjlFSJf WhLYXGQWWr9ZfqCwbJNvRJGlPh3oATstwWvJIH8RFyoQrKsk8ZS1MbRLkUzxLKYI WbinOzrK3KF37k0YJrsv6Jb7Gz12GD+loSVli/B9AoIwZw9HvGignJsQcrH9IOZ5 k6LuaV43gOhfg8LZEf3Vc2bdtdKMx1hPNb1EcoMQRQ5I/Q7jzM6joKbpHAMfsvxO USvWVz6ix43GRF3dHHFHt5AK9PlvOaBVz5AwgtFJZEMDYm1rZY/k7xBvnylyipQ9 lwO+Jcf/96CP1mIaF48gELMXuXz/Nqu4+Pv4NO4tv4Di2MCIdLYE2Wocwse9RMjI Wi8= =YjY9 -----END PGP SIGNATURE----- --=-=-=--