From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kKOmLxxsVGGcggAAgWs5BA (envelope-from ) for ; Wed, 29 Sep 2021 15:37:32 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id AMFAKxxsVGEPVQAAB5/wlQ (envelope-from ) for ; Wed, 29 Sep 2021 13:37:32 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 85F9A32BD8 for ; Wed, 29 Sep 2021 15:37:32 +0200 (CEST) Received: from localhost ([::1]:46606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVZm4-0005S6-W6 for larch@yhetil.org; Wed, 29 Sep 2021 09:37:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVZSI-0006eE-T6 for guix-patches@gnu.org; Wed, 29 Sep 2021 09:17:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36520) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mVZSI-0004Wp-KN for guix-patches@gnu.org; Wed, 29 Sep 2021 09:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mVZSI-0001ua-An for guix-patches@gnu.org; Wed, 29 Sep 2021 09:17:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50620] [PATCH 0/2] Unify 'computed-origin-method' (linux, icecat) Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 29 Sep 2021 13:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50620 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mark H Weaver Cc: Liliana Marie Prikler , 50620@debbugs.gnu.org, zimoun Received: via spool by 50620-submit@debbugs.gnu.org id=B50620.16329214157330 (code B ref 50620); Wed, 29 Sep 2021 13:17:02 +0000 Received: (at 50620) by debbugs.gnu.org; 29 Sep 2021 13:16:55 +0000 Received: from localhost ([127.0.0.1]:48066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVZSB-0001uA-0l for submit@debbugs.gnu.org; Wed, 29 Sep 2021 09:16:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVZS9-0001tw-H2 for 50620@debbugs.gnu.org; Wed, 29 Sep 2021 09:16:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56074) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVZS3-0004MQ-DQ; Wed, 29 Sep 2021 09:16:47 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=36416 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVZRa-0003tO-Rw; Wed, 29 Sep 2021 09:16:19 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210916114734.2686426-1-zimon.toutoune@gmail.com> <9b6ee27ff10e1042a5d61d0f93d957cf760e9ecb.camel@gmail.com> <87v930ay5y.fsf@netris.org> <87pmstghx0.fsf@netris.org> Date: Wed, 29 Sep 2021 15:16:16 +0200 In-Reply-To: <87pmstghx0.fsf@netris.org> (Mark H. Weaver's message of "Tue, 28 Sep 2021 05:36:48 -0400") Message-ID: <87a6jv8qu7.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632922652; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=YAVllSSP+dJydts10LraHLrxL/qU5zq3cStZNBk2gPc=; b=BKDmuH9F8LZMeM/lKWz0saaw+bsQ/Q4/J4E5NJk8X1YMgDThxAPCT+VTtoDg2cBINbvMUa SOIsmB10dDo8FPuHqnbyKiy6ddtLxeOW+TbDeCYzkgxC51CbGIPhD5OVfmi8j/XXdd6yJF 9DPAYPu6slicNtOE+y/fH1N/NL9zuRn6ky8HDn050kvQQhGK+Hr3apArl0l9ofckKLqIUB 66a5xcHr205UqU5hzJslwHkeQTsrBEsy/3lg/x5IVVoOLNwStt0+GaMk64PhZv6wyQTcPR PT2x6sAtU7A+eXAfyMVf2hNYItYsNgCqBuQ5iJF/BsOHaH2pOm3VvKA/cOws5w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632922652; a=rsa-sha256; cv=none; b=Ff+kuw+cYw0do47iSWODPzZ6hqzNY+kMjBneTBnxXWJ0rjCKnCNMjt5iyzx0vL6Ocwugp/ IzhAXLbJ9NLRSOY+nnwFwid6wGzEnF6BCqLCtKoPZ7ch0gYiVXgXa6tg+oi3HWxaQ7vBki Y8c1JYx6yaYrMqgJxrpC92OpM/vX1IopRb6J9ZnMDQJkSWxZmOmcJssylNBVfBFdMjlCSg DL/VM871K3jJkRGPbiSED6UjlU3YUDXWXkuNMB1SUUBZaLhcqQFMixQEenP+4C0vKRmhsH 7IhkSSvXZGzELLVgeuDzVWAcC63t0rItvPJ8M+GhEWkO9l4yB5SpEbn9nMvDVw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.40 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 85F9A32BD8 X-Spam-Score: -1.40 X-Migadu-Scanner: scn0.migadu.com X-TUID: U2xPbS7dR5at Hi there! I=E2=80=99d rather go with zimoun=E2=80=99s original patch, which is focuse= d and does nothing more than what was originally intended, which is to factorize the procedure. I=E2=80=99ll go ahead and apply it shortly if there are no objections. As Mark wrote, =E2=80=98computed-origin-method=E2=80=99 remains a hack, so = we can discuss about the best way to improve on it, but that=E2=80=99s a separate discussion. What you propose, Liliana, is one possible way to improve on the situation, but only on the surface: the hack remains, it just gets its own module. A better solution IMO would be to improve the =E2=80=98snippet=E2=80=99 mec= hanism in the first place. =E2=80=98computed-origin-method=E2=80=99 improves on it in tw= o ways: (1) lazy evaluation of the gexp, and (2) allows the use of a different base name. I would think #2 is addressed by the =E2=80=98file-name=E2=80=99 field (isn= =E2=80=99t it?). As for #1, it can be addressed by making the =E2=80=98snippet=E2=80=99 fiel= d delayed or thunked. It=E2=80=99s a one line change; the only thing we need is to meas= ure, or attempt to measure, the impact it has on module load time. Thoughts? Ludo=E2=80=99.