From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SKW/Odg942G5gQEAgWs5BA (envelope-from ) for ; Sat, 15 Jan 2022 22:34:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 0LaWMtg942GUXgAAG6o9tA (envelope-from ) for ; Sat, 15 Jan 2022 22:34:16 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6EBD5450A0 for ; Sat, 15 Jan 2022 22:34:16 +0100 (CET) Received: from localhost ([::1]:38884 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8qgh-0002FF-2O for larch@yhetil.org; Sat, 15 Jan 2022 16:34:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36762) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8qgU-0002F7-D7 for guix-patches@gnu.org; Sat, 15 Jan 2022 16:34:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:49177) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n8qgU-0000ux-3t for guix-patches@gnu.org; Sat, 15 Jan 2022 16:34:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n8qgT-00052U-Vs for guix-patches@gnu.org; Sat, 15 Jan 2022 16:34:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52828] [PATCH] Fix Disarchive fallback on Guix System Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 15 Jan 2022 21:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52828 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Timothy Sample Cc: 52828@debbugs.gnu.org Received: via spool by 52828-submit@debbugs.gnu.org id=B52828.164228241119326 (code B ref 52828); Sat, 15 Jan 2022 21:34:01 +0000 Received: (at 52828) by debbugs.gnu.org; 15 Jan 2022 21:33:31 +0000 Received: from localhost ([127.0.0.1]:42080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8qfz-00051e-Dw for submit@debbugs.gnu.org; Sat, 15 Jan 2022 16:33:31 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:36958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8qfy-00051Q-2Q for 52828@debbugs.gnu.org; Sat, 15 Jan 2022 16:33:30 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 7EFAB2D7; Sat, 15 Jan 2022 22:33:23 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kiaUrmj_Ii3Y; Sat, 15 Jan 2022 22:33:22 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 75CB929C; Sat, 15 Jan 2022 22:33:21 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <877dbpuc2n.fsf@ngyro.com> <87mtk9kiol.fsf@gnu.org> <8735lpxbd1.fsf_-_@ngyro.com> Date: Sat, 15 Jan 2022 22:33:21 +0100 In-Reply-To: <8735lpxbd1.fsf_-_@ngyro.com> (Timothy Sample's message of "Sat, 15 Jan 2022 10:33:14 -0500") Message-ID: <87a6fw3cri.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-Rspamd-Server: hera X-Rspamd-Queue-Id: 7EFAB2D7 X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642282456; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=2vdNafL1bjNZvWlSA4rInFDwi3/+No7BDmOLSxFiCBM=; b=GFMqgTtMuAN+f9N8ugknVQUgo9oyM/VHWbAKmquFJZbpnZJVpaWCQh5PHs9NLiwKxRYCkS 5DD/wAY5h7wFcEv27ukf70Lte77SgPbwmyGNRME+Mjl2T+RpMn6PG0jhrLrOvkEx71k0L0 Vtfgmph10q1OJkcFgAO6CMHG62gcBKw8aTsXy4BpW5waNAjSaMznNKPpBVN46B8PagIBVC PqFIM2c0xdQtOUSvkFRyvb3rUIc+q/iPwF8nh43WmaYdyXxyE3u72/5R/cAUrkxywAHHcr UOM8cL6UKJqU29df2M6W5wt8J4gMXFKAQhucc5ns6StXTo9weiVgWjF7lkgbrQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642282456; a=rsa-sha256; cv=none; b=Y/Nm4tbOxP8k2Ez+M7QeWbq1kC7PNMBsg2fGY7aDjZUr/QV/8MsrN5oXA5dMLVsKGP8JaC bNsslqfg7Vsd0Klvymh6U3LzLMoLX/53KkVTZsLtSXtPCY3tJrz52Ta2a/a1/r+eyeK/S6 0FCE1Xn3H61rruGoZN105Ta73KYJbDPWlqhEeBstoOm6La87uCda+rw+WD9XWlFWu7qMZI bSqJsTIv7rUBa8a2SPCIW8bLO544RnbPgDahFV079xjVF5FoAy1sFiKzAuS1D5YqiI7Gjw 5j1z1yFcrbrcIP66PVlmX0ye/i64SDOAWCt8AcvTCQyCxJ6+pRO2HVhNpwtRUw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.62 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6EBD5450A0 X-Spam-Score: -3.62 X-Migadu-Scanner: scn1.migadu.com X-TUID: M/TQLl507HT1 Hi, Timothy Sample skribis: > Ludovic Court=C3=A8s writes: > >> What about uses of guix-daemon on other distros? Perhaps we assume tar >> and gzip are already on PATH? > > That=E2=80=99s my guess. And if those other weird distros don=E2=80=99t = have =E2=80=98tar=E2=80=99 and > =E2=80=98gzip=E2=80=99 in =E2=80=9C/usr/bin=E2=80=9D, I=E2=80=99m sure th= ey=E2=80=99re plenty accustomed to liberally > patching their packages. ;) True. >> I=E2=80=99d feel more comfortable with a solution at the package level. = In the >> =E2=80=98guix=E2=80=99 package, or perhaps in a Makefile.am, we could ha= rd-code absolute >> file names of tar and gzip in (guix scripts perform-download) and set >> PATH from there. We=E2=80=99d need to do the same in (guix self) though. >> >> Alternatively, we could change (guix swh) to use Guile-Zlib and the tar >> implementation of Gash-Utils or that of Disarchive. >> >> WDYT? > > I=E2=80=99ve attached a new patch that mixes those two suggestions but ge= ts the > first one a little wrong. It uses the absolute path for =E2=80=98tar=E2= =80=99, but uses > Guile-zlib for decompression. > > I honestly don=E2=80=99t have a strong opinion about when and where to set > =E2=80=98$PATH=E2=80=99 vs. using a configured, absolute path. My origin= al patch > assumed that it=E2=80=99s the user=E2=80=99s job to make sure that =E2=80= =98tar=E2=80=99 and =E2=80=98gzip=E2=80=99 are > available to Guix at runtime. This patch assumes that that linkage > happens at configure time. The main benefit I could see to setting > =E2=80=98$PATH=E2=80=99 in =E2=80=98(guix scripts perform-download)=E2=80= =99 is that we could add our > =E2=80=98tar=E2=80=99 and =E2=80=98gzip=E2=80=99 as a suffix. This makes= it work while allowing users > to choose whatever =E2=80=98tar=E2=80=99 and =E2=80=98gzip=E2=80=99 they = prefer. The downside is that > whenever we use =E2=80=98(guix swh)=E2=80=99 have to remember to make sur= e that =E2=80=98tar=E2=80=99 > and =E2=80=98gzip=E2=80=99 are available. > > Basically, I can to change this to do the setup in =E2=80=98perform-downl= oad=E2=80=99, > but I really want to understand why. Hmm yes, I guess you=E2=80=99re right, I prefer the initial patch after all. (In particular I=E2=80=99m not keen on adding things to (guix config).) Go for it? Longer-term, I think it would still be interesting to migrate to Guile-Zlib + Disarchive/Gash-Utils, but we can check that later=E2=80=94bet= ter fix the Disarchive fallback first. Thanks and sorry for the hesitations! Ludo=E2=80=99.