From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ECQVB4AQ8WEoDgAAgWs5BA (envelope-from ) for ; Wed, 26 Jan 2022 10:12:32 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id iMBdBIAQ8WEN3QAA9RJhRA (envelope-from ) for ; Wed, 26 Jan 2022 10:12:32 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 71F092D615 for ; Wed, 26 Jan 2022 10:12:31 +0100 (CET) Received: from localhost ([::1]:33704 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nCeLu-0006o1-Ig for larch@yhetil.org; Wed, 26 Jan 2022 04:12:30 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58240) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nCeL3-0006I0-0p for guix-devel@gnu.org; Wed, 26 Jan 2022 04:11:37 -0500 Received: from [2a00:1450:4864:20::22a] (port=36808 helo=mail-lj1-x22a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nCeL0-00076G-N7 for guix-devel@gnu.org; Wed, 26 Jan 2022 04:11:36 -0500 Received: by mail-lj1-x22a.google.com with SMTP id j14so18857521lja.3 for ; Wed, 26 Jan 2022 01:11:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop-in.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=NBCyGdOYoR9xMZy4ZFnaKvBrYx0cqNplreLx6xUmU0E=; b=y95nrMi8/VMVnIEWOWE+NXTiR4wUlwz5DyaU1akbBt2199sUnobCjqV0y6/o/JeY+v fHtRvSv+qz0UrjA6qFiI4rBAKekeuoA0m7EcYmlN5kMSxp3V1slbgh+SwWa37S0agOBe KvOQdgaNkzRHtsJcLZMUPXCjyQtwPxW6N0vw5Yzn1NzKqX0zc42KyYWUr6N9IwedUvb8 k5yf/H5QKJW+rU1x2fAYHp6E6MNrv3vm8OPYCFlicM/Q4DmDP8HsLSckajoAG1/OdGCg O2MnPu7UkUT3Vt6cRmWwtLMFekaqstjXYzl9GM9rSphkhIdN2jvjDltTWr/tVC2Le2CA BmxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=NBCyGdOYoR9xMZy4ZFnaKvBrYx0cqNplreLx6xUmU0E=; b=iPSr1BDd8F/aiMDg6s59cbehwrKTZH+MhMgYN2TiBBfDALB4SqL34Wx9LHA4Fl873F phMabsyo86dafS9lp+G86IsZ2Idptq71q2dri4lGPzepDcAxt2hzK1UZzt853avGX8Ux D0ArPHnBnS+AseKPdzBK+F87LqkAmtKx3wVto+AT5qFcr7qWI35zO6MVrCzZQAcTk1Cl NjXQORivmWPcBSOfagkyISEU0HyjmnaPIs7x06SpWMS5/GE49UCF8qHvlIBUd6fX5ktm OPOhPWi/9nVaNjA2zJGEB446oMphaQ05KLpkOxohlFi25EnxMcUqAMI9OcXrDVn7Btjt bpZg== X-Gm-Message-State: AOAM530tK8BX0LTlnvg9ZRGENjoRrOKMHsTZy3eLHT554ulg4bpKUSTM ARK8gxHvCwYaFBdUpijJsc9+Aw== X-Google-Smtp-Source: ABdhPJwgKEFR3sswKev00cUgn4o+6w1Wx+8kg0kcsAlUvRaHGfwZ0bNHFN1oc8/+LxLH7vh9CP+AHw== X-Received: by 2002:a2e:9e19:: with SMTP id e25mr18032931ljk.238.1643188293014; Wed, 26 Jan 2022 01:11:33 -0800 (PST) Received: from localhost (109-252-135-33.dynamic.spd-mgts.ru. [109.252.135.33]) by smtp.gmail.com with ESMTPSA id x12sm955125lji.57.2022.01.26.01.11.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jan 2022 01:11:32 -0800 (PST) From: Andrew Tropin To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: Return back original implementation for text-config serialization In-Reply-To: <87mtjlrvp5.fsf@gnu.org> References: <878rvp1deg.fsf@trop.in> <87mtjtglxd.fsf@gnu.org> <87o846y24v.fsf@trop.in> <87mtjlrvp5.fsf@gnu.org> Date: Wed, 26 Jan 2022 12:11:28 +0300 Message-ID: <87a6fix3nj.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::22a (failed) Received-SPF: none client-ip=2a00:1450:4864:20::22a; envelope-from=andrew@trop.in; helo=mail-lj1-x22a.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org, Xinglu Chen , guix-maintainers@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1643188351; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=NBCyGdOYoR9xMZy4ZFnaKvBrYx0cqNplreLx6xUmU0E=; b=PPURIcZinQtZ9eGnXJ68KYuWh7ers2Ql1Bul7BfeEImYI7YjIfCgOUDP7NQqTAoaX1OUAL UWYj5JLXEAbE9GAeigaeXYv2Q/K5JxtAUJ3y/x2Wr0+XkLiPC+FZyll/SSfs0E0PvjS7rO AqGocKvdbnKUc0DVmN0ZC9se7BUA67d/s/+O4PVdlKvcnF7pCxAMleTMzuELc0h4uz7bM5 oaNWWy2bWVOiDPbU1p60xS9ZX8mB4MeUDGPN2RGARTsLixXrIlfYdmT9Ei/CUZEu8mUtR0 tHknXeseWcu24gZjTKMEBFjBWPNkOWefz0+b4/Ml4wD50siTYAuExLg48s6Kmg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1643188351; a=rsa-sha256; cv=none; b=JZzLIRswDs3g0ctD9oKUsf4DXaJovnpYmdZo+NhX7Ct29g+qwMoyeSeJb00usINXIHDgxz MsJsQuCAoeNtKZrYXRUMQed60YgUJSh0wb6A550t4aMD6tiYQgeP5RJulMoGXmzHpZMCcF t1z7ECoaT27k6lloktaSUkqNcztcmb08FFFfJub6SyTIYN7BhNNFcDxUaje2WVl/o5KMPy n7ddCdpxO7dmdSyb9tqpAYP1wv8qYM8nDVTI/FRTZBK20PKPCdbfR9ATQddI8Xux803KgH cHJDR4JnAEsyzqPG6vlCKaJXqPfaMpuURuJTs2JelYq3LePt2R0AnD6eW40YTQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop-in.20210112.gappssmtp.com header.s=20210112 header.b=y95nrMi8; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.53 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop-in.20210112.gappssmtp.com header.s=20210112 header.b=y95nrMi8; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 71F092D615 X-Spam-Score: -5.53 X-Migadu-Scanner: scn0.migadu.com X-TUID: nfY3QJMfCSqu --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2022-01-24 16:37, Ludovic Court=C3=A8s wrote: > Hi Andrew, > > Andrew Tropin skribis: > >>> Making Guix Home part of Guix was and still is a commitment, in >>> particular the commitment that we=E2=80=99d all be working on one >>> implementation, that there are no =E2=80=9Ccompetitive incompatible >>> implementations=E2=80=9D. It=E2=80=99s a choice we made, not a phenome= non we=E2=80=99re >>> passively observing. >> >> This is exactly what I want to achieve: To be able to collectively work >> on one consistent implementation, but fee0bc, which slipped to the >> master unreviewed, splitted home service configuration approach into two >> competitive implementations, a few essential home services in guix repo >> and bigger rest of non-essential stuck in rde. > > I love that rde is going much further than Guix, but I think it=E2=80=99s= in > nobody=E2=80=99s interest to =E2=80=9Ccompete=E2=80=9D. > > The change in question was discussed at length and reviewed at > . > The intent of the patch series was to rename modules and the change about text-config was added somewhere in between. I asked to move it out to the separate thread and do a separate review on that, but seems the message was missed. > I think this patch requires more discussion and better to keep it > outside of this patch series. Skimmed throught other patches, overall > LGTM. The proper review of this big patch series with a few unrelated changes is hard and inefficient. We can see that here: https://issues.guix.gnu.org/50967#66 The semantically-incorrect change was applied, not mentioning that the discussion about this whole patch #13 wasn't finished in my opinion. I'll be more clear next time and will state the intent more precisely to prevent such situations in the future. Sorry for rising the same thread again and again, but it's really improtant in my opinion and I would like to complete this discussion. Seems Maxime rised good questions and proposed nice ideas and discussion is going forward. >> I already mentioned at least two possible ways to handle this >> situtation: >> 1. Rewrite the rest of rde home services. >> 2. Rollback this change. >> >> I'm ok with both options, but #1 requires much more human hours to >> complete and I still not sure if fee0bc was introduced for strong >> reasons or was added almost accidentially. So I try to find a >> justification for this change. > > I don=E2=80=99t want to cause troubles in rde for you and its users, but = I also > don=E2=80=99t want Home decisions to be discussed there. > >>> Are there Guix Home issues reporting this? >>> >> >> Just a 3 cases I observed in Guix Russia telegram chat. > > OK. I don=E2=80=99t see anything at though= , which > is where I=E2=80=99d expect bug reports for Guix Home. > Of course, I try to redirect people to guix mailing lists, but despite this fact the discussions and question happens in other places too. >>> Are there any new arguments since the already lengthy discussions that >>> led to fee0bced7fec2f9950957976a28f033edd4f877c? Is it really what=E2= =80=99s >>> leading to Guix Home being stale, or is there something else? >> >> IMO, changes to text-config in fee0bc really makes it harder to continue >> the work on many Guix Home related tasks. > > It feels exaggerated to me, but that=E2=80=99s perhaps because I=E2=80=99= m overlooking > important aspects. > > I=E2=80=99d like us to move forward on this. I think the best course of = action > is to focus on concrete things rather than abstract design discussions. > > Can we move, one by one, a few more services from rde to Home? > > Earlier I mentioned the SSH client service, but there are more. When we > move them, let=E2=80=99s see if problems arise related to this pattern or= to > other changes made in Guix Home. At that point perhaps it=E2=80=99ll be = clearer > for everyone (or at least for me) what concrete problems this poses and > how we could address it. > > How does that sound? > Ok, let's try, but please don't hurry, a few first services are important, because they set the style and I would really want it to be consistent and well-designed. > In the meantime I submitted a patch for my first Home service this > week-end. :-) Saw one of your week-end patches, will find the rest, test them and share my thoughts in a few days. I have some attention problems, so I don't follow all the patches on guix-patches, please CC me for Guix Home related changes if it's possible and not very burdening.=20=20 =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmHxEEAPHGFuZHJld0B0 cm9wLmluAAoJECII0glYwd6wcSAP+QHph3/fVtGMkrBZnEkMASM/wAS9LOZfE/lQ wgRrcI2WN3YkG4pdNZGgcaxsUl5dY5pE5Srjv28j3m1dyrlCYwya5/MOIfVTGlYl ji3YE/Tw+18nkc9JySyJe9NFIMDFx4ywwAbIimhr8HQhZNf+x0o21+2q67jiWaY0 cepJZJYmpQu3jCG714E+HgHXSwExOV757yO0e51g/lK7D4Gz2RR8c/umfJyr/lec SUgeRUcE79C0nmt+syWQgLfY2pWOQi2lDmZLPsHgAaMFXMc5Jg9PkWtFZj1J8znm x9r4IzVNJYMOEddzZSpHYgDyT8RclOayneNW+qUW3TH3uGEYUj7IJkLWHL7vQTMm juVxBhYA6S2iWXnYv/Uh5wm8wt75LVdNToG9tfrT6dxU7HpUnG1t9wT0YXDVcd0a yJnso0w8hfBELmKvI40mXKysbOdcvKWN1G5RVwkrKf8VZP+dH3laOFbm3kz0yGcu xK73AHcH/KUySlJZ3xAI6Qcc2clC+nxxvMU7rCBsYrRRNkjXdBgvSwneSyfH7z87 tFc9E8oJNJffAFUCcVM5Ud9lVh7Ce5PRiRoxmCWAhj7GJjOVQdTtWAdtAJ7MmaoS 0ku8hk4gR1oX0yMY9/glTcEkeVfFx9rpxdcF+26CgdCh1f7uQOZsEtMX07pnibN2 YuZ/0/T5 =0xw3 -----END PGP SIGNATURE----- --=-=-=--