From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id AEOWNWfm+WHTBAEAgWs5BA (envelope-from ) for ; Wed, 02 Feb 2022 03:03:19 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yC8lLmfm+WFNdwAAG6o9tA (envelope-from ) for ; Wed, 02 Feb 2022 03:03:19 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4EEE11FD54 for ; Wed, 2 Feb 2022 03:03:19 +0100 (CET) Received: from localhost ([::1]:49212 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nF4zO-000127-EY for larch@yhetil.org; Tue, 01 Feb 2022 21:03:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEzcE-0001wo-0Z for guix-patches@gnu.org; Tue, 01 Feb 2022 15:19:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51344) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nEzcD-0000jc-ME for guix-patches@gnu.org; Tue, 01 Feb 2022 15:19:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nEzcD-0001ot-JA for guix-patches@gnu.org; Tue, 01 Feb 2022 15:19:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53676] [PATCH 2/5] services/sound: Normalize pulseaudio-configuration accessor names. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 01 Feb 2022 20:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53676 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 53676@debbugs.gnu.org Received: via spool by 53676-submit@debbugs.gnu.org id=B53676.16437467186958 (code B ref 53676); Tue, 01 Feb 2022 20:19:01 +0000 Received: (at 53676) by debbugs.gnu.org; 1 Feb 2022 20:18:38 +0000 Received: from localhost ([127.0.0.1]:44245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEzbq-0001oA-CT for submit@debbugs.gnu.org; Tue, 01 Feb 2022 15:18:38 -0500 Received: from mail-qv1-f48.google.com ([209.85.219.48]:38547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEzbp-0001nx-0X for 53676@debbugs.gnu.org; Tue, 01 Feb 2022 15:18:37 -0500 Received: by mail-qv1-f48.google.com with SMTP id b12so17061336qvz.5 for <53676@debbugs.gnu.org>; Tue, 01 Feb 2022 12:18:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=2FKOqX4saXK21OJdyibV7YtiHQhd9rvWH+GRhtHH9d8=; b=VzzikbZZD8kPDAHGJP0gCHXBOa9NkY0JecKVeUu/WN2439o4KoE4HRsxKisJ4o2YOH p6aoUJr34JzztMSjoxX9XbsiIXEblOSuiOCicf+YxT5qvzX7ZOI/g6Sa331Kdm0ZCBdZ 1TWhptsZ+sCoP8wIbkJYHLV2i6xx/ioICn5zaFQW6KlEqBulQ7qQ1f9G/CNWgccs2fmq 4VzoMm5p/46mYZJWv26mLwjRP7cZW/Y40S9TH132EY88T4QIjCCFleNCQosfrOEfWyuQ P15lRRVN3nE3mcW7NFdCJrmq6SH2RiPQ5ZDmK4lTqLFC2ecNmD3DSaVUl+yhO+SoGVB6 rxUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=2FKOqX4saXK21OJdyibV7YtiHQhd9rvWH+GRhtHH9d8=; b=fViaKhYTg/1Z7/9u9arhajEa2bgodSrKVlhVXDpDH7PmNY9Cgd6B7X3aTU9Ab88w/H VCd+UqQtYgUJx/7J5oHV8zOFnBv8bxx0c8UXiLybGD8Pj60aoHqjsEL85Rg/JiUjOGnW y0Bcsyv9nLGrarlVBVeUpmta9GxIgU90Qla2cfOhsw9lTZYxuBMIcjQv9V2fo0fTxC+g wZyfkjUimrH4GphrdcjTRETH0rH9FzGHa6xvVveegiBnFP8nBaXhuJ7GltC3/BVQhN/E JG28xenTM/BtYonXKJaFLdXmpbMitxpfGADLOeMEmjSro+YQt6DmrgmTUcocxqj33hNU xhxA== X-Gm-Message-State: AOAM533vaeSjKdN7zHrGLkZdY+Nj7+r8R48K/XSAB4BLBUhP4SMT0UG5 OGWxoEkwIgNq5iMvICQp/8yXfsLNz0M= X-Google-Smtp-Source: ABdhPJxFCcaDz6X/lcxUrUYfsi8sLjnQMQnjnYJCPrlHuimb+oDg6bZssD3yA5y3DGNbqbK3VCC3uA== X-Received: by 2002:a0c:fc43:: with SMTP id w3mr24516933qvp.92.1643746711466; Tue, 01 Feb 2022 12:18:31 -0800 (PST) Received: from hurd (dsl-149-193.b2b2c.ca. [66.158.149.193]) by smtp.gmail.com with ESMTPSA id j14sm11193675qkp.131.2022.02.01.12.18.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Feb 2022 12:18:30 -0800 (PST) From: Maxim Cournoyer References: <20220201041933.16603-1-maxim.cournoyer@gmail.com> <20220201041933.16603-2-maxim.cournoyer@gmail.com> <9dfb26ef7c3e30baf1eba3334c2b9b5c593be76d.camel@gmail.com> Date: Tue, 01 Feb 2022 15:18:30 -0500 In-Reply-To: <9dfb26ef7c3e30baf1eba3334c2b9b5c593be76d.camel@gmail.com> (Liliana Marie Prikler's message of "Tue, 01 Feb 2022 20:48:57 +0100") Message-ID: <87a6fa1gtl.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1643767399; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=2FKOqX4saXK21OJdyibV7YtiHQhd9rvWH+GRhtHH9d8=; b=vDWnbFqL8vjq78YNaaRGFBg1neBhNFgzbywx7NjqAoTcXHtI/+ICSO0W/Uw6hLoYT4fS1i vxJGX3FZVxb4GpzZpwuZX/z1VgkCpwxgZ5QFc5Lj8JlPahf0sdcjlyB+YXheiw4st6WZXz x0+Cch471KM+OmmuJc7S0OHhjd9bzqZ+VqnbiYvqRvNTjU0xVvVMkInodxDgJDchf8SPWl m9KOMhwqq6F3BkbDaQ/DhsZyP3+VKdq3/0hTv0RBdTe7Th023eYdxKEGS7QmTlrOXzc75f Q3htPmNKv5qGxlz0nYNTOaZZSgKagBTu5SFRMTLC3mbHmAf2naQXKlcBj7wuxQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1643767399; a=rsa-sha256; cv=none; b=qmzni7SeeOBXGrXUqDPuZV1nZa3+buiwpiF9/+ooOkn48e8iP3SE0OZ7KJCd8cXJevv+3C m2vRDouhlIlJ6NuJtcuD9yYtko1CRcrHN8b338xxqpkSAcjKxr1cRKUxQkPkWsk4GmPB4+ BOA97gsDz+ZLw0En4xsPbFhSbXNPJMUfgYg9AhSC4roqWHPzk+S5/Jyhr3nHrIo73RADc0 6SiqB1Z0rPp05JdJP9DzQHmkNY1sUf35ATHsw+CKGKZoocdmQ6Wo3g38qVmjSr0pofNiZh gKVRjaEHfK4eLrK08FBekvj6I46tVFZayrgWcMZNoO5zv4DUVTKKonlQV1l42A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=VzzikbZZ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.03 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=VzzikbZZ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4EEE11FD54 X-Spam-Score: -3.03 X-Migadu-Scanner: scn0.migadu.com X-TUID: +9ix2q7ORfju Hi Liliana, Liliana Marie Prikler writes: > Am Montag, dem 31.01.2022 um 23:19 -0500 schrieb Maxim Cournoyer: >> * gnu/services/sound.scm (): Adjust getter >> names to match convention. >> --- >> =C2=A0gnu/services/sound.scm | 9 +++++---- >> =C2=A01 file changed, 5 insertions(+), 4 deletions(-) >>=20 >> diff --git a/gnu/services/sound.scm b/gnu/services/sound.scm >> index 7beca35ffe..19eccfc860 100644 >> --- a/gnu/services/sound.scm >> +++ b/gnu/services/sound.scm >> @@ -2,6 +2,7 @@ >> =C2=A0;;; Copyright =C2=A9 2018, 2020 Oleg Pykhalov >> =C2=A0;;; Copyright =C2=A9 2020 Liliana Marie Prikler >> >> =C2=A0;;; Copyright =C2=A9 2020 Marius Bakke >> +;;; Copyright =C2=A9 2022 Maxim Cournoyer >> =C2=A0;;; >> =C2=A0;;; This file is part of GNU Guix. >> =C2=A0;;; >> @@ -115,16 +116,16 @@ (define alsa-service-type >> =C2=A0(define-record-type* >> =C2=A0=C2=A0 pulseaudio-configuration make-pulseaudio-configuration >> =C2=A0=C2=A0 pulseaudio-configuration? >> -=C2=A0 (client-conf pulseaudio-client-conf >> +=C2=A0 (client-conf pulseaudio-configuration-client-conf >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 (default '())) >> -=C2=A0 (daemon-conf pulseaudio-daemon-conf >> +=C2=A0 (daemon-conf pulseaudio-configuration-daemon-conf >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 ;; Flat volumes may cause unpleasant experiences to >> users >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 ;; when applications inadvertently max out the system >> volume >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 ;; (see e.g. ). >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 (default '((flat-volumes . no)))) >> -=C2=A0 (script-file pulseaudio-script-file >> +=C2=A0 (script-file pulseaudio-configuration-script-file >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 (default (file-append pulseaudio >> "/etc/pulse/default.pa"))) >> -=C2=A0 (system-script-file pulseaudio-system-script-file >> +=C2=A0 (system-script-file pulseaudio-configuration-system-script-file >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (default >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (f= ile-append pulseaudio >> "/etc/pulse/system.pa")))) > I don't see calling code adjusted anywhere. Is this because we only > use match to access this records fields? The bindings are not public, so they shouldn't be used elsewhere; internally only match seems to be used yes. > On a related note, would it make sense to port this over to (define- > configuration)? Agreed. I'd prefer to keep this effort separate from this series though. Also, I still want to take some time to review the newly introduced Guix records sanitizers; I feel they should perhaps be leveraged in define-configuration (part of the appeal of define-configuration is serialization, the other part being input validation, which is what sanitizers seem to be designed for). Maxim