[bug#54024] [mumi] Preprocess search query from GraphQL before use

[bug#54024] [mumi] Preprocess search query from GraphQL before use

[Arun Isaac]

Hi Ricardo,

It looks like there is a small bug in the GraphQL patches I sent
earlier. I had failed to preprocess the search query before use.

Regards,
Arun

Arun Isaac (1):
  web: Preprocess search query from GraphQL before use.

 mumi/web/graphql.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.34.0

[bug#54024] [PATCH] web: Preprocess search query from GraphQL before use.

[Arun Isaac]

* mumi/web/graphql.scm (<query>): Preprocess search query using
process-query before passing on to search-bugs.
---
 mumi/web/graphql.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mumi/web/graphql.scm b/mumi/web/graphql.scm
index 662c5ba..56110a0 100644
--- a/mumi/web/graphql.scm
+++ b/mumi/web/graphql.scm
@@ -102,7 +102,8 @@
            (bug-status number)))
   (issues (non-nullable-type (list-type <issue>))
           (lambda* (parent context info #:key search)
-            (search-bugs search)))
+            (search-bugs (string-join
+                          (process-query search)))))
   (person (non-nullable-type <person>)
           (lambda* (parent context info #:key email)
             email)))
-- 
2.34.0

bug#54024: [mumi] Preprocess search query from GraphQL before use

[Ricardo Wurmus]

Hi Arun,

> It looks like there is a small bug in the GraphQL patches I sent
> earlier. I had failed to preprocess the search query before use.

Applied, thanks!

(Reconfiguring issues.guix.gnu.org would take a little while longer as
we’re in the process of moving the root fs and /gnu/store to new disks.
Almost finished it today but ran into problems after rebooting.)

-- 
Ricardo

[bug#54024] [mumi] Preprocess search query from GraphQL before use

[Arun Isaac]

[-- Attachment #1: Type: text/plain, Size: 266 bytes --]


Thanks, Ricardo! I think this new patch still isn't up on
issues.guix.gnu.org, but that's ok. It's not very urgent.

Should we consider more automated ways to redeploy mumi on every commit?
Or maybe, we should run a separate development server just for
that. WDYT?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 524 bytes --]

[bug#54024] [mumi] Preprocess search query from GraphQL before use

[Ricardo Wurmus]

Arun Isaac <arunisaac@systemreboot.net> writes:

> Thanks, Ricardo! I think this new patch still isn't up on
> issues.guix.gnu.org, but that's ok. It's not very urgent.

It’s not up because we’re still having problems with the migration.

> Should we consider more automated ways to redeploy mumi on every commit?
> Or maybe, we should run a separate development server just for
> that. WDYT?

We could change maintenance.git to not use the default mumi package but
to build the latest mumi at all times.  I won’t be able to do this,
though.  Toddler has a high fever and I barely sleep these days.

-- 
Ricardo

[bug#54024] [mumi] Preprocess search query from GraphQL before use

[Arun Isaac]

[-- Attachment #1: Type: text/plain, Size: 757 bytes --]


Hi Ricardo,

> It’s not up because we’re still having problems with the migration.

No problem, this isn't too urgent.

>> Should we consider more automated ways to redeploy mumi on every commit?
>> Or maybe, we should run a separate development server just for
>> that. WDYT?
>
> We could change maintenance.git to not use the default mumi package but
> to build the latest mumi at all times.  I won’t be able to do this,
> though.  Toddler has a high fever and I barely sleep these days.

I'll take a look at this. Maybe, I can give this a shot. This may be
similar to a Guix based continuous deployment system I just set up at
work.

You take care, and take care of the little one. Family comes before
Guix.

Regards,
Arun

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 524 bytes --]