From: "Daniel Meißner" <daniel.meissner-i4k@ruhr-uni-bochum.de>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Josselin Poiret <dev@jpoiret.xyz>, guix-devel@gnu.org
Subject: Re: Deprecating legacy build phase style when cross-compiling vs. native
Date: Fri, 01 Apr 2022 12:26:12 +0200 [thread overview]
Message-ID: <87a6d53xrv.fsf@ruhr-uni-bochum.de> (raw)
In-Reply-To: <87tubdnplq.fsf@gnu.org> ("Ludovic Courtès"'s message of "Fri, 01 Apr 2022 11:02:25 +0200")
Hi,
Ludovic Courtès <ludo@gnu.org> writes:
> The easiest change is to replace:
>
> %output
>
> with:
>
> (assoc-ref %outputs "out")
>
> It’s a simple search-and-replace.
>
> The next step would be to use gexps and #$output, but that can be done
> incrementally over time IMO.
I have a patch in that direction sitting on
https://issues.guix.gnu.org/54641 and I am wondering if this is the
style that you’re proposing as the next step. If so, I could provide
some more patches for other packages as well.
I am also wondering: How are multiple outputs handled with gexps and
#$output?
Best
--
Daniel
next prev parent reply other threads:[~2022-04-01 11:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 15:17 Deprecating legacy build phase style when cross-compiling vs. native Josselin Poiret
2022-03-30 17:18 ` Maxime Devos
2022-03-30 17:22 ` Maxime Devos
2022-04-01 9:02 ` Ludovic Courtès
2022-04-01 10:26 ` Daniel Meißner [this message]
2022-04-01 11:46 ` Maxime Devos
2022-04-05 12:14 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6d53xrv.fsf@ruhr-uni-bochum.de \
--to=daniel.meissner-i4k@ruhr-uni-bochum.de \
--cc=dev@jpoiret.xyz \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.