From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QLiJGXhEWGKvAAEAgWs5BA (envelope-from ) for ; Thu, 14 Apr 2022 17:57:44 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id yAPmFnhEWGJDQAEA9RJhRA (envelope-from ) for ; Thu, 14 Apr 2022 17:57:44 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3A893F1F1 for ; Thu, 14 Apr 2022 17:57:43 +0200 (CEST) Received: from localhost ([::1]:60844 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nf1qn-0006IZ-SR for larch@yhetil.org; Thu, 14 Apr 2022 11:57:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nf1qA-0006EC-Cc for guix-patches@gnu.org; Thu, 14 Apr 2022 11:57:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34886) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nf1qA-00015o-2k for guix-patches@gnu.org; Thu, 14 Apr 2022 11:57:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nf1q9-0003JY-SO for guix-patches@gnu.org; Thu, 14 Apr 2022 11:57:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48314] [PATCH v3] Install guix system on Raspberry Pi Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 14 Apr 2022 15:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48314 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: phodina , "48314@debbugs.gnu.org" <48314@debbugs.gnu.org> Cc: Stefan , "dannym@scratchpost.org" , Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 48314-submit@debbugs.gnu.org id=B48314.164995180012709 (code B ref 48314); Thu, 14 Apr 2022 15:57:01 +0000 Received: (at 48314) by debbugs.gnu.org; 14 Apr 2022 15:56:40 +0000 Received: from localhost ([127.0.0.1]:57016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nf1po-0003It-CY for submit@debbugs.gnu.org; Thu, 14 Apr 2022 11:56:40 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]:59402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nf1pm-0003Id-2g for 48314@debbugs.gnu.org; Thu, 14 Apr 2022 11:56:39 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:20]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 0C5131AC62; Thu, 14 Apr 2022 08:56:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1649951792; bh=I1pUHf/ElpSw5pfm9Okt/q2e1zhcxFZpJincMz1GZro=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ld1OSadJJNhkw0K7b6EQ0jyRrjWBuL9USxKH8IEAKAMurkelJszB7tAOFgBFXv9lF tdIR8iaiSAFKPqC1rETG79D3PJkrPlLkreOzuy5Ten8vkPPWdxGenJbP1uHa3oPwXi mVkHFenYLnToKu5Si5g7vmVWdqSQA8ir/TslWstNchnrWXVyjxTzmVmIumbJ5/0P7h CH9+5hGsIGel0B5qCo8hiaMMW79n7D/Jc4ek/+C2MNUu08DX3hITS0k71R+v1zd+jw mgX4rYkRrJVvDTtzkCiYUDUe420OE0BffWN4wj6LRWfZ9aB4+V1sJA73e6B0dXkRbc jfvKtjhynIc+Q== From: Vagrant Cascadian In-Reply-To: <1JV7YdNsB7LB0ij9pMN5ktIsdpU8g98Lpu0yOrl_r6wFvRjqRJ5XqOktugKlia2rSeyNVEwY0b8VJrFJr1TsWgOIo-JW6EmTpj6Bz4dNzxQ=@protonmail.com> References: <1JV7YdNsB7LB0ij9pMN5ktIsdpU8g98Lpu0yOrl_r6wFvRjqRJ5XqOktugKlia2rSeyNVEwY0b8VJrFJr1TsWgOIo-JW6EmTpj6Bz4dNzxQ=@protonmail.com> Date: Thu, 14 Apr 2022 08:56:26 -0700 Message-ID: <87a6cnvetx.fsf@contorta> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1649951864; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=V0J57IQtucyDU21pgTgHn/wd2qfIcF3bxpYEhk4MRFA=; b=PFEBNaXcN1VImtu5Ami2vS7EH/fEH1ZzROzmSPK8cZRSj4+orXQc3q5lvIib923aew23JL t6ASxfvvGWE7kOlF2EKgUfFrueVg2W9/LC1dL23+KF36jpgF9WIkCeb3g0qUrIKP2iZFOP K5pAuY/dixEt2iqAEbQC4KjcY2bPMIudP8MKqB2QROmbEe/HvjnjMuM9p5gn4yTnydkwF/ W6jc1kGJLdmLAq5ymzob+cPQ6w0GZxAm31XumR3G+vqhnj2FQRdeCvF7sTIdFKS1nS26sU jQyO7eIovhqT+gjRq29IorXZHYSo4bX7IdStnPP6QAVMeq09kxLn652TTsvKkA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1649951864; a=rsa-sha256; cv=none; b=Ve5UY6aTMhUEO2edTodnUxIYxcsuneYAeeEgYKvyl2zsddyxUof2OOMWTzHScgvpJyXJUQ t4T29mAPDvYbTiypiiWDZYkFqZjj0DIGc79g1K753WBW7v1F3DAnXCgrbM+wGfFMPaIyTg HGl5Q2PGtC7HoDV5PA9Tvekb87Imj8O1EQOq6exdIAbhcr5zAWj2rMRG+em6Ab+ugPDfKH kFZb65qFFyS2mwbXhSA1mONB+/nV/qeTfemoAWH8qpaxQKKkM8OnBIEKhzxiOEOZglFA+I uEr7Hxv3wZD6Exq+JwzDUIUywDrox1jCCV/RKshdDoRXrrWldG37MhjELId3OQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debian.org header.s=1.vagrant.user header.b=ld1OSadJ; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.65 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debian.org header.s=1.vagrant.user header.b=ld1OSadJ; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3A893F1F1 X-Spam-Score: -0.65 X-Migadu-Scanner: scn1.migadu.com X-TUID: q8xIpoj8Z0Lm --=-=-= Content-Type: text/plain On 2022-04-14, phodina@protonmail.com wrote: > (u-boot-rpi-0-w, u-boot-rpi, u-boot-rpi-2, u-boot-rpi-3, u-boot-rpi-4, > u-boot-rpi-64, u-boot-rpi-0-w-efi, u-boot-rpi-efi, u-boot-rpi-2-efi, > u-boot-rpi-3-efi, u-boot-rpi-4-efi, u-boot-rpi-efi-64): New packages. Comments from November are still relevent: https://issues.guix.gnu.org/48314#12 (e.g. drop drop u-boot-rpi-0-w*, u-boot-rpi, u-boot-rpi-efi, maybe consider droping u-boot-rpi-2* and the 32-bit variants for rpi3 and rpi4, as armhf is not well maintained at the moment). Basically, ARMv6 is not supportable by guix, ARMv7 is poorly supported in the armhf architecture, and ARMv8 is capable of running aarch64 (a.k.a. arm64): https://en.wikipedia.org/wiki/Raspberry_Pi#Specifications Only proposing aarch64 variants would pretty much leave you with rpi-arm64. The EFI variants and 32-bit variants supported on armhf could be easily added later once the other patches land. > +(define-public %u-boot-rpi-efi-configs > + '("CONFIG_OF_EMBED=" > + "CONFIG_OF_BOARD=y" > + "CONFIG_BOOTDELAY=0")) See comment: https://issues.guix.gnu.org/48314#15 e.g. Please do not set BOOTDELAY=0. It makes it nearly impossible to debug. For people who want to live on the edge, they could build custom variants and set it to 0. > +(define-public u-boot-rpi-64 > + (make-preinstalled-u-boot-package > + "rpi_arm64" > + "aarch64-linux-gnu" > + #:name "rpi-64" > + #:description %u-boot-rpi-description-64-bit)) Please keep package names consistent with defconfig name. (e.g. u-boot-rpi-arm64). It's confusing enough without extra newly invented names! :) > +(define-public u-boot-rpi-3-efi > + (make-preinstalled-u-boot-package > + "rpi_3_32b" > + "arm-linux-gnueabihf" > + #:name "rpi-3-efi" > + #:configs %u-boot-rpi-efi-configs > + #:description %u-boot-rpi-efi-description-32-bit)) Ditto, or drop this variant; same for the 32-bit rpi-4 variants. > Subject: [PATCH v3 2/8] build: kconfig: Add new module to modify a defconfig > file. ... > (define-public u-boot-pinebook > - (let ((base (make-u-boot-sunxi64-package "pinebook" "aarch64-linux-gnu"))) > - (package > - (inherit base) > - (arguments > - (substitute-keyword-arguments (package-arguments base) > - ((#:phases phases) > - `(modify-phases ,phases > - (add-after 'unpack 'patch-pinebook-config > - ;; Fix regression with LCD video output introduced in 2020.01 > - ;; https://patchwork.ozlabs.org/patch/1225130/ > - (lambda _ > - (substitute* "configs/pinebook_defconfig" > - (("CONFIG_VIDEO_BRIDGE_ANALOGIX_ANX6345=y") "CONFIG_VIDEO_BRIDGE_ANALOGIX_ANX6345=y\nCONFIG_VIDEO_BPP32=y")) > - #t))))))))) > + (make-u-boot-sunxi64-package "pinebook" "aarch64-linux-gnu" > + ;; Fix regression with LCD video output introduced in 2020.01 > + ;; https://patchwork.ozlabs.org/patch/1225130/ > + #:configs '("CONFIG_VIDEO_BPP32=y"))) I like how this simplifies the package definitions where you need to adjust the defconfig! This particular workaround for u-boot-pinebook may no longer be needed, thanks for the reminder to check. > (define-public u-boot-novena > - (let ((base (make-u-boot-package "novena" "arm-linux-gnueabihf"))) > + (let ((base (make-u-boot-package "novena" "arm-linux-gnueabihf" > + ;; Patch configuration to disable loading u-boot.img from FAT > + ;; partition, allowing it to be installed at a device offset. > + #:configs '("CONFIG_SPL_FS_FAT=")))) Maybe this is different in upstream u-boot, but in the past setting it to an empty value could result in the default value, which is why: > - (substitute* "configs/novena_defconfig" > - (("CONFIG_SPL_FS_FAT=y") "# CONFIG_SPL_FS_FAT is not set")) > - #t))))))))) ... was used previously. > Subject: [PATCH v3 5/8] gnu: raspberry-pi: Add defconfig objects to build > customized Linux kernels. > > gnu/packages/raspberry-pi.scm (make-raspi-defconig): New function to make > downloaded defconfig objects from the Linux repository of the Raspberry Pi > Foundation. > (%bcm2709-defconfig, %bcm2710-defconfig, %bcm2711-defconfig, > %bcm2835-defconfig, %bcmrpi-defconfig, %bcm2711-defconfig-64, > %bcmrpi3-defconfig): New variables containing defconfig objects to build > Linux kernels customized for Raspberry Pi single board computers. Similar to my comments on u-boot variants, some of these are for models that are not supportable on guix (rpi, rpi-0), so probably best to leave out entirely, and the 32-bit variants for armhf are debatable at this point. live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYlhEKwAKCRDcUY/If5cW qtkeAP0c+M3oO8eUcFKXVFHoY5Kr8nwQTvh3udPDYOmaNMj7dAEA9f69eAL8ydg4 T05WR5yUZNqKRMmBCjkkGnGgSe+fmw0= =tQLe -----END PGP SIGNATURE----- --=-=-=--