From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: muradm <mail@muradm.net>
Cc: 57575-done@debbugs.gnu.org
Subject: bug#57575: [PATCH] gnu: fail2ban-service-type: Improve extra-content fields.
Date: Wed, 14 Sep 2022 11:32:18 -0400 [thread overview]
Message-ID: <87a6720y65.fsf@gmail.com> (raw)
In-Reply-To: <20220904112442.31501-1-mail@muradm.net> (muradm's message of "Sun, 4 Sep 2022 14:24:42 +0300")
Hi muradm!
muradm <mail@muradm.net> writes:
> * gnu/services/security.scm:
Nitpick: you do not need ':' after file name before the procedure in
parens.
I did the following adjustments to the doc, to clarify:
--8<---------------cut here---------------start------------->8---
2 files changed, 10 insertions(+), 6 deletions(-)
doc/guix.texi | 6 ++++--
gnu/services/security.scm | 10 ++++++----
modified doc/guix.texi
@@ -36629,7 +36629,8 @@ extensions.
Instances of @code{<fail2ban-jail-configuration>} explicitly provided.
@item @code{extra-content} (default: @code{()}) (type: text-config)
-Extra raw content to add to the end of the @file{jail.local} file.
+Extra raw content to add to the end of the @file{jail.local} file,
+provided as a list of file-like objects.
@end table
@@ -36757,7 +36758,8 @@ The file names of the log files to be monitored.
A list of @code{<fail2ban-jail-action-configuration>}.
@item @code{extra-content} (default: @code{()}) (type: text-config)
-Extra content for the jail configuration.
+Extra content for the jail configuration, provided as a list of file-like
+objects.
@end table
modified gnu/services/security.scm
@@ -199,7 +199,7 @@ (define-configuration fail2ban-jail-configuration
"Backend to use to detect changes in the @code{log-path}. The default is
'auto. To consult the defaults of the jail configuration, refer to the
@file{/etc/fail2ban/jail.conf} file of the @code{fail2ban} package."
-fail2ban-jail-configuration-serialize-backend)
+ fail2ban-jail-configuration-serialize-backend)
(max-retry
maybe-integer
"The number of failures before a host get banned
@@ -268,7 +268,7 @@ (define-configuration fail2ban-jail-configuration
maybe-symbol
"The encoding of the log files handled by the jail.
Possible values are: @code{'ascii}, @code{'utf-8} and @code{'auto}."
-fail2ban-jail-configuration-serialize-log-encoding)
+ fail2ban-jail-configuration-serialize-log-encoding)
(log-path
(list-of-strings '())
"The file names of the log files to be monitored.")
@@ -277,7 +277,8 @@ (define-configuration fail2ban-jail-configuration
"A list of @code{<fail2ban-jail-action-configuration>}.")
(extra-content
(text-config '())
- "Extra content for the jail configuration."
+ "Extra content for the jail configuration, provided as a list of file-like
+objects."
serialize-text-config)
(prefix fail2ban-jail-configuration-))
@@ -308,7 +309,8 @@ (define-configuration/no-serialization fail2ban-configuration
"Instances of @code{<fail2ban-jail-configuration>} explicitly provided.")
(extra-content
(text-config '())
- "Extra raw content to add to the end of the @file{jail.local} file."))
+ "Extra raw content to add to the end of the @file{jail.local} file,
+provided as a list of file-like objects."))
(define (serialize-fail2ban-configuration config)
(let* ((jails (fail2ban-configuration-jails config))
--8<---------------cut here---------------end--------------->8---
Ran the fail2ban system tests, and pushed!
Thank you.
Closing.
Maxim
prev parent reply other threads:[~2022-09-14 15:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-04 11:24 [bug#57575] [PATCH] gnu: fail2ban-service-type: Improve extra-content fields muradm
2022-09-14 15:32 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6720y65.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=57575-done@debbugs.gnu.org \
--cc=mail@muradm.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.