From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id GF6yLC5AJ2O8dgEAbAwnHQ (envelope-from ) for ; Sun, 18 Sep 2022 17:58:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id ih6qLC5AJ2PAXgEA9RJhRA (envelope-from ) for ; Sun, 18 Sep 2022 17:58:38 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8AD83B7DA for ; Sun, 18 Sep 2022 17:58:38 +0200 (CEST) Received: from localhost ([::1]:48950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZwgn-0006b5-Os for larch@yhetil.org; Sun, 18 Sep 2022 11:58:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57704) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZwgH-0006Zh-WF for guix-devel@gnu.org; Sun, 18 Sep 2022 11:58:06 -0400 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]:45955) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZwgG-0007ZT-It for guix-devel@gnu.org; Sun, 18 Sep 2022 11:58:05 -0400 Received: from localhost (unknown [134.157.22.165]) by mira.cbaines.net (Postfix) with ESMTPSA id 0EE7E27BBE9 for ; Sun, 18 Sep 2022 16:58:03 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 09b54f87 for ; Sun, 18 Sep 2022 15:58:01 +0000 (UTC) User-agent: mu4e 1.8.9; emacs 28.1 From: Christopher Baines To: guix-devel@gnu.org Subject: Notes from discussion on Quality Assurance from the 10 Years of Guix event Date: Sun, 18 Sep 2022 17:55:30 +0200 Message-ID: <87a66wfzeh.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1663516718; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=dOTTTJBjoaVYYeb8sH3q7gW6AF73rBi8MGuYuR9IkCg=; b=Q0mWEBO97DL84wkrArSDSFU4UGkuNkoZaN5OHuJM5X3ngrHKqlj2cXW64F4HF/cV/2b6Pf HHbIxsnZo+i1NkpmxckouNp0bu+aL5dvVuR/CSu05JoDNrjUyXgrZntt6muWJsEyZUFWMZ aJkQgsoTnQ08OUatZ4JND5HmdBhTOq0PHjhRhC9FmB/NR+7ZiuJWohqp4d+GSn8CRVkVTT ugqNu2HP963y4lv3+s3XfdXUkZ/CXuZ1yylA90EdChQueGkGlAca3eMnvH3HN590OGUtU8 HKqn0KRCb4hI1FY2pOBLlmfeWf/A2tDnwxGmGFSfz+toqyTkS4Erf/DGhFX4IQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1663516718; a=rsa-sha256; cv=none; b=PnMpKZcr4meaC4Ke9r45zlTtAYdVuWIAcnUONTRgprB+GPm9uycDQrUNvP36FcTwIAiCZM +RkjH3a/qqrSQUHB6o5/Hga9UJDj6IMlzQlUsih3cFlWoEhZHPwejfj1wVv1QzDqPzF3wo b6kdM2902q0KBXJVfbh8H43oy2igPUqE3r2CXLYS48FSPYwiyKOofDmbqucxcjcjkysOcn /7ymg4eWnHT4qdUhpwIjigPfT3YZrymj1XPY4gwKYiGvMi5KOwUNAqQA9NLgEW0XZBLmXW ec6fKV9wNVZ6JX3aM5DD35MQbcne1OiUFdObMTh0KfOg3rpHLiHy3HaIeXeWLw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.04 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8AD83B7DA X-Spam-Score: -4.04 X-Migadu-Scanner: scn0.migadu.com X-TUID: L3wRaRzBJuXL --=-=-= Content-Type: text/plain Here are some notes I took during the discussion on patch review/quality assurance at the 10 Years of Guix event. Discussion: - Find out how others review patches - Julian - Subscribe to guix-patches - Look at subjects - If not OCaml/Java/Maven, ignore email - If obvious issues can be seen, reply suggesting improvements - Run guix lint/build dependents - There are language/area specific things that are good to know about when reviewing patches - How the process works - How we can improve quality of Guix, avoid breakages - How we can simplify the workflow for reviewers - Minimise the burden for submitters - Lengthy guidance for submitting patches - Changelog format - Sending patches by email (git send-email) - guix lint archive error - Delay in feedback for first time submitters - Problems - Already broken packages when applying updates - How to help? - Motivation to do more - Debian: How can I help tool? - Learn how to review more patches - Doing useful things with little time Actions: - teams thing for finding out about patches, automate this somehow - generate a web page listing the people and teams - Filtered subscription to patches by team - Improve the qa.guix.gnu.org site - look at moving Mumi, QA Frontpage, ... on to Savannah - List infrastructure projects on a web page - More detailed guidance on the review process - Guidance for reviewers, e.g. don't ask for patch submitters to fix other problems - Split the guidance for submitting patches in to sections (bronze, silver, gold) - Give specific guidance for different tasks, so don't run lint if you're upgrading a package - Have some "trusted reviewer" status - Arrange focused time per month/week when people try to review patches - How should reviewers get patches merged when they don't have commit access? - Maybe script making contributions like updating packages - Make a similar tool to Debian's how can I help - Try to avoid suggesting updating packages with lots of dependencies - work out what is getting in the way of patches getting to the mailing list/debbugs - Put a warning about delays --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmMnQAdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xe0MhAAonyUhACXfVk16P2R14cq2j4zxt0j6R8e goQX10dcF8QzjFnwFO7Rp7Tzf14mfTxjaFhB5OSBWI1gB8F+ytS0jz0/qQD52aJD /VQ7Pm4h+RyBCkAiYXF1hWhL1CsooDgL0D4OvE1EdyAx8TyBsGG2yxh8KANgaDGJ yQJmg+ZOn+9QTJ2JHlJoTypBBU96nrCPRXBfFOLJZ7GTpAKJTueb9mMH2FiSWoBS lghaaIhkgR2t+AzK+8I8ffLadOdYuQypcVDRzpDsG4+5Nzt4Dyvy9bZOIb/DIaOu mVO36FaEnT0aLkq8CvvGTO51DP7pXCW37pvW+PDwQMn5kCkYDdjuxtm9RCR3ePLF qI5zPIFfbllq4XEfX5Zw8hmUOq8rTtWj2DscBfOmpfTCzQdoie4HHsNPX7WYvELj NcdnAmXJ8YcoC2yQrwrf0f3xagWuBjaCphoiZXT6f+FPcEut2bdlUKrazP0WXBGy TvJp1Snuv3zDPLzxvFNIMkxooOoH/YLdRcWnwAoCW3IwOT9l9F5TOFYSNY+AW1jb TlGmBL1eg3UeXkSBROp5OxIHdI9W9cgPSJRQZTMsJr+WNp0I/lEMt2lqMfWr4Iks ylbnqbfjjCPRLF0q2bvpkiha1MI0GZC8KVHlsL0NGcNnT7Lr4V69LJXsqUmxbKLE InMPuz1ltUg= =IpvB -----END PGP SIGNATURE----- --=-=-=--