From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id QB+gD+zrgWNK5wAAbAwnHQ (envelope-from ) for ; Sat, 26 Nov 2022 11:35:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id +BKqDuzrgWPnJAAAG6o9tA (envelope-from ) for ; Sat, 26 Nov 2022 11:35:24 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E8A1423940 for ; Sat, 26 Nov 2022 11:35:23 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oysWg-0001TF-1K; Sat, 26 Nov 2022 05:35:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oysWV-0001SR-Q8 for guix-patches@gnu.org; Sat, 26 Nov 2022 05:35:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oysWV-0001AI-AI for guix-patches@gnu.org; Sat, 26 Nov 2022 05:35:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oysWV-0004b1-6U for guix-patches@gnu.org; Sat, 26 Nov 2022 05:35:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59560] [PATCH v2 1/2] gnu: Add emacs-function-args. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 26 Nov 2022 10:35:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59560 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 59560@debbugs.gnu.org Cc: jgart@dismail.de X-Debbugs-Original-To: jgart via Guix-patches via X-Debbugs-Original-Cc: jgart , 59560@debbugs.gnu.org Received: via spool by 59560-submit@debbugs.gnu.org id=B59560.166945884917578 (code B ref 59560); Sat, 26 Nov 2022 10:35:03 +0000 Received: (at 59560) by debbugs.gnu.org; 26 Nov 2022 10:34:09 +0000 Received: from localhost ([127.0.0.1]:37903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oysVc-0004ZN-RE for submit@debbugs.gnu.org; Sat, 26 Nov 2022 05:34:09 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:42285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oysVa-0004Yi-Ts for 59560@debbugs.gnu.org; Sat, 26 Nov 2022 05:34:07 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 5D8911BF209; Sat, 26 Nov 2022 10:33:58 +0000 (UTC) From: Nicolas Goaziou References: <20221124210439.GB11819@dismail.de> <20221125061426.23015-1-jgart@dismail.de> Date: Sat, 26 Nov 2022 11:33:56 +0100 In-Reply-To: <20221125061426.23015-1-jgart@dismail.de> (jgart via Guix-patches via's message of "Fri, 25 Nov 2022 00:14:26 -0600") Message-ID: <87a64ec8dn.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1669458924; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=U+04RO33NK8xVGQ7EHyQ/NvWsKgrVt4uIz+DwduHjfk=; b=ldMgb0lL3kJhnOKNhElCNdiUrPyBOmiojkQJtDz1BGMTNOiox1Aa43ERsaRsrCtRQfOMyk GtNjZnP80rtuCfTlx29/pNbJN8XoF87C5zIknSKO0Hdi52vk2QD5g6Rf7Kr0TAC0yTs2b5 3eQnBCgqCxKeDTDSaEMIm50hfd+2ZSNAqtoGHx46Pa52wgNpBGd0bC44TKvibEBbjyxsXT vsE8Gvo7jJAa69tWddL637KaHgUEvHwT3hTQkJ0BAH51+zQrgWr+9FkLM+j5Ca0o0HL2LO HVVogYvBbIH7IxqjvSxKEZqRrI/+kG04PQ2zZv3EFAnETjeF4rYgpLWNvFbcYA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1669458924; a=rsa-sha256; cv=none; b=OErixG0ASmGs6+gqTW4UOyv022bXmsvSJ+yIb0xW89qO6F85cIwuzekavVdl9ykI4R0WPm Jkc46TpPfKeP4w5RQ/4FQWyLegbrZtRLSkrtSShWRwRXmDwCYos/UN1/a4Vq2L4gentXQg dbz6Z6ZVfQaHUbkIV53CtLpPQu3+EbUGMssQ+3zxska8Kh/hKkM5anqUyKSoUhd2bSxt2o 9OxdoUl26JRS2iMLz4bGHBnfcw6PubTxIMm03H0zXuE8+tc5X6lhmkDZ+hKSV4QP9LGNd2 5gHCIbVnnVaQleISV+jCUp8z/mxbL0P3mMmueJYyFXlXXqpl4Do5ycp3KqotQQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.07 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E8A1423940 X-Spam-Score: -3.07 X-Migadu-Scanner: scn1.migadu.com X-TUID: jjmlAT+X2bs4 Hello, jgart via Guix-patches via writes: > * gnu/packages/emacs-xyz.scm (emacs-function-args): New variable. Thank you. > + (sha256 > + (base32 > + "1vxrjy6k030hcbclblgcaaw7h6k17kl3n9zla08527525c0gma01")) > + (file-name (git-file-name name version)))) Nitpick: Usuallly the file-name field resides before sha256. > + (propagated-inputs (list emacs-ivy)) > + (build-system emacs-build-system) Other nitpick in the same vein: propagated-inputs usually come after build-system field. > + (description > +"GNU Emacs package for showing an inline arguments hint for the C/C++ > +function at point.") This is not a complete sentence. I would also add that the package extends C++ mode completion provided by CEDET. What about something like: Function-args shows inline arguments hints exactly where the C/C++ function call is, rather than in the minibuffer. It also extends C++ mode completion provided by CEDET. Could you send an updated patch? Regards, -- Nicolas Goaziou