all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: 59560@debbugs.gnu.org
Cc: jgart@dismail.de
Subject: [bug#59560] [PATCH v2 1/2] gnu: Add emacs-function-args.
Date: Sat, 26 Nov 2022 11:33:56 +0100	[thread overview]
Message-ID: <87a64ec8dn.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20221125061426.23015-1-jgart@dismail.de> (jgart via Guix-patches via's message of "Fri, 25 Nov 2022 00:14:26 -0600")

Hello,

jgart via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-function-args): New variable.

Thank you.

> +         (sha256
> +          (base32
> +           "1vxrjy6k030hcbclblgcaaw7h6k17kl3n9zla08527525c0gma01"))
> +         (file-name (git-file-name name version))))

Nitpick: Usuallly the file-name field resides before sha256.

> +      (propagated-inputs (list emacs-ivy))
> +      (build-system emacs-build-system)

Other nitpick in the same vein: propagated-inputs usually come after
build-system field.

> +      (description
> +"GNU Emacs package for showing an inline arguments hint for the C/C++
> +function at point.")

This is not a complete sentence. I would also add that the package
extends C++ mode completion provided by CEDET. What about something
like:

  Function-args shows inline arguments hints exactly where the C/C++
  function call is, rather than in the minibuffer. It also extends C++
  mode completion provided by CEDET.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou




  parent reply	other threads:[~2022-11-26 10:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-25  3:04 [bug#59560] [PATCH 1/2] gnu: Add emacs-function-args jgart via Guix-patches via
2022-11-25  3:06 ` jgart via Guix-patches via
2022-11-25  3:06   ` [bug#59560] [PATCH 2/2] gnu: emacs-lpy: Update to fa95b11 jgart via Guix-patches via
2022-11-25  6:14 ` [bug#59560] [PATCH v2 1/2] gnu: Add emacs-function-args jgart via Guix-patches via
2022-11-25  6:14   ` [bug#59560] [PATCH v2 2/2] gnu: emacs-lpy: Update to fa95b11 jgart via Guix-patches via
2022-11-26 10:35     ` Nicolas Goaziou
2022-11-26 10:33   ` Nicolas Goaziou [this message]
2023-04-04 18:59     ` bug#59560: [PATCH v2 1/2] gnu: Add emacs-function-args Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a64ec8dn.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=59560@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.