From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id aPnXIJXPiGNwqQAAbAwnHQ (envelope-from ) for ; Thu, 01 Dec 2022 17:00:21 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id qJTtIJXPiGPs0QAAauVa8A (envelope-from ) for ; Thu, 01 Dec 2022 17:00:21 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3A97613540 for ; Thu, 1 Dec 2022 17:00:21 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0lyw-0008SD-3c; Thu, 01 Dec 2022 11:00:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0lyn-0008Q0-7G for guix-patches@gnu.org; Thu, 01 Dec 2022 11:00:08 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0lyk-0004X5-5d for guix-patches@gnu.org; Thu, 01 Dec 2022 11:00:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p0lyj-0000bp-Tc for guix-patches@gnu.org; Thu, 01 Dec 2022 11:00:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#58123] [PATCH] gnu: services: docker: Add docker-container-service-type Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 01 Dec 2022 16:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58123 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?M=C3=A1ja_?= =?UTF-8?Q?Tom=C3=A1=C5=A1ek?= Cc: maximedevos@telenet.be, 58123@debbugs.gnu.org Received: via spool by 58123-submit@debbugs.gnu.org id=B58123.16699103742310 (code B ref 58123); Thu, 01 Dec 2022 16:00:01 +0000 Received: (at 58123) by debbugs.gnu.org; 1 Dec 2022 15:59:34 +0000 Received: from localhost ([127.0.0.1]:40487 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0lyI-0000bC-3R for submit@debbugs.gnu.org; Thu, 01 Dec 2022 10:59:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0lyG-0000b6-8R for 58123@debbugs.gnu.org; Thu, 01 Dec 2022 10:59:32 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0ly9-0004Nw-Dx; Thu, 01 Dec 2022 10:59:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=0NzDH75PQA6iSp1FK+MSOGBB+TByIg3lfUCDUAa5op8=; b=P+gIriUOF9ZqhpWFlvPR jSHz0KuQ3gvpGxZ3ngeKpCZfmfTkLS91HlJs25V1XBbPT0Jl10eULoaNo9Z7ayCVItbli7TZqxGTU phBD8jXXrgbvi8khn0pwJPdBQgDeMyIpgCeYMafOmnn1VSsYNh/Ges5YyePdAUWrh/cD3vYlRvalh MkON+e7kCCOIZ9/CgLGDJQCjSBYpqMOMNcmQ10kqFjB6bSrBRsZ5bbNTbtIPakGz69LnZjzrYmV4z gGfY7jebpXOM8vNkERP25+jqpqdxveG5AlbvjoFc9cimrz8wgHNY2ZPHoNXNtYiROHD42OY0h/22V TFXUWtpC8xan0A==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0ly8-0005AZ-UJ; Thu, 01 Dec 2022 10:59:25 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87czaygrt8.fsf@disroot.org> <87k053ri04.fsf@gnu.org> Date: Thu, 01 Dec 2022 16:59:22 +0100 In-Reply-To: <87k053ri04.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Thu, 13 Oct 2022 15:05:31 +0200") Message-ID: <87a647yv1h.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1669910421; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=0NzDH75PQA6iSp1FK+MSOGBB+TByIg3lfUCDUAa5op8=; b=SAm3U9saRqdkKQ5MkxpCapEM9kCmAlt9brRZxrB7KYYxigTwApbO/lr+PEW7eVNFUiLxzg BseB9dmKk0+X/r56HuOqh+Zo+31PU/DJ5XLoVQs7HmtpIaUNLf4ftUL65OIaEaJhz8H5Xn vkOjuFMotHnFKJikjT4ddOa5meemXhS3Wwf8k6UKH8d5DzQNhPLcb+cMxphyh/jWZE/3cA BuN6YgmYIcGuf8p9s6ZwvJPzCQ95yoWW9tvVFt1NQ6Ljtyr95rvSVgwmT88TAdziUXA3s/ +AX5QEOZqr35zqG1jlXrWSHrjWeUkXEKFFwk3KfiNnxTG0YUe4crZfVD+HmDYQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1669910421; a=rsa-sha256; cv=none; b=DIV7ZnKyftldKqTxW20WY5eA5Y90vtuMtSuya6J+mawp/eYgNXtKvB2NXCyzeIfT1E9wee voCoNa+8JCZtJdIlwJQrwdhI9+Qkep5Q7DXz86SrtC2KSzHQU9KQ8JI024FcsbpWdm6NEM gpNKVe1nP1oUzsbstPtDJNJ2pdlCgCOBTVCeJz5PUEUXqKMsFK3ZR4jAP1mSaqswe0SBWR q1QgM0i/lv8xB6QUvrwynMsGbWA8qzwZXQ09Uxf+wotViEV+gLshzzmQMXpq4mTEqq3Xwv JDxtkNTg5m5dtLittsIhOsh8rfoSF2kAMvzRDAl6msVmXqgXXEsS+7a+tVn+PA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=P+gIriUO; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.86 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=P+gIriUO; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3A97613540 X-Spam-Score: -3.86 X-Migadu-Scanner: scn1.migadu.com X-TUID: 4jvYOIYmqQFP Hi M=C3=A1ja, Did you have a chance to look into this? https://issues.guix.gnu.org/58123 Thanks in advance, Ludo=E2=80=99. Ludovic Court=C3=A8s skribis: > Hello, > > M=C3=A1ja Tom=C3=A1=C5=A1ek skribis: > >>> I would have two more asks: >>> >>> 1. Could you update doc/guix.texi to document the new service? You >>> can mostly use =E2=80=98generate-documentation=E2=80=99 to produce= the reference of >>> the configuration record, and then add a paragraph giving some >>> context and a documented example. >> >> Is that a command from make? I'm sorry I have never used it, I can >> update it if I can generate it :) > > =E2=80=98generate-documentation=E2=80=99 is a procedure in (gnu services = configuration): > > https://guix.gnu.org/manual/devel/en/html_node/Complex-Configurations.h= tml#index-generate_002ddocumentation > >>> 2. Could you add a test under (gnu tests *)? That would ensure the >>> service does not bitrot going forward. >> >> I'm not exactly sure what would that mean. Test that creates a container >> and then runs it or...? > > I guess the test would start the Shepherd service, ensure it=E2=80=99s ru= nning, > and attempt to talk to the running container one way or another. > > Does that make sense? > > Thanks, > Ludo=E2=80=99.