all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: 60201@debbugs.gnu.org
Subject: [bug#60201] [PATCH] gnu: Add libswell
Date: Mon, 02 Jan 2023 12:32:19 +0100	[thread overview]
Message-ID: <87a6315fwx.fsf@elephly.net> (raw)
In-Reply-To: <ChXlp6YIa5eQPVrAFeG2FC6o26Dc5gy7wqxPRhNRHBYQbA9_bSFj5eVJ54SNCY-PGGkKddEU6il-w16cEoGvT2mV_B3pyxlGo6yMrwzy0H8=@proton.me>

Hi,

thank you for the patch!

Could you add a comment why tests are disabled?

I recommend using a gexp for the phases:

  (arguments
    (list
      ;; There are no tests.
      #:tests? #false
      #:phases
      #~(modify-phases … )))

Then you can use #$output instead of binding the ‘outputs’ keyword
argument and looking up the output with label ‘out’.

Is it really enough to just install the .so?  Shouldn’t the headers also
be installed?

Why are origin and commit separated as a global definition? That seems
unnecessary.

-- 
Ricardo




  parent reply	other threads:[~2023-01-02 11:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-19 13:49 [bug#60201] [PATCH] gnu: Add libswell Sughosha via Guix-patches via
2022-12-19 14:04 ` [bug#60201] [PATCH v2] gnu: libswell: align properly Sughosha via Guix-patches via
2022-12-19 18:16 ` [bug#60201] [PATCH v3] gnu/packages/wdl.scm: Remove unused module Sughosha via Guix-patches via
2022-12-22 18:08 ` [bug#60201] [PATCH v4] gnu: libswell: Modify inputs Sughosha via Guix-patches via
2022-12-22 19:08 ` [bug#60201] [PATCH v5] gnu: libswell: Lint and fix mistakes Sughosha via Guix-patches via
2022-12-30 17:33 ` [bug#60201] [PATCH v6] gnu/local.mk: Register wdl.scm Sughosha via Guix-patches via
2022-12-30 18:16 ` [bug#60201] [PATCH v7] gnu: Add libswell Sughosha via Guix-patches via
2023-01-02 11:32 ` Ricardo Wurmus [this message]
2023-01-03 22:09 ` [bug#60201] [PATCH v8] gnu: Add wdl Sughosha via Guix-patches via
2023-01-03 23:15 ` [bug#60201] [PATCH v9] " Sughosha via Guix-patches via
2023-01-04 10:23 ` bug#60201: [PATCH] gnu: Add libswell Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6315fwx.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=60201@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.