From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id mNR5LZmqtGMbsAAAbAwnHQ (envelope-from ) for ; Tue, 03 Jan 2023 23:22:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id YCV1LZmqtGPpaAEAauVa8A (envelope-from ) for ; Tue, 03 Jan 2023 23:22:17 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7D28DC2E7 for ; Tue, 3 Jan 2023 23:22:17 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pCpfY-00051G-2t; Tue, 03 Jan 2023 17:22:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCpfW-00050k-Ne for guix-patches@gnu.org; Tue, 03 Jan 2023 17:22:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pCpfW-0007Ll-Cr for guix-patches@gnu.org; Tue, 03 Jan 2023 17:22:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pCpfV-0007mD-U8 for guix-patches@gnu.org; Tue, 03 Jan 2023 17:22:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#57375] [PATCH] gnu: fix cups 'install-cups-filters-symlinks phase Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 03 Jan 2023 22:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57375 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Grigory Shepelev Cc: 57375@debbugs.gnu.org, Mathieu Othacehe Received: via spool by 57375-submit@debbugs.gnu.org id=B57375.167278449229842 (code B ref 57375); Tue, 03 Jan 2023 22:22:01 +0000 Received: (at 57375) by debbugs.gnu.org; 3 Jan 2023 22:21:32 +0000 Received: from localhost ([127.0.0.1]:46962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCpf2-0007lG-FA for submit@debbugs.gnu.org; Tue, 03 Jan 2023 17:21:32 -0500 Received: from mail-qt1-f170.google.com ([209.85.160.170]:43599) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCpf0-0007l0-HP for 57375@debbugs.gnu.org; Tue, 03 Jan 2023 17:21:31 -0500 Received: by mail-qt1-f170.google.com with SMTP id a16so25711427qtw.10 for <57375@debbugs.gnu.org>; Tue, 03 Jan 2023 14:21:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=z+pwRejtVfgGZf0JyDZieq1NlErJOOSkfv031G/eSJ4=; b=IiOkqgFOI1xzhEfwuCadLgMtR6NvaW/9xkGNuUazzFA/IJdomFQLr51sgcFiDHTmVZ VK5B8maj/4XMBDVOmz3trp5QdxMaZns4lRAEPuEym/8qtvRP39+OFNQ7YaNzi3DbbkjY v/CzNmzDOju6V9hNLyzoBIqADM5Qf6ordI2rZH67haNBj70psj66+pGA97MdS9UCwIWF MmeA3f+wQXEPCsywt7ZVYCHTMq/XvP8UG6cND57ttXWmalW3vyTe/kjsnXaNfSrJdajM F/AjhUhcKRxYxHpEjynRXeigcDyzJ8bKB8KZYUmaszHKZ2avhEI6oPMPhd8WlY3GfNpr P0NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=z+pwRejtVfgGZf0JyDZieq1NlErJOOSkfv031G/eSJ4=; b=jOn6ZVhTd7BnpyjkgmjGCM5jH76bLtu5dtfG0MIw1iCfUAtgw6ZVYdV2ddEGRokMJK SZvJEPaXGeiUDtMBLDuYvJGGMJLOiMK2D/D3C8S542ZApG6UDqRzpx8KYFhFrEm++qw5 XdgJkFqWmkAPyyf9JF6DnmH6M+ZwKVzTmkojPWXAKwA4DHnmG3Q7/zIF5QEq03ZKorXQ s3y0kMh8xbSDj5j9Bq9oQbBiD4WAdeGqEwRL1ZcGmhKHJ4/dfwHRfpBBjjwtrYW0Gnun 6UWM0lPY1q1Fs6gtBrd86fTnlG70kIdXV9pYnxBvF+J8cUL8725vO4jaskqeim/Wgfg2 Ajaw== X-Gm-Message-State: AFqh2krAhyX4igdIXbMBigH1wxKRMK6B19YbuTZ3K/NwK4vWPUbLgSG1 KjdsnDtnBHp9e+8pYR6Qj4gprtV/zPmkV8E3 X-Google-Smtp-Source: AMrXdXsHVzagoURvKj9g7Qas8zdW3mOrnQQey87T7L911/HDMeuB+VZpUXEfYdFFsMOYQgE7s1/OdQ== X-Received: by 2002:a05:622a:1927:b0:3a7:ec54:cfa2 with SMTP id w39-20020a05622a192700b003a7ec54cfa2mr62965124qtc.56.1672784484932; Tue, 03 Jan 2023 14:21:24 -0800 (PST) Received: from hurd (dsl-10-135-221.b2b2c.ca. [72.10.135.221]) by smtp.gmail.com with ESMTPSA id c7-20020a05620a268700b006fca1691425sm7617486qkp.63.2023.01.03.14.21.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jan 2023 14:21:24 -0800 (PST) From: Maxim Cournoyer References: <99c00ae2-d938-1b56-ef67-2bbfb4d38797@gmail.com> <87zgfrxfn8.fsf@gnu.org> Date: Tue, 03 Jan 2023 17:21:23 -0500 In-Reply-To: <87zgfrxfn8.fsf@gnu.org> (Mathieu Othacehe's message of "Fri, 26 Aug 2022 16:07:07 +0200") Message-ID: <87a62zz2cc.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1672784537; a=rsa-sha256; cv=none; b=DWZK1+Ytxbvlpp/8hK/Cco6f7bmjMHjjar7y1dnNk9Swh/rRtvKnOXzHAGBedOKkvnVCSD W9VfilMUeE0wdqTfNLoLKrWzNLcPTXJehjpCYvxFsoa7u0KuH9ozc3dB8fdNNRy/oyQZwX BjukOSySxSqf2DUNasmYGNBCq0wenDmOC/WIryG3za6sYdPKLgXO+kRF31pXUrS3am/o52 uuCOjr4oWwL3lZZ+YujRNcbhk/An6LjREMOELnTS6nziwDdu+ENdaXniRJcVTPPSEcfUTg wu/xps+IGDFgLbK9AS40caDUIP9xMBY0Bo8hvjHe+uZXnbBFiPRPPJT/yetLyA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=IiOkqgFO; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1672784537; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=z+pwRejtVfgGZf0JyDZieq1NlErJOOSkfv031G/eSJ4=; b=MSd0GKKqGcX+hzg5u7G4MF8iBKrCRMZMBg6evm8SsQ2f/y59IKDRJujTZFqstpBLl6gl2k J9uTbSbgEnkoH0a2Q/iw1ev5Z2sYocQKe9aqrRPHVdjW8zfUz5KI95JbkRV2TTYULDhZa5 IjCZ2kdAVA/3dmrs4pI/Gmzt6pC03+FSjn0f0/B/EumG19KDg1H732qvzaX6fjv3j+KOE7 NmLSxwCXLRjZmC87g9ydnZUs1erb/41Tjn7synwiwPh0ERTOrsFcYpZJKreNyIZil3d0Dl ItAEUDJV/dXhuufHLJXHWUbJ6xn67i5fSGdkOwmpQCWw7buidx75bA9sE4U1vA== X-Spam-Score: -2.76 X-Migadu-Queue-Id: 7D28DC2E7 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=IiOkqgFO; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -2.76 X-TUID: mWUxRVtv4LUb Hi Grigory, Mathieu Othacehe writes: > Hey Grigory, > >> (symlink f >> - (string-append out "/lib/cups/filter" >> + (string-append out "/lib/cups/filter/" >> (basename f)))) >> (find-files (string-append cups-filters "/lib/cups/filter"))) > > Thanks for this first contribution! This fix looks fine. > > However, the cups package has a lot of dependants (as shown by guix > refresh -l cups). This patch should target core-updates. On that branch, > the package definition has been a bit reworked. Do you think you could > rebase your patch on top of that branch and check that it still works > fine? > > Another point, you should write a commit message using the ChangeLog > format. You can find more information here: > https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html. > > You should also use the "git format-patch" command to preserve the > commit data such as author, commit message and so on. > > Don't hesitate to ask for help if needed. Friendly ping :-) -- Thanks, Maxim