From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id KJWGJaxQQmTP0AAASxT56A (envelope-from ) for ; Fri, 21 Apr 2023 11:00:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id gPNmJaxQQmR/MAEAauVa8A (envelope-from ) for ; Fri, 21 Apr 2023 11:00:28 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 78C65551E for ; Fri, 21 Apr 2023 11:00:28 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1682067628; a=rsa-sha256; cv=none; b=uEd0r9gL7bjllPxpsBvv2NVykz7FJ+7GCrq8yK7/jjkE0tteDRl80CLJZAz2fA48RHB8vS echdhCiYQzqKncby/+h1gFLjoLlGfzzpCNQm5fL1WbmfltV8H+LjGg61+Kn/7+91phvSdX bKiSFVYr1xGZg2kQrBzMCslu1OSw8lbqb5OOOzlsK3Wl7TVltiDqcZzTKEu6veHEvmR8jT 360OwB4OD8DIBamhEOxbMQcHY4SsF8qpKqe1cnNvgbpV5CpBd5AJ1Tm3F9QuwWFLsVRep4 b4XQ9OzpeDS5JjY7TSzFRvBm0MvL+gf2IKf2dfzxCbMBtfjqoDw0Pasp2/rDgA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1682067628; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=PXdJXXGGYhXxxekWuyIRJpK0FhmfG4cmfnd6mgPfpCA=; b=S9zlXWJi4lpbxSsT2OkqjsIfpe6z+or5Yr0xRQrnCdusbbW6+ZkteqitxdbB91CBIBQsNW YFVc0yDHlBL21Hlhx0/kJLdhtdn8OYIKSTWrmUoj3APGFs5sQU9oy4MY1yyI4lupZNgS5g vEs1fM+xgk6lL1sL4BLiIESt8hiGIvc750TnXpC9dhLg0YfgFrlIXFltgbXfsZstQgN9WE oAhND856bsp//EhJZ89cVe6OoQiUHfj+/6R7aKVi/w5GEWFGfomYeUGmLQQtXe2ZxRfdny Oh7m1Ml1SyiIQKDkBzZui3qUq0A3/p4MrmlDDdaz+QnGUZKbwPXUABXw8YkciA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ppmch-0002Nu-1Y; Fri, 21 Apr 2023 05:00:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppmce-0002Ek-3K for guix-patches@gnu.org; Fri, 21 Apr 2023 05:00:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ppmcd-0005B3-Gt for guix-patches@gnu.org; Fri, 21 Apr 2023 05:00:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ppmcd-0001hl-2A for guix-patches@gnu.org; Fri, 21 Apr 2023 05:00:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62550] [PATCH v2] gnu: Add alienblaster. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 21 Apr 2023 09:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62550 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 62550@debbugs.gnu.org Cc: 62550-done@debbugs.gnu.org, mirai@makinata.eu, Yovan Naumovski X-Debbugs-Original-To: Yovan Naumovski via Guix-patches via Received: via spool by submit@debbugs.gnu.org id=B.16820675796467 (code B ref -1); Fri, 21 Apr 2023 09:00:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Apr 2023 08:59:39 +0000 Received: from localhost ([127.0.0.1]:39259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppmcF-0001g9-9o for submit@debbugs.gnu.org; Fri, 21 Apr 2023 04:59:39 -0400 Received: from lists.gnu.org ([209.51.188.17]:39542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppmcD-0001g0-P3 for submit@debbugs.gnu.org; Fri, 21 Apr 2023 04:59:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppmcD-0001PW-9b for guix-patches@gnu.org; Fri, 21 Apr 2023 04:59:37 -0400 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppmcB-00057n-1B for guix-patches@gnu.org; Fri, 21 Apr 2023 04:59:36 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 6A242E0007; Fri, 21 Apr 2023 08:59:28 +0000 (UTC) From: Nicolas Goaziou References: <20230330192629.31655-1-yovan@gorski.stream> <20230331160346.25800-1-yovan@gorski.stream> Date: Fri, 21 Apr 2023 10:59:27 +0200 In-Reply-To: <20230331160346.25800-1-yovan@gorski.stream> (Yovan Naumovski via Guix-patches via's message of "Fri, 31 Mar 2023 19:03:46 +0300") Message-ID: <87a5z1626o.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2001:4b98:dc4:8::224; envelope-from=mail@nicolasgoaziou.fr; helo=relay4-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: UNKNOWN X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.06 X-Spam-Score: -2.06 X-Migadu-Queue-Id: 78C65551E X-Migadu-Scanner: in3.migadu.com X-TUID: WjnTLxaDbVEd Hello, Yovan Naumovski via Guix-patches via writes: > * gnu/packages/games.scm (alienblaster): New variable. Thank you. I applied your patch with the following changes. > + (uri (string-append "http://www.schwardtnet.de/alienblaster/archi= ves/" > + name "-" version ".tgz")) I replaced name with alienblaster. > + (sha256 > + (base32 > + "104rfsfsv446n4y52p5zw9h8mhgjyrbca8fpyhnxkkasq141a264")))) > + (build-system gnu-build-system) > + (inputs (list sdl sdl-mixer)) Nitpick: I moved inputs after arguments=E2=80=A6 out of habit. > + (arguments > + (list > + #:tests? #f ; no tests > + #:phases > + #~(modify-phases %standard-phases > + (add-after 'unpack 'fix-sdl-paths > + (lambda _ > + (let ((share (string-append #$output "/share"))) > + ;; fix name and append path to SDL_mixer.h Nitpick: I used proper capitalization and typography (missing final full stop). > + (substitute* "src/Makefile" > + (("GAME_NAME=3DalienBlaster") > + "GAME_NAME=3Dalienblaster") > + (("SDL_FLAGS=3D\\$\\(shell sdl-config --cflags\\)" lin= e) > + (string-append line " -I" #$sdl-mixer "/include/SDL")= )) I replace #$sdl-mixer with #$(this-package-inputs "sdl-mixer") for compatibility with package transformations. > + ;; substitute relative paths in .cfg and source/header f= iles Nitpick: Here too, I slightly reformatted the comment. > + (substitute* (find-files "./cfg") > + (("(\\./)?images") (string-append share "/images"))) > + (substitute* (list "src/global.h" "src/global.cc") > + (("./images") (string-append share "/images")) > + (("./sound") (string-append share "/sound")) > + (("./cfg") (string-append share "/cfg")))))) > + > + (delete 'configure) > + > + (replace 'install > + (lambda _ > + (let ((bin (string-append #$output "/bin"))) > + (install-file "alienblaster" bin) > + (for-each > + (lambda (dir) > + (copy-recursively dir (string-append #$output "/share= /" dir))) > + '("images" "sound" "cfg"))) > + #t))))) I removed the trailing #T, which is not necessary in new package style. Regards, --=20 Nicolas Goaziou