From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id cDa7G/Rdi2QI1gAASxT56A (envelope-from ) for ; Thu, 15 Jun 2023 20:52:36 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id aFeTG/Rdi2SkUgAAauVa8A (envelope-from ) for ; Thu, 15 Jun 2023 20:52:36 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8EFBBB2BF for ; Thu, 15 Jun 2023 20:52:35 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=bbGgnrzC; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}") ARC-Seal: i=2; s=key1; d=yhetil.org; t=1686855156; a=rsa-sha256; cv=fail; b=Qq0IcL0YK/khR2wvkEDlIhjdAd3TBVtVryovL2VsxC0igbHHIzTHYBbl/V4mQkW96yCN3G qf1n3hDb4aZyzAMC5hg9peZ6BVdiZOarwJ/oRmmOFlti6phT4u+Ojau7WwWFU6LtFvsD81 lIX+08SGG22fp2qXFfebinXLhO31E4tI2PpN0ja3VdADExHFhE9ciYHL4E1OkTAZSNfoJW Qr/m6FgmT/QncSFvR/SlebJ0mgwnZDShiz8EdviXFvXUk1xFpapXrAtWEY6w3VZYStcoEN J8c9rIG+b4QgAvFKJly8MU08M/KMYrlZ8Ady14k/TsJE9qsmPy3H6uNr2PzpCA== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=bbGgnrzC; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1686855156; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=eNC3gQ3wbnvCJJedJivrxYQq1Wkeuwavy3azKWu/e7s=; b=Zg0oZGFFI21f7aQTPprk0XMpKTk2tY+PTcPzaLaF8MWm1w3oWQksZhmTCpeHLRuVQ0jrya S3ZGbt1jdGbA4b0tvtRvlHbVwZWTaOgBEmi8WR4s9FzrXKtqy3Bxns2nwKX0QS7Y8vjVFc d+JTvNiRq5BBH1DQchvBZAckHeUEEwUKdn/Z8NoLDcBVRhRE6ZA2ddd6P2hvWTaCfj3yNE CrE3K1zKzz8xIG4rHn11InFEAWo2IgJrXtpqfyE3jzOUQNYFp85gCRta4KSagxOIRUIVs2 IrKSA0uUpH9BcYMEQDT0xwesBCYO6GmyfnMotwUTDm4SmXI8Fsf+CLoUJFcuAA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q9s4y-0007cL-Fc; Thu, 15 Jun 2023 14:52:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9s4l-0007bn-LF for guix-patches@gnu.org; Thu, 15 Jun 2023 14:52:07 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q9s4g-00079W-Sx for guix-patches@gnu.org; Thu, 15 Jun 2023 14:52:07 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q9s4g-0007gN-Iz for guix-patches@gnu.org; Thu, 15 Jun 2023 14:52:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56140] [Patch v2 2/2]: gnu: Add distrho-ports. Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 15 Jun 2023 18:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56140 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sughosha Cc: 56140@debbugs.gnu.org, "alice.brenon@ens-lyon.fr" Received: via spool by 56140-submit@debbugs.gnu.org id=B56140.168685506729439 (code B ref 56140); Thu, 15 Jun 2023 18:52:02 +0000 Received: (at 56140) by debbugs.gnu.org; 15 Jun 2023 18:51:07 +0000 Received: from localhost ([127.0.0.1]:47922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9s3m-0007eh-Jl for submit@debbugs.gnu.org; Thu, 15 Jun 2023 14:51:07 -0400 Received: from sender3-of-o59.zoho.com ([136.143.184.59]:21937) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9s3j-0007eW-S1 for 56140@debbugs.gnu.org; Thu, 15 Jun 2023 14:51:05 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1686855061; cv=none; d=zohomail.com; s=zohoarc; b=OyT4dim59hInB2r1YPO9iWmPCj46vWCfKLtb1AxZ9xgmYWDiwOn5FCnffhb1F2HDleLoAM6G77VeR/eef7BIpWSgzAvmzdXkAREDCI061cmLL6g2hECd5tQVWoFsEO1OEZhzi2vphEsPVm+nvvaGzoKt+2kND6kBV1J4/BG6FPk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1686855061; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=eNC3gQ3wbnvCJJedJivrxYQq1Wkeuwavy3azKWu/e7s=; b=mRsTISaBrXKZMmDsJAULgLOKuhPP2ti+YUuKrcC+bZopJUusflDnvoufoRCujhz4IhXS09Rh5roqiOzKB991EMCZjE3GT2Jmeh9KNFlroMRPOZBIaWmHGtSa4MOfm3bpz/XvMfyvJrq7VfGC8RPsa1dyfqfRSMn5Aa4xghPMlM8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1686855061; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=eNC3gQ3wbnvCJJedJivrxYQq1Wkeuwavy3azKWu/e7s=; b=bbGgnrzCfDnvCczEgv2LNOuWr491+6Mk1eKzf8WiSZLrsfWSchmyLCPEZ9Lmgn3C b24w3JPvMWHtVWFYH6Kuyys+bW6DgObyyUI1OAVaoTNehVI/IK1Guw8fyeb0k6m7tDk Ohjoq4VyArL7JIscmUSsWNYLZL6hJZ2kWwnPFB6I= Received: from localhost (231-108-142-46.pool.kielnet.net [46.142.108.231]) by mx.zohomail.com with SMTPS id 1686855059421715.2680827653044; Thu, 15 Jun 2023 11:50:59 -0700 (PDT) References: User-agent: mu4e 1.10.2; emacs 28.2 From: Ricardo Wurmus Date: Thu, 15 Jun 2023 20:38:56 +0200 In-reply-to: Message-ID: <87a5x0mueo.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: 0.27 X-Migadu-Queue-Id: 8EFBBB2BF X-Spam-Score: 0.27 X-TUID: 9r3R2owIjt/Z Hi Sughosha, > * gnu/packages/music.scm (distrho-ports): New variable. Thanks for the patch! > +(define-public distrho-ports > + (let ((commit "f2dbaded0a05732e3499fa374a586e5b32370da5") > + (revision "0")) > + (package > + (name "distrho-ports") > + (version (git-version "0.2021-03-15" revision commit)) > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/DISTRHO/DISTRHO-Ports") > + ;; This commit corresponds to tag 2021-03-15 As far as I can tell the commit corresponding to the tag is actually fe5bf2e87dd440ba98d3e8ac647b8518e2851f74. > + (snippet > + '(with-directory-excursion "ports-juce6" > + ;; Delete third party libraries. > + (for-each delete-file-recursively > + (list "swankyamp/thirdparty" > + "vitalium/third_party")) > + ;; Exclude them from building. > + (substitute* > + (list "swankyamp/meson.build" > + "vitalium/meson.build") It=E2=80=99s nitpicking, but we seem to prefer a quoted list for substitute= *. > + #~(modify-phases %standard-phases > + (add-after 'unpack 'patch-paths > + (lambda* (#:key inputs #:allow-other-keys) > + (with-directory-excursion "libs" > + (for-each > + (lambda (dir) > + (substitute* > + (string-append dir "/source/modules/juce_gra= phics" > + "/native/juce_linux_Fonts.cpp= ") > + (("/usr/share/fonts") > + (search-input-directory inputs "/etc/fonts= ")))) > + (list "juce5" "juce6" "juce7")))))))) I=E2=80=99d prefer something like this: --8<---------------cut here---------------start------------->8--- #~(modify-phases %standard-phases (add-after 'unpack 'patch-paths (lambda* (#:key inputs #:allow-other-keys) (let ((fonts (search-input-directory inputs "/etc/fonts"))) (with-directory-excursion "libs" (substitute* (find-files "." "juce_linux_Fonts.cpp$") (("/usr/share/fonts") fonts))))))) --8<---------------cut here---------------end--------------->8--- More generally, I think we should not use for-each since we already have a way to pass multiple files to substitute*. > + (native-inputs > + (list cmake-minimal > + concurrentqueue > + nlohmann-json > + optional-lite > + pkg-config)) Why are these libraries native inputs? > + ;; Licenses for lv2-ttl-generator, The Function, The Pilgrim, > + ;; juce-demo-host and juce-demo-plugin are not declared. Then these are nonfree and should be removed. You could report this to the maintainers and include a link to the issue here, so we can follow up in the future. > + (license > + (list license:asl2.0 ;for msfa > + license:bsd-2 ;for mingw-std-threads and dsp-utility > + ;; There is no mention of licenses for dRowAudio plugins, > + ;; Luftikus, PitchedDelay and ReFine in this repository, b= ut the > + ;; upstream repositories released them under MIT: > + ;; https://github.com/drowaudio/drowaudio; > + ;; https://github.com/lkjbdsp/lkjb-plugins. > + license:expat ;for FFTConvolver > + (license:fsf-free ;for Temper > + "file:///ports-juce5/temper/source/TemperDsp.hpp") > + license:gpl2 ;for juce-plugin, LUFS Meter and Obxd > + ;; There is no mention of license for Wolpertinger, but the > + ;; upstream released it under GPLv2+: > + ;; https://github.com/jkroll20/wolpertinger. > + license:gpl2+ ;for HiReSam, TAL plugins and Vex > + ;; There is no mention of license for EasySSP in this repo= sitory, > + ;; but the upstream repository released it under GPLv3: > + ;; https://github.com/automatl/audio-dsp-multi-visualize. > + license:gpl3 ;for JUCE and CHOW The release notes for 2021-03-15 say: CHOW has been removed from plugins to build and install > + license:gpl3+ ;for Dexed, Swanky Amp, Vitalium and KlangFa= lter > + license:lgpl2.0+ ;for DrumSynth, EQinox > + license:lgpl3+ > + license:lgpl2.1+ ;for juce-opl > + (license:non-copyleft ;kiss_fft > + (string-append "file:///ports-juce5/stereosourceseparati= on" > + "/source/kiss_fft/kiss_fft.c")) > + license:wtfpl2))))) ;for FFTReal Phew, that=E2=80=99s a lot. I haven=E2=80=99t validated any of them. Some= one should do this before applying this patch. --=20 Ricardo