From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id +OSTDI5jSmU0pAAA9RJhRA:P1 (envelope-from ) for ; Tue, 07 Nov 2023 17:19:26 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id +OSTDI5jSmU0pAAA9RJhRA (envelope-from ) for ; Tue, 07 Nov 2023 17:19:26 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AF3B55B521 for ; Tue, 7 Nov 2023 17:18:59 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=N3phjwIg; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1699373939; a=rsa-sha256; cv=none; b=L8BFPXoZ+yoJPveNATbuCRQM3LpyRAkfBgBYGbT6h9ENfZ6lZWwi3QJK91BAdsjsQ2Ejmf 9kOUY3TueviY59ULbwCh8kG/ptDKKrQ+cqVOJ9diGinAawVz4vJSmiFxTM4BeosrpXp06r m2iAH9vFGqvGPO+ECJFTwWyF3vTjPBQ02j07y9nG+vRg0BAzJVE8UldadBT99sBoUnisPM PpME/LbIEtVjc8vGACQHrtC3ifzCURXpia5WYjEWNKP6mKF0QAZsRI8foT5YE/fTvuhUjx Z2oxswTw3L7+y7xqSbhr4snXiyZ0fa0MzABK6QrllejkREgNJrXeZ/7AveN/6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1699373939; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=PpcLd2JkAbT8iRSZ+9EjVLe6XWCu3T2ftB880KMiRlk=; b=fnLiZuMYeS3VvXMCmvTAnTr4m+vTLocaquMJVfnshJGs4OiI+gW6ud6Pb6WKDOCS4WfBLK Syb7Lf21lkXszw/RFCo6lx7rDyu/6XtqCCzbqsOzpISULmwgWiTI8nayYDeaWVjohMzWj6 U0X1tz7FyQb4mV4eLKMWfULjvn5/71esuWLdhtKcmkwnXU6Juowa9EdWHLUpbzO+zZ+e4t IrZkySHm25haRq4lnwfVS5Yp97w+4He5A0gelkwAANJU9djA7wAB4kEtf6INYCu883/w0q QR/oKtCUymJUu5fmAn+fDXPokskRXAGRCzVcJPXxZlZJQ0rJ/LYtX8jzrSftWQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=N3phjwIg; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0Omj-00032l-4p; Tue, 07 Nov 2023 11:18:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0OmX-0002jL-OJ for guix-patches@gnu.org; Tue, 07 Nov 2023 11:18:26 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r0OmW-0005nW-SZ for guix-patches@gnu.org; Tue, 07 Nov 2023 11:18:25 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r0On8-0003S4-S7 for guix-patches@gnu.org; Tue, 07 Nov 2023 11:19:02 -0500 Subject: bug#66475: [PATCH v2 1/4] git-download: Add support for Git Large File Storage (LFS). Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Tue, 07 Nov 2023 16:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 66475 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , Christopher Baines , 66475-done@debbugs.gnu.org Mail-Followup-To: 66475@debbugs.gnu.org, maxim.cournoyer@gmail.com, maxim.cournoyer@gmail.com Received: via spool by 66475-done@debbugs.gnu.org id=D66475.169937391713227 (code D ref 66475); Tue, 07 Nov 2023 16:19:02 +0000 Received: (at 66475-done) by debbugs.gnu.org; 7 Nov 2023 16:18:37 +0000 Received: from localhost ([127.0.0.1]:43091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r0Omj-0003RG-GY for submit@debbugs.gnu.org; Tue, 07 Nov 2023 11:18:37 -0500 Received: from mail-qk1-x735.google.com ([2607:f8b0:4864:20::735]:51474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r0Omh-0003R1-S7 for 66475-done@debbugs.gnu.org; Tue, 07 Nov 2023 11:18:36 -0500 Received: by mail-qk1-x735.google.com with SMTP id af79cd13be357-77891c236fcso409543485a.3 for <66475-done@debbugs.gnu.org>; Tue, 07 Nov 2023 08:17:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699373872; x=1699978672; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PpcLd2JkAbT8iRSZ+9EjVLe6XWCu3T2ftB880KMiRlk=; b=N3phjwIgWeuHc/Z/qSahZRNqEURiaCfVMjfwDYaq4IwkyfoIfy9yWYd7SWBuSa4Xff 1zveDCUEK5IWGsvWn5F0A6J6ktB8GpKM4D6mlnVVGFIyE7e3U01vDPSOrszfT7Mur0o2 IUPvseuEnfK3hadeG8rgpMuxae5Lr5gmG1Ky4xFF2chrB4oCWc76kN9xhr0hB6AmtFSj 6mAu4ybgpPjvpMuLaSBC+4Yd9MfcPKpH7LkF0Rrfdxz5RnzSk5V8696W3IcHXMvD+vXi a+N42gXJ0vM/mHYQ+Lm2m1H2wQf5WcCein5Laa1rs1Bv2xw3uRL5ICFR6Y3qX9FmZaMp Y1WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699373872; x=1699978672; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PpcLd2JkAbT8iRSZ+9EjVLe6XWCu3T2ftB880KMiRlk=; b=d/i0CXB6ewpeRK56GrOAG9J1OGpvq98WXbL3lwAtBDQdSIqwXeN0occi6kZPlBSNQ6 uphJDp8lIS7gszrTVlmEJKQxz3xTLnxn8u9VGXBHSGeIn8PeXwh2utF5HK1V0cDGM1qk Ha3JI7wCLzQRVB4l+oYmjJsCutAwtxciEgHwxZ9O/EZCX2aJIqQ4a6XNFEleHrAM1R2q ITX4iS4ZrBOxdQb5cx14B70pEkHikXzfOL0rZKlJUErcUY1BQllh9FaAJPYXvMnXgv5Y Gv8b1ixqTugeeybn9UST2gUkTM40e5PSOr4PZjKyOhXsdKYpTwA87KW1pLzGDAJlO4ge 0G4g== X-Gm-Message-State: AOJu0YzfF1um3cgXoNTCPIcRJTsKq6+DA9pFdU5YE/zxScBgB5ldMJrV z3GEJkmhp2l3iOcT6+4DiAI= X-Google-Smtp-Source: AGHT+IHhcu1ANsEv4PdykQ/PbP/OR1MluMlQ4Wi8Eb8tiODtf889StpmzQvyMIFancwX2lMUyvs5xw== X-Received: by 2002:ad4:4ee5:0:b0:66f:bb58:c150 with SMTP id dv5-20020ad44ee5000000b0066fbb58c150mr41106503qvb.56.1699373872286; Tue, 07 Nov 2023 08:17:52 -0800 (PST) Received: from hurd (dsl-10-130-87.b2b2c.ca. [72.10.130.87]) by smtp.gmail.com with ESMTPSA id w1-20020a0cc701000000b006713142482fsm29283qvi.74.2023.11.07.08.17.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Nov 2023 08:17:51 -0800 (PST) From: Maxim Cournoyer In-Reply-To: <87jzqw1cio.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sun, 05 Nov 2023 15:49:03 +0100") References: <87jzqw1cio.fsf@gnu.org> Date: Tue, 07 Nov 2023 11:17:50 -0500 Message-ID: <87a5rpk05t.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: 4.39 X-Migadu-Queue-Id: AF3B55B521 X-Migadu-Spam-Score: 4.39 X-TUID: 8X0Iitgh1+Q6 Hi, Ludovic Court=C3=A8s writes: > Hi Maxim, > > Maxim Cournoyer skribis: > >> * guix/build/git.scm (git-fetch) [lfs?]: New argument, doc and setup cod= e. >> (git-fetch-with-fallback) [lfs?]: New argument. Pass it to git-fetch. >> * guix/git-download.scm (git-lfs-package): New procedure. >> (git-fetch/in-band*): New procedure, made of the logic of git-fetch/in-b= and, >> with new git-lfs specifics, with the following changes: >> New #:git-lfs argument. >> : Remove labels. Conditionally add git-lfs. >> : Read "git lfs?" environment >> variable and pass its value to the #:lfs? argument of git-fetch-with-fal= lback. >> Use INPUTS directly; update comment. >> derivation>: Add "git lfs?" to #:env-vars. >> (git-fetch/in-band): Express in terms of git-fetch/in-band*. >> (git-fetch/lfs): New procedure. >> * doc/guix.texi (origin Reference): Document it. >> >> Change-Id: I5b233b8642a7bdb8737b9d9b740e7254a89ccb25 >> --- >> >> Changes in v2: >> - Do not add lfs? to ; instead add a git-fetch/lfs proce= dure. > > I haven=E2=80=99t tested it but it looks great to me, thank you! Thanks for taking the time to review it! I'll push it shortly. --=20 Thanks, Maxim