From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id mKA0M3rcAmaLhgAAqHPOHw:P1 (envelope-from ) for ; Tue, 26 Mar 2024 15:32:26 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id mKA0M3rcAmaLhgAAqHPOHw (envelope-from ) for ; Tue, 26 Mar 2024 15:32:26 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=reproducible-builds.org header.s=1.vagrant header.b=kE6pGERH; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1711463546; a=rsa-sha256; cv=none; b=A3vtKWHxCsEG5ZG0N+Qfs1bF8J/0dh9Agf8VPT4tz2spnYRjoOAmJTZcOHLPoXguaVBwDb 7AWgbm3r+zCcg2ap5vH9Q/7Y0ctKtaT6iebkGsuMg271so/h/X+gBFNgaeugsaEPdTpiHH tQ3uVB64Hs6ThvhnU+8fUfLCzZu0z54h7RJ2C1jyJ9zE7PCAwPyyuM651CDtkxuuMOdrUt STE4y6l9zNVOv2GKTXVqX3IP+MxvuWeA628oQwQFEPV7zem5to083nMip2dnW0+PSxmzRb z7HIjLC4E8lcSDwXeHp+9WquxP6tVdzRffIcgjJ/SruvH4y1pnmppZMFqL8IrQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=reproducible-builds.org header.s=1.vagrant header.b=kE6pGERH; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1711463546; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=hjjMbGw0qaVBmaaHPJ1D8nvDU7/VLm/q2PNXdbgB+EA=; b=qCDqR68hlpTLdObKijvjGRikc2qKCEO285kB5zk7s9lADb2q1xQSvx6tlL++MhLbSW4JGk qmltAahApLln7zt3jsvrWnQkv9SstgKfETYwdhmG5fNEhM93Asko3bDbcdjoDacW0BIWoB YOYLxLGzDF5Ho82zP5Tygo3xajiTfcbsth5b9QlURXQC/iVA2CqjqHDQ1H6M6F5gPGBWi7 riZ1IigluWDeE9zp6XiMP+qsu5PUUgvBsRMy6F9GGIwfLpFaoDH5SPAT4m0jW7pEcYbk0n b0K63SIuGcp+FfYji4vPW6gPzsxXUixIqCQr+kX1IkXUxDQTvgzGVVRHIw/bfg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7397615E91 for ; Tue, 26 Mar 2024 15:32:26 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rp7qb-0001DM-BH; Tue, 26 Mar 2024 10:32:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rp7qN-0001Ag-RT for guix-patches@gnu.org; Tue, 26 Mar 2024 10:32:06 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rp7qM-0001Uo-Rk for guix-patches@gnu.org; Tue, 26 Mar 2024 10:32:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rp7qM-0008CS-7O for guix-patches@gnu.org; Tue, 26 Mar 2024 10:32:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70001] [PATCH] gnu: reprotest: Add missing propogated inputs Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 26 Mar 2024 14:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70001 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Skyler Ferris , 70001@debbugs.gnu.org Received: via spool by 70001-submit@debbugs.gnu.org id=B70001.171146350631492 (code B ref 70001); Tue, 26 Mar 2024 14:32:02 +0000 Received: (at 70001) by debbugs.gnu.org; 26 Mar 2024 14:31:46 +0000 Received: from localhost ([127.0.0.1]:34412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rp7q6-0008Bs-8h for submit@debbugs.gnu.org; Tue, 26 Mar 2024 10:31:46 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]:52554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rp7q2-0008Bd-Ix for 70001@debbugs.gnu.org; Tue, 26 Mar 2024 10:31:45 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50]) (Authenticated sender: vagrant@aikidev.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id C612C1AC97; Mon, 25 Mar 2024 23:03:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=reproducible-builds.org; s=1.vagrant; t=1711432984; bh=xnGVSdbXoSpNW6H50MykS5Tyixi8ssoIBuCjhKLZ2Rk=; h=From:To:Subject:In-Reply-To:References:Date:From; b=kE6pGERH8SHjp1GE+fiB5NAoqiTV1USD1ivLMdnKkgAsyadwZtTHfsBx5RjCz8TOt yyMkiDmfXiYWENRrigfTvDcVaR/HWtGIZE5gxPMTyyZiLJajlb19xPylVFmdcBqh/q rxHY7/eo13gFEcU6EwcsxwlSNc4H+H5JSzFiIa/+moulBW4eP/NZ7bTaHCJlPjJk1A Zu3DKhudoyJh92XrM8uvMgzQSSXwITHOr51nYfe4H2I0AgbkiKOcVGGfQegfBCaK9+ VQc0j/JaqeuPsMBNfmrlaARwlqPMty9a2uSRL6VOSFW2WqPwHyVbjqaxJ0bapuHYPL aH50xTtS1D/6Q== From: Vagrant Cascadian In-Reply-To: <7893aa6e-886b-4e74-999f-886a8ea0166b@protonmail.com> References: <7893aa6e-886b-4e74-999f-886a8ea0166b@protonmail.com> Date: Mon, 25 Mar 2024 23:02:58 -0700 Message-ID: <87a5mlttrh.fsf@wireframe> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: -1.94 X-Migadu-Queue-Id: 7397615E91 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -1.94 X-TUID: zKJE+PKevt2t --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2024-03-25, Skyler Ferris wrote: > This patch adds some propagated inputs to the reprotest package so that=20 > most tests can run in a pure shell. Thanks for taking an interest in this! My understanding is that propagated inputs are generally to be used very sparingly, as they make it very difficult to install multiple packages that might contain conflicting propagated inputs. Most of the proposed inputs are largely optional dependencies of reprotest, which in guix terms, generally the end-user is expected to install the additional packages to enable desired optional features. It might make sense to list the additional dependencies in the description describing what features each enables? Adding some of them to native-inputs might also make sense to enable more tests, and give a clear place to write comments about each. Then "guix shell --pure --development reprotest reprotest" would pull them in and reprotest itself to be able to run the relevent tests as you had tried. If reprotest behaves quite badly without some of the in the working environment, such as spitting out an ugly backtrace rather than reporting what is missing, it should probably be fixed upstream (and possibly patched in guix in the meantime). > Additionally, this patch adds a new build phase to call fusermount3=20 > instead of fusermount, which is the name of the command provided by=20 > Guix's fuse package. This does not make it work in a pure shell but it=20 > does make it work in an operating system that provides the suid version=20 > of the binary. It seems like this is missing from the patch, though I suspect it is needed to behave correctly with things relying on fuse! > You can try the suid-dependent tests with the same Makefile. The sudo=20 > and fuse-2 packages need to be installed; the default %setuid-programs=20 > variable includes the relevant binaries. Remove the `--pure` flag from=20 > the shell invocation and change the `--variations` flag in the reprotest= =20 > variations to have the value `"+fileordering, +user_group"`. Thanks for the detailed report ... this might be or should be covered by upstream documentation ... although if there are guix-specific angles on it, I am not sure where that should be documented. So, in summary, I think there are some ideas to explore from your patch, although it needs a bit of rethinking about implementation details. live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZgJlEgAKCRDcUY/If5cW ql6MAQCFuvjl8ilzN+E5UEQ77rP1KAlrTP/ng3iSoaIKjidvdAEAtAIjoHcQUsI5 AY97ABRglXwhhDprsqAnKFo8Irfr5QI= =U/yY -----END PGP SIGNATURE----- --=-=-=--