From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id EPiQOXQNTmZdfgEAe85BDQ:P1 (envelope-from ) for ; Wed, 22 May 2024 17:21:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id EPiQOXQNTmZdfgEAe85BDQ (envelope-from ) for ; Wed, 22 May 2024 17:21:25 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=dVthGkHr; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1716391284; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Xjol8P6vZruFFv8LI2MpmiRQjXr1t6SpeMeCykPNSzY=; b=iUsdx5wOYKGWbxtGEUtwkCWUtsM34yZ91XRAOtGvlcW7jta0vsyBXeRU1DKo0hDwInLvSh RyMoSkX343yYfT5pQZfJevgstQ+XRBwAWp54WReTIzhvsfneehlrSj14/1011ZDzoFxxHk /lVJUQKjZNpsvGrdUr9e4hQLG107Px9zN9U/PTiRiU+3LDZLHjTal205NAF3WvggTSxH1J YOCI0HQWU3JPXR8FK5KlQswtYFy4QPD7V8pY5q5wh/zPGi3Q1c+10JCmish/Qu6VitBwIp d9/1kXKVf5dNX56Gh1iM0Wrs9MXRRKErmmsESrgxyTQ2vFxzARldD8m+8BJfqg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=dVthGkHr; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1716391284; a=rsa-sha256; cv=none; b=e31N6jR5w969ze4yU3cHuTl49n7c4ih7MwyzjzCd0rcaPnYSBmJt912UoW2FJV21SuxSCZ lHlQzpN4VfrsHTeOJssp4J+CH6WVFdgtj3gwyIaspC7MuBneaWu+S67TfTF5uOgO+/jiha 4badDzoYBEhcXLA/bf/d1TpV3ePZn7R27uTf5/Fag78WkkBUc+FyOYC4kDkSM2kV9ABTmz 0WMZ6I3HDyV5Vii7q+PgHgDLZZvEywuV2zlHvw+5WSXrc5wtsQQJDvLdpq+pGCVF5/H6Zm VkxMeCerbwP0YMrrqWLLZ7cD35mw4io3ypF5c1i0SD9pyXO6RlGoNytkhrYB9A== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B8C7C51C16 for ; Wed, 22 May 2024 17:21:24 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s9nm4-0007OD-2z; Wed, 22 May 2024 11:21:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s9nlx-0007L9-CH for guix-patches@gnu.org; Wed, 22 May 2024 11:20:58 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s9nlx-0004W0-3Q for guix-patches@gnu.org; Wed, 22 May 2024 11:20:57 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s9nm2-0004Hd-JY for guix-patches@gnu.org; Wed, 22 May 2024 11:21:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71038] [PATCH 1/2] guix: store: Enable specifying the available builtin builders. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 22 May 2024 15:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71038 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines , 71038@debbugs.gnu.org Cc: Josselin Poiret , Mathieu Othacehe , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , Ricardo Wurmus , Christopher Baines Received: via spool by 71038-submit@debbugs.gnu.org id=B71038.171639125716431 (code B ref 71038); Wed, 22 May 2024 15:21:02 +0000 Received: (at 71038) by debbugs.gnu.org; 22 May 2024 15:20:57 +0000 Received: from localhost ([127.0.0.1]:56597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9nlx-0004Gt-76 for submit@debbugs.gnu.org; Wed, 22 May 2024 11:20:57 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:38745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9nls-0004Gi-Nb for 71038@debbugs.gnu.org; Wed, 22 May 2024 11:20:56 -0400 Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-354ba9ae540so149420f8f.3 for <71038@debbugs.gnu.org>; Wed, 22 May 2024 08:20:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716391181; x=1716995981; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=Xjol8P6vZruFFv8LI2MpmiRQjXr1t6SpeMeCykPNSzY=; b=dVthGkHrdxjdunrgD83D7yXncbIcPDaxw3GEPwnQk92Iox+JNITG7ge19XnpdAF7rt kLYJ6aeV7qVCunHPdfPupxzzbpgUQQpgdLOKfEpZ9r7uKdB9N9yJbmZO7dJoZZKbPAbI /Ckn/+YCfTb8FCmM5jy/ZytVkxqodWH1xpTU8qUkvZCsl3bUbvmTBQeKZnMUqN05YMM0 /toDQw+zrtK0L7dePcrrAOjsvUGzDVxemuRzf0Qo893V0ZsKw4CDDWeflNg2hwlVYUxh 4cOlzuKl7rzXwYWXMi9OF7UmXKolxlwEPmFaJYs7MUM0PkV36r7g5lYTt5ECSdsAK7/t 3k+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716391181; x=1716995981; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Xjol8P6vZruFFv8LI2MpmiRQjXr1t6SpeMeCykPNSzY=; b=rZlwV342mQE4KCqZkmXaXFaY2mZYumQEXVxBj/XEmvgyLKf/1SA+npzrU3DdCepMqu fnvsCG6hGhf8ajgXjjcMWJdSMbBC588yVriMsqM8+cSz56tr8I+kj7HmVMa/+xMlscL1 RYnLLeVJfz+7o+ILywwJe7rLuhuAocQY942kOXdxtdDtadvGRu3h+C/Kdzr3WHCmf/5M xhhfqNvdJ10I46gAjZu9mehP30page5Wvc+ITg51230JsAEdV24NJ59I2ubmBijeuSPc BFuaZTXgmCzHxGPVINbgPKXibVQGmzGR/jdHCYA0GwKf2fGAaFfh9gq7uLoGnDLDC91p Us+A== X-Forwarded-Encrypted: i=1; AJvYcCW4VQP7f79CQ6GcB0N1gZ5Qqn2ELrg7/styPFtlWIt0T86pIJMqNWMYUn6Q0Fmt5LBQDBPkLXVKNx+kJIl5HCef7ar3Ilk= X-Gm-Message-State: AOJu0YyZ9lnOVIoCV+RQEWLYyK6bGg7hCbGQpVam6zMHBi4rO43YX/Cj n/d9oAaJR7ptK1No69h4EyMl0a4doz8aITATmadELLf9JLLU1UDc X-Google-Smtp-Source: AGHT+IE0eoTAtu38wzsqei4bfE2bhlcOLMFg7Yi8ZjPglX+bRJakIWFJ0sxcxAIjnCyr4Cazd/BkkQ== X-Received: by 2002:a05:600c:3544:b0:41b:e83e:8bb with SMTP id 5b1f17b1804b1-420fd376c84mr17464795e9.3.1716391181116; Wed, 22 May 2024 08:19:41 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:c865:f7ad:a866:6eca]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-420149b1c24sm394437145e9.41.2024.05.22.08.19.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 May 2024 08:19:40 -0700 (PDT) From: Simon Tournier In-Reply-To: <6b9c634c024b6fd7a50d3b82edc244676a8ca8e8.1716038375.git.mail@cbaines.net> References: <87y187b6xv.fsf@cbaines.net> <6b9c634c024b6fd7a50d3b82edc244676a8ca8e8.1716038375.git.mail@cbaines.net> Date: Wed, 22 May 2024 12:58:12 +0200 Message-ID: <87a5ki3ygr.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 2.64 X-Spam-Score: 2.64 X-Migadu-Queue-Id: B8C7C51C16 X-Migadu-Scanner: mx13.migadu.com X-TUID: 2hYJ0BapkACz Hi Chris, On sam., 18 mai 2024 at 14:19, Christopher Baines wrote: > diff --git a/guix/store.scm b/guix/store.scm > index 58ddaa8d15..0c734cdca7 100644 > --- a/guix/store.scm > +++ b/guix/store.scm > @@ -571,7 +571,7 @@ (define* (connect-to-daemon uri #:key non-blocking?) > > (define* (open-connection #:optional (uri (%daemon-socket-uri)) > #:key port (reserve-space? #t) cpu-affinity > - non-blocking?) > + non-blocking? assume-available-builtin-builders) Why add the variable %assume-available-builtin-builders and default to it? Something like: --8<---------------cut here---------------start------------->8--- (define %assume-available-builtin-builders "List of builtin builders supported by the builder Guix daemon." (list "download" "git-download")) (define* (open-connection #:optional (uri (%daemon-socket-uri)) #:key port (reserve-space? #t) cpu-affinity non-blocking?) non-blocking? (assume-available-builtin-builders %assume-available-builtin-builders)) --8<---------------cut here---------------end--------------->8--- And then default to this %assume-available-builtin-builders elsewhere in [PATCH 2/2]. IMHO, it changes almost nothing but it would help to know (document) what to pass as argument. Cheers, simon