[bug#74849] [PATCH 4/6] gnu: make-arm-trusted-firmware: Use guix-name.

[Vagrant Cascadian <vagrant@debian.org>]

[-- Attachment #1: Type: text/plain, Size: 4729 bytes --]

On 2024-12-13, Herman Rimm wrote:
> * gnu/packages/firmware.scm (make-arm-trusted-firmware): Use guix-name.
> (arm-trusted-firmware-sun50i-a64): Return base package directly.

With this patch applied, I get:

error: guix-name: unbound variable
hint: Did you forget a `use-modules' form?

error: googletest: unbound variable
hint: Did you forget a `use-modules' form?

error: bzip2: unbound variable
hint: Did you forget a `use-modules' form?

error: xorg-server: unbound variable
hint: Did you forget a `use-modules' form?

error: libusb: unbound variable
hint: Did you forget a `use-modules' form?

error: zstd: unbound variable
hint: Did you forget a `use-modules' form?

error: gash: unbound variable
hint: Did you forget a `use-modules' form?                                                                                              
error: cross-gcc-toolchain: unbound variable
hint: Did you forget `(use-modules (gnu packages cross-base))'?
                                                                                                                                       error: gnu-make: unbound variable
hint: Did you forget a `use-modules' form?

error: tar: unbound variable
hint: Did you forget a `use-modules' form?

error: cross-binutils: unbound variable
hint: Did you forget `(use-modules (gnu packages cross-base))'?

error: webrtc-audio-processing: unbound variable
hint: Did you forget a `use-modules' form?

Throw to key `unbound-variable' with args `("resolve-interface" "no binding `~A' in module ~A" (shared-mime-info (gnu packages freedeskt
op)) #f)'.
Backtrace:
In guix/status.scm:
    839:4 19 (call-with-status-report _ _)
In ice-9/boot-9.scm:
  1752:10 18 (with-exception-handler _ _ #:unwind? _ # _)
In guix/store.scm:
   689:37 17 (thunk)
   1330:8 16 (call-with-build-handler #<procedure ffff8ce3ea20 at g…> …)
In guix/scripts/build.scm:
    646:2 15 (_)
   695:42 14 (loop _ _ ())
In gnu/packages.scm:                                                                                                                        511:2 13 (%find-package "arm-trusted-firmware-sun50i-a64" "arm-…" …)
    391:6 12 (find-best-packages-by-name _ _)
   321:56 11 (_ "arm-trusted-firmware-sun50i-a64" _)
In unknown file:
          10 (force #<promise #<procedure ffff8db69440 at gnu/packag…>)
In gnu/packages.scm:
   243:33  9 (fold-packages #<procedure ffff8c487750 at gnu/package…> …)
In guix/discovery.scm:
   158:11  8 (all-modules _ #:warn _)
In srfi/srfi-1.scm:
   460:18  7 (fold #<procedure ffff8ceb0500 at guix/discovery.scm:1…> …)
In guix/discovery.scm:
   148:19  6 (_ _ ())
    115:5  5 (scheme-modules _ _ #:warn _)
In srfi/srfi-1.scm:
   691:23  4 (filter-map #<procedure ffff8ceb03a0 at guix/discove…> . #)
In guix/discovery.scm:
   123:24  3 (_ . _)
In guix/ui.scm:
    363:2  2 (report-unbound-variable-error _ #:frame _)
In ice-9/boot-9.scm:
  1685:16  1 (raise-exception _ #:continuable? _)
  1685:16  0 (raise-exception _ #:continuable? _)

ice-9/boot-9.scm:1685:16: In procedure raise-exception:
Throw to key `match-error' with args `("match" "no matching pattern" (unbound-variable "resolve-interface" "no binding `~A' in module ~A" (shared-mime-info (gnu packages freedesktop)) #f))'.

>
> Change-Id: I23f05ac5e8e897037cd8d8afc4e747b05e56e32d
> ---
>  gnu/packages/firmware.scm | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/gnu/packages/firmware.scm b/gnu/packages/firmware.scm
> index ff083a2c6f..438b347dfb 100644
> --- a/gnu/packages/firmware.scm
> +++ b/gnu/packages/firmware.scm
> @@ -1105,7 +1105,7 @@ (define* (make-arm-trusted-firmware platform
>          ;;%current-system is a *triplet*, unlike its name would suggest.
>          (string=? (%current-system) (gnu-triplet->nix-system triplet))))
>    (package
> -    (name (string-append "arm-trusted-firmware-" platform))
> +    (name (guix-name "arm-trusted-firmware-" platform))
>      (version "2.9")
>      (source
>       (origin
> @@ -1157,10 +1157,7 @@ (define* (make-arm-trusted-firmware platform
>                     license:bsd-2)))) ; libfdt
>  
>  (define-public arm-trusted-firmware-sun50i-a64
> -  (let ((base (make-arm-trusted-firmware "sun50i_a64")))
> -    (package
> -      (inherit base)
> -      (name "arm-trusted-firmware-sun50i-a64"))))
> +  (make-arm-trusted-firmware "sun50i_a64"))
>  
>  (define-public arm-trusted-firmware-rk3328
>    (make-arm-trusted-firmware "rk3328"))
> -- 
> 2.45.2

I presume there is some module from which to import guix-name?

Without the patch applied, it gets further...

live well,
  vagrant

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]