all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#74993] [PATCH] guix: toml: Fix evaluation of empty inline tables.
@ 2024-12-20 11:29 Lars-Dominik Braun
  2024-12-25 22:31 ` Ludovic Courtès
  0 siblings, 1 reply; 3+ messages in thread
From: Lars-Dominik Braun @ 2024-12-20 11:29 UTC (permalink / raw)
  To: 74993

* guix/build/toml.scm (eval-toml-file): Add pattern for empty inline table.
* tests/toml.scm ("parse-toml: Empty inline table"): New testcase.

Change-Id: I69663af2a861716acfb801fad4474e029e102a1b
---
 guix/build/toml.scm | 1 +
 tests/toml.scm      | 8 ++++++++
 2 files changed, 9 insertions(+)

diff --git a/guix/build/toml.scm b/guix/build/toml.scm
index 81b54fa5b7..a9be0887e7 100644
--- a/guix/build/toml.scm
+++ b/guix/build/toml.scm
@@ -414,6 +414,7 @@ (define (eval-toml-file parse-tree)
                                           local-time)
                                         tails)))
       ('array (list))
+      ('inline-table '())
       (('inline-table tails ...)
        (eval (keyword-flatten '(keyval) tails) '() '()))))
 
diff --git a/tests/toml.scm b/tests/toml.scm
index cd8e4d2338..64bc667f0c 100644
--- a/tests/toml.scm
+++ b/tests/toml.scm
@@ -396,6 +396,14 @@ (define-module (test-toml)
 point = { x = 1, y = 2 }
 animal = { type.name = \"pug\" }"))
 
+(test-equal "parse-toml: Empty inline table"
+ '(("name")
+   ("point")
+   ("animal"))
+ (parse-toml "name = {}
+point = { }
+animal = {    }"))
+
 (test-error "parse-toml: Invalid assignment to inline table"
  #t
  (parse-toml "[product]

base-commit: 946e48d1d87ec451e7a6315712f2e86c79961a51
-- 
2.45.2





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#74993] [PATCH] guix: toml: Fix evaluation of empty inline tables.
  2024-12-20 11:29 [bug#74993] [PATCH] guix: toml: Fix evaluation of empty inline tables Lars-Dominik Braun
@ 2024-12-25 22:31 ` Ludovic Courtès
  2024-12-26 21:14   ` Lars-Dominik Braun
  0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2024-12-25 22:31 UTC (permalink / raw)
  To: Lars-Dominik Braun; +Cc: 74993

Lars-Dominik Braun <lars@6xq.net> skribis:

> * guix/build/toml.scm (eval-toml-file): Add pattern for empty inline table.
> * tests/toml.scm ("parse-toml: Empty inline table"): New testcase.
>
> Change-Id: I69663af2a861716acfb801fad4474e029e102a1b

LGTM!




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bug#74993] [PATCH] guix: toml: Fix evaluation of empty inline tables.
  2024-12-25 22:31 ` Ludovic Courtès
@ 2024-12-26 21:14   ` Lars-Dominik Braun
  0 siblings, 0 replies; 3+ messages in thread
From: Lars-Dominik Braun @ 2024-12-26 21:14 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 74993

Hi,

> LGTM!

thanks. Since pyproject-build-system depends on (guix build toml) this
is a world-rebuilding change. Can we piggyback this patch onto another
(possibly unrelated) world-rebuilding branch?

Lars





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-12-26 21:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-20 11:29 [bug#74993] [PATCH] guix: toml: Fix evaluation of empty inline tables Lars-Dominik Braun
2024-12-25 22:31 ` Ludovic Courtès
2024-12-26 21:14   ` Lars-Dominik Braun

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.