From: ludo@gnu.org (Ludovic Courtès)
To: Andreas Enge <andreas@enge.fr>
Cc: bug-guix@gnu.org
Subject: Re: #!/usr/bin/env perl
Date: Sat, 23 Feb 2013 16:15:51 +0100 [thread overview]
Message-ID: <878v6f6oyg.fsf@gnu.org> (raw)
In-Reply-To: <201302230103.21985.andreas@enge.fr> (Andreas Enge's message of "Sat, 23 Feb 2013 01:03:21 +0100")
Andreas Enge <andreas@enge.fr> skribis:
> Am Samstag, 23. Februar 2013 schrieb Ludovic Courtès:
>> > (make-regexp
>> > "^[[:blank:]]*([[:graph:]]+)[[:blank:]]*([[:graph:]]*)(.*)$")))
>>
>> I think it should be a + after the second [[:blank:]], because there
>> should be space between the interpreter name and its argument.
>
> Sometimes, there is no space at all: In
> #!/usr/bin/perl
> for instance, when there is no argument. Then the "+" version would fail.
> With "*", it works as expected.
Oh, right.
>> > + (if has-env
>> > + (begin
>> Please align with the ‘h’ here...
>> > + (patch p bin
>> > + (string-append " " second
>> > third)))))
>> ... and with the ‘p’ here.
>
> Ok. The annoying thing with this way of indenting is that lines become very
> long very quickly; I like keeping them at less than 80 characters.
When it becomes too long, it’s sometimes a sign that an auxiliary
function may be needed.
Thanks!
Ludo’.
next prev parent reply other threads:[~2013-02-23 15:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-26 20:31 #!/usr/bin/env perl Andreas Enge
2013-01-26 21:09 ` Ludovic Courtès
2013-02-22 22:13 ` Andreas Enge
2013-02-22 23:26 ` Ludovic Courtès
2013-02-23 0:03 ` Andreas Enge
2013-02-23 15:15 ` Ludovic Courtès [this message]
2013-02-23 16:21 ` Andreas Enge
2013-02-23 17:31 ` Ludovic Courtès
2013-02-23 17:48 ` Andreas Enge
2013-02-23 18:45 ` Ludovic Courtès
2013-02-23 18:58 ` Andreas Enge
2013-02-23 19:14 ` Ludovic Courtès
2013-02-23 19:19 ` Andreas Enge
2013-02-25 2:49 ` Mark H Weaver
2013-02-25 9:43 ` Andreas Enge
2013-02-25 15:40 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878v6f6oyg.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=andreas@enge.fr \
--cc=bug-guix@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.